Only initialize the native client once

Author: HazAT

android/src/main/java/io/sentry/RNSentryModule.java

@@ -56,6 +56,7 @@ public class RNSentryModule extends ReactContextBaseJavaModule {
     final static Logger logger = Logger.getLogger("react-native-sentry");
     private static WritableNativeMap extra;
     private static ReadableMap tags;
+    private static SentryClient sentryClient;
 
     public RNSentryModule(ReactApplicationContext reactContext, ReactApplication reactApplication) {
         super(reactContext);
@@ -83,7 +84,11 @@ public Map<String, Object> getConstants() {
 
     @ReactMethod
     public void startWithDsnString(String dsnString) {
-        SentryClient sentryClient = Sentry.init(dsnString, new AndroidSentryClientFactory(this.getReactApplicationContext()));
+        if (sentryClient != null) {
+            logger.info(String.format("Already started, use existing client '%s'", dsnString));
+            return;
+        }
+        sentryClient = Sentry.init(dsnString, new AndroidSentryClientFactory(this.getReactApplicationContext()));
         androidHelper = new AndroidEventBuilderHelper(this.getReactApplicationContext());
         sentryClient.addEventSendCallback(new EventSendCallback() {
             @Override

ios/RNSentry.m

@@ -181,27 +181,30 @@ - (void)setReleaseVersionDist:(SentryEvent *)event {
 
 RCT_EXPORT_METHOD(startWithDsnString:(NSString * _Nonnull)dsnString)
 {
-    NSError *error = nil;
-    SentryClient *client = [[SentryClient alloc] initWithDsn:dsnString didFailWithError:&error];
-    [SentryClient setSharedClient:client];
-    [SentryClient.sharedClient startCrashHandlerWithError:&error];
-    if (error) {
-        [NSException raise:@"SentryReactNative" format:@"%@", error.localizedDescription];
-    }
-    SentryClient.sharedClient.shouldSendEvent = ^BOOL(SentryEvent * _Nonnull event) {
-        // We don't want to send an event after startup that came from a NSException of react native
-        // Because we sent it already before the app crashed.
-        if (nil != event.exceptions.firstObject.type &&
-            [event.exceptions.firstObject.type rangeOfString:@"RCTFatalException"].location != NSNotFound) {
-            NSLog(@"RCTFatalException");
-            return NO;
+    static dispatch_once_t onceStartToken;
+    dispatch_once(&onceStartToken, ^{
+        NSError *error = nil;
+        SentryClient *client = [[SentryClient alloc] initWithDsn:dsnString didFailWithError:&error];
+        [SentryClient setSharedClient:client];
+        [SentryClient.sharedClient startCrashHandlerWithError:&error];
+        if (error) {
+            [NSException raise:@"SentryReactNative" format:@"%@", error.localizedDescription];
         }
-        return YES;
-    };
-    SentryClient.sharedClient.beforeSerializeEvent = ^(SentryEvent * _Nonnull event) {
-        [self injectReactNativeFrames:event];
-        [self setReleaseVersionDist:event];
-    };
+        SentryClient.sharedClient.shouldSendEvent = ^BOOL(SentryEvent * _Nonnull event) {
+            // We don't want to send an event after startup that came from a NSException of react native
+            // Because we sent it already before the app crashed.
+            if (nil != event.exceptions.firstObject.type &&
+                [event.exceptions.firstObject.type rangeOfString:@"RCTFatalException"].location != NSNotFound) {
+                NSLog(@"RCTFatalException");
+                return NO;
+            }
+            return YES;
+        };
+        SentryClient.sharedClient.beforeSerializeEvent = ^(SentryEvent * _Nonnull event) {
+            [self injectReactNativeFrames:event];
+            [self setReleaseVersionDist:event];
+        };
+    });
 }
 
 RCT_EXPORT_METHOD(activateStacktraceMerging:(RCTPromiseResolveBlock)resolve