Skip to content

Commit c365469

Browse files
fix: Auto add release and dist to every artifact upload (#3540)
1 parent 46f3245 commit c365469

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
- Sentry CLI 2.25.1 fixes background debug files uploads during Xcode builds ([#3486](https://github.com/getsentry/sentry-react-native/pull/3486))
2828
- Performance Tracing should be disabled by default ([#3533](https://github.com/getsentry/sentry-react-native/pull/3533))
2929
- Use `$NODE_BINARY` to execute Sentry CLI in Xcode scripts ([#3493](https://github.com/getsentry/sentry-react-native/pull/3493))
30+
- Return auto Release and Dist to source maps auto upload ([#3540](https://github.com/getsentry/sentry-react-native/pull/3540))
3031

3132
### Dependencies
3233

scripts/sentry-xcode.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ LOCAL_NODE_BINARY=${NODE_BINARY:-node}
1717

1818
REACT_NATIVE_XCODE=$1
1919

20-
[[ "$AUTO_RELEASE" != true ]] && [[ -z "$BUNDLE_COMMAND" || "$BUNDLE_COMMAND" != "ram-bundle" ]] && NO_AUTO_RELEASE="--no-auto-release"
20+
[[ "$AUTO_RELEASE" == false ]] && [[ -z "$BUNDLE_COMMAND" || "$BUNDLE_COMMAND" != "ram-bundle" ]] && NO_AUTO_RELEASE="--no-auto-release"
2121
ARGS="$NO_AUTO_RELEASE $SENTRY_CLI_EXTRA_ARGS $SENTRY_CLI_RN_XCODE_EXTRA_ARGS"
2222

2323
REACT_NATIVE_XCODE_WITH_SENTRY="\"$SENTRY_CLI_EXECUTABLE\" react-native xcode $ARGS \"$REACT_NATIVE_XCODE\""

sentry.gradle

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -130,10 +130,9 @@ gradle.projectsEvaluated {
130130
def process = ["node", hasSourceMapDebugIdScript, sourcemapOutput].execute(null, new File("$reactRoot"))
131131
def exitValue = process.waitFor()
132132
project.logger.lifecycle("Check generated source map for Debug ID: ${process.text}")
133-
def notIncludeRelease = "$bundleCommand" == "bundle" && exitValue == 0
134-
def not = notIncludeRelease ? 'not ' : ''
135-
project.logger.lifecycle("Sentry Source Maps upload will ${not}include the release name and dist.")
136-
extraArgs.addAll(notIncludeRelease ? [] : [
133+
134+
project.logger.lifecycle("Sentry Source Maps upload will include the release name and dist.")
135+
extraArgs.addAll([
137136
"--release", releaseName,
138137
"--dist", versionCode
139138
])

0 commit comments

Comments
 (0)