Merge pull request #209 from getsentry/bugfix/babel-preset

Fix babel-preset

Author: HazAT

SentryReactNative.podspec

@@ -18,8 +18,8 @@ Pod::Spec.new do |s|
   s.preserve_paths = '*.js'
 
   s.dependency 'React'
-  s.dependency 'Sentry', '~> 3.6.0'
-  s.dependency 'Sentry/KSCrash', '~> 3.6.0'
+  s.dependency 'Sentry', '~> 3.6.1'
+  s.dependency 'Sentry/KSCrash', '~> 3.6.1'
 
   s.source_files = 'ios/RNSentry*.{h,m}'
   s.public_header_files = 'ios/RNSentry.h'

appium/check_run_failues.rb

@@ -48,25 +48,25 @@ def ios_check
     @problems.unique_problems.each do |up|
         raise RuntimeError, "No failed tests: #{up.inspect}" unless up.length == 2
         up[1].each do |p|
-            if p.problems[0].test.name == 'test_throw_error'
+            if p.problems[0].test.name == 'test_throw_error' || p.problems[0].test.name == 'test_native_crash'
                 artifacts = @client.list_artifacts({
                     type: "FILE",
                     arn: p.problems[0].test.arn
                 })
                 artifacts.artifacts.each do |a|
                     if a.name == 'Syslog'
                         content = open(a.url).read
-                        raise RuntimeError, "No JSON SENT: #{p.inspect}" unless content.scan(/Sentry - Verbose:: Sending JSON/).size == 1
-                        raise RuntimeError, "Wrong exception value: #{p.inspect}" unless content.scan(/"value" : "Sentry: Test throw error"/).size == 1
-                        raise RuntimeError, "No javascript frames: #{p.inspect}" unless content.scan(/"platform" : "javascript"/).size >= 1
+                        if p.problems[0].test.name == 'test_throw_error'
+                            raise RuntimeError, "Sentry should start twice: #{p.inspect}" unless content.scan(/Sentry Started -- Version/).size == 2
+                            raise RuntimeError, "No JSON SENT: #{p.inspect}" unless content.scan(/Sentry - Debug:: Request status: 200/).size == 1
+                        elsif p.problems[0].test.name == 'test_native_crash'
+                            raise RuntimeError, "Sentry should start twice: #{p.inspect}" unless content.scan(/Sentry Started -- Version/).size == 2
+                            raise RuntimeError, "No JSON SENT: #{p.inspect}" unless content.scan(/Sentry - Debug:: Request status: 200/).size == 1
+                            raise RuntimeError, "exception_name should be EXC_BREAKPOINT: #{p.inspect}" unless content.scan(/"exception_name" : "EXC_BREAKPOINT"/).size == 1
+                        end
                     end
                 end
             end
-            if p.problems[0].test.name == 'test_native_crash'
-                exception = p.message.match(/crashed: EXC_/)
-                raise RuntimeError, "No crash: #{p.inspect}" unless !exception.nil?
-                exception = nil
-            end
         end
     end
 end

appium/tests/test_ios.py

@@ -57,9 +57,31 @@ def test_dist(driver):
 def test_throw_error(driver):
     driver.find_element_by_accessibility_id('throw error').click()
     driver.relaunch_app()
+    sleep(3)
     value = extractText(driver)
-    # the crash should have been already sent
-    assert value is None
+    assert value != None
+    event = json.loads(value)
+
+    assert len(event['breadcrumbs']) > 0
+    assert len(event['contexts']) > 0
+    for thread in event['exception']['values']:
+        assert len(thread['stacktrace']['frames']) > 0
+        cocoa_frames = 0
+        js_frames = 0
+        for frame in thread['stacktrace']['frames']:
+            if frame.get('package', None):
+                cocoa_frames += 1
+            if frame.get('platform', None) == 'javascript':
+                js_frames += 1
+        assert js_frames > 0
+    assert len(event['exception']['values']) > 0
+    assert event['exception']['values'][0]['value'] == "Sentry: Test throw error"
+    assert event['exception']['values'][0]['type'] == "Error"
+    assert event['platform'] == 'cocoa'
+    assert event['level'] == 'fatal'
+    assert event['extra']['react']
+    assert event['tags']['react'] == '1'
+    assert len(event['user']) > 0
 
 def test_native_crash(driver):
     sleep(2)
@@ -74,20 +96,19 @@ def test_native_crash(driver):
     assert len(event['breadcrumbs']) > 0
     assert len(event['contexts']) > 0
     assert len(event['threads']['values']) > 0
-    for thread in event['threads']['values']:
-        if thread['crashed']:
-            assert len(thread['stacktrace']['frames']) > 0
-            cocoa_frames = 0
-            js_frames = 0
-            for frame in thread['stacktrace']['frames']:
-                if frame.get('package', None):
-                    cocoa_frames += 1
-                if frame.get('platform', None) == 'javascript':
-                    js_frames += 1
-            assert cocoa_frames > 0
-            assert js_frames > 0 # does not work in release build
+    for thread in event['exception']['values']:
+        assert len(thread['stacktrace']['frames']) > 0
+        cocoa_frames = 0
+        js_frames = 0
+        for frame in thread['stacktrace']['frames']:
+            if frame.get('package', None):
+                cocoa_frames += 1
+            if frame.get('platform', None) == 'javascript':
+                js_frames += 1
+        assert cocoa_frames > 0
     assert len(event['exception']['values']) > 0
     assert len(event['debug_meta']['images']) > 0
+    assert event['exception']['values'][0]['value'] == 'crash'
     assert event['platform'] == 'cocoa'
     assert event['level'] == 'fatal'
     assert event['extra']['react']