Bump core to RN 0.80.1
#5181
Open
Bump core to RN 0.80.1
#5181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c7f264b | 434.98 ms | 452.96 ms | 17.98 ms |
| bfe454a+dirty | 573.44 ms | 579.46 ms | 6.02 ms |
| 534ba8c | 484.00 ms | 499.93 ms | 15.93 ms |
| 0b64753+dirty | 448.67 ms | 474.61 ms | 25.94 ms |
| 64cd15c | 439.02 ms | 427.63 ms | -11.39 ms |
| 459a438+dirty | 417.09 ms | 406.52 ms | -10.57 ms |
| d751a5d+dirty | 434.24 ms | 486.08 ms | 51.84 ms |
| 955f2eb+dirty | 422.74 ms | 410.19 ms | -12.55 ms |
| 8d89cc9+dirty | 537.83 ms | 536.02 ms | -1.81 ms |
| a0b15d6 | 423.06 ms | 437.77 ms | 14.71 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c7f264b | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| bfe454a+dirty | 17.75 MiB | 19.69 MiB | 1.94 MiB |
| 534ba8c | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 0b64753+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 64cd15c | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 459a438+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| d751a5d+dirty | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 955f2eb+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 8d89cc9+dirty | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| a0b15d6 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7be1f99+dirty | 1226.69 ms | 1217.76 ms | -8.93 ms |
| eb07ba3+dirty | 1222.46 ms | 1220.37 ms | -2.08 ms |
| 5c16cdc+dirty | 1209.32 ms | 1210.67 ms | 1.35 ms |
| 69602ce+dirty | 1235.65 ms | 1230.82 ms | -4.83 ms |
| 8a4ce6f+dirty | 1221.31 ms | 1219.84 ms | -1.47 ms |
| 95aaf8a+dirty | 1234.78 ms | 1241.94 ms | 7.16 ms |
| 98f632c+dirty | 1236.40 ms | 1241.62 ms | 5.22 ms |
| 3e0a5f9+dirty | 1226.94 ms | 1230.02 ms | 3.08 ms |
| ba75c7c+dirty | 1235.86 ms | 1226.45 ms | -9.41 ms |
| 276d348+dirty | 1224.22 ms | 1227.38 ms | 3.16 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7be1f99+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| eb07ba3+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 5c16cdc+dirty | 2.63 MiB | 3.96 MiB | 1.33 MiB |
| 69602ce+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| 8a4ce6f+dirty | 2.63 MiB | 3.96 MiB | 1.33 MiB |
| 95aaf8a+dirty | 2.63 MiB | 3.87 MiB | 1.24 MiB |
| 98f632c+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 3e0a5f9+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| ba75c7c+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 276d348+dirty | 2.63 MiB | 3.98 MiB | 1.34 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c1573b3+dirty | 355.65 ms | 448.82 ms | 93.17 ms |
| 818a608+dirty | 350.29 ms | 397.38 ms | 47.09 ms |
| d916aa3+dirty | 411.72 ms | 451.76 ms | 40.03 ms |
| a0b15d6+dirty | 414.33 ms | 448.85 ms | 34.52 ms |
| bfe454a+dirty | 372.42 ms | 424.52 ms | 52.10 ms |
| af9331b+dirty | 374.42 ms | 425.68 ms | 51.26 ms |
| 0b64753+dirty | 358.55 ms | 429.16 ms | 70.61 ms |
| c9e95bd+dirty | 339.32 ms | 401.24 ms | 61.92 ms |
| 459a438+dirty | 359.50 ms | 390.53 ms | 31.03 ms |
| d751a5d+dirty | 341.61 ms | 403.06 ms | 61.45 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c1573b3+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 818a608+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| d916aa3+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| a0b15d6+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| bfe454a+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| af9331b+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 0b64753+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| c9e95bd+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 459a438+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| d751a5d+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
antonis
reviewed
Sep 29, 2025
antonis
reviewed
Sep 29, 2025
| ], | ||
| "peerDependencies": { | ||
| "expo": ">=49.0.0", | ||
| "react": ">=17.0.0", |
There was a problem hiding this comment.
q: Why do we remove the "react" peer depencency?
antonis
reviewed
Sep 29, 2025
| includeUpdates: true, | ||
| }), | ||
| expect.anything(), | ||
| expect.toBeNil() |
There was a problem hiding this comment.
q: Do we know why the second parameter changed? Does it affect the profiler?
antonis
reviewed
Sep 29, 2025
There was a problem hiding this comment.
Thank you for you work on this @alwx 🙇
Overall the changes LGTM 🚀
I think the only blocking thing is the Native test failure on iOS. I haven't looked at it in detail but some of the errors might be related to the folly. We added some check here some time ago. Probably the Cocoa Tester needs something similar 🤔
alwx
force-pushed
the
alwx/improvement/core-0.80
branch
2 times, most recently
from
33bf13b to
dd7d431
Compare
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bc9680d+dirty | 1228.57 ms | 1233.64 ms | 5.07 ms |
| c9e95bd+dirty | 1205.83 ms | 1207.38 ms | 1.55 ms |
| c1573b3+dirty | 1245.69 ms | 1245.48 ms | -0.21 ms |
| 49ef936+dirty | 1221.27 ms | 1221.60 ms | 0.34 ms |
| 8d89cc9+dirty | 1232.35 ms | 1228.53 ms | -3.82 ms |
| e2fa43d+dirty | 1224.43 ms | 1235.40 ms | 10.98 ms |
| 9f211e3+dirty | 1215.38 ms | 1218.15 ms | 2.77 ms |
| 7be1f99+dirty | 1222.43 ms | 1217.15 ms | -5.28 ms |
| 21c9e75+dirty | 1206.20 ms | 1223.54 ms | 17.35 ms |
| 5c16cdc+dirty | 1235.67 ms | 1241.18 ms | 5.51 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bc9680d+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| c9e95bd+dirty | 3.19 MiB | 4.44 MiB | 1.25 MiB |
| c1573b3+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 49ef936+dirty | 3.19 MiB | 4.54 MiB | 1.36 MiB |
| 8d89cc9+dirty | 3.19 MiB | 4.53 MiB | 1.35 MiB |
| e2fa43d+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 9f211e3+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| 7be1f99+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 21c9e75+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 5c16cdc+dirty | 3.19 MiB | 4.53 MiB | 1.34 MiB |
alwx
force-pushed
the
alwx/improvement/core-0.80
branch
from
e439ca5 to
f293655
Compare
alwx
force-pushed
the
alwx/improvement/core-0.80
branch
from
f293655 to
5f9c0aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
After we've got rid of
react-test-renderer, nothing was blocking us from upgrading core to 0.80. Because some mocks were missing in 0.80.0 (facebook/react-native#51993), the update was done to 0.80.1 straight away.In addition to that, tests were updated (just because some of them required certain modifications after the RN version bump).
📝 Checklist
sendDefaultPIIis enabled#skip-changelog