Add support for propagateTraceparent
#5227
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 534ba8c | 484.00 ms | 499.93 ms | 15.93 ms |
| c7f264b | 434.98 ms | 452.96 ms | 17.98 ms |
| eb07ba3 | 470.04 ms | 473.35 ms | 3.31 ms |
| 7be1f99 | 454.83 ms | 461.36 ms | 6.53 ms |
| 95aaf8a | 437.89 ms | 419.45 ms | -18.44 ms |
| d751a5d+dirty | 434.24 ms | 486.08 ms | 51.84 ms |
| 77061ed+dirty | 369.55 ms | 408.35 ms | 38.80 ms |
| 23080e5 | 384.85 ms | 382.57 ms | -2.28 ms |
| b3b5b0d | 399.82 ms | 419.20 ms | 19.38 ms |
| af9331b | 449.77 ms | 479.20 ms | 29.43 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 534ba8c | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| c7f264b | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| eb07ba3 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 7be1f99 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 95aaf8a | 17.75 MiB | 19.68 MiB | 1.93 MiB |
| d751a5d+dirty | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 77061ed+dirty | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 23080e5 | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| b3b5b0d | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| af9331b | 17.75 MiB | 19.68 MiB | 1.94 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0b64753+dirty | 358.55 ms | 429.16 ms | 70.61 ms |
| 3e0a5f9+dirty | 379.92 ms | 450.96 ms | 71.04 ms |
| af9331b+dirty | 374.42 ms | 425.68 ms | 51.26 ms |
| 3099014+dirty | 344.58 ms | 404.21 ms | 59.63 ms |
| d916aa3+dirty | 411.72 ms | 451.76 ms | 40.03 ms |
| 77061ed+dirty | 359.40 ms | 424.10 ms | 64.70 ms |
| c4e097a+dirty | 382.43 ms | 443.77 ms | 61.34 ms |
| 1853710+dirty | 360.67 ms | 396.28 ms | 35.61 ms |
| 459a438+dirty | 359.50 ms | 390.53 ms | 31.03 ms |
| 2b89ce9+dirty | 372.22 ms | 417.06 ms | 44.84 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0b64753+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 3e0a5f9+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| af9331b+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 3099014+dirty | 7.15 MiB | 8.43 MiB | 1.27 MiB |
| d916aa3+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 77061ed+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| c4e097a+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 1853710+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 459a438+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 2b89ce9+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 459a438+dirty | 1218.39 ms | 1226.14 ms | 7.75 ms |
| 170d5ea+dirty | 1233.96 ms | 1242.54 ms | 8.58 ms |
| a31630c+dirty | 1241.32 ms | 1226.98 ms | -14.34 ms |
| 8ece263+dirty | 1206.90 ms | 1211.45 ms | 4.55 ms |
| 49ef936+dirty | 1221.27 ms | 1221.60 ms | 0.34 ms |
| 23080e5+dirty | 1221.39 ms | 1222.08 ms | 0.70 ms |
| eb07ba3+dirty | 1214.49 ms | 1221.59 ms | 7.10 ms |
| 20d5eaa+dirty | 1224.67 ms | 1223.16 ms | -1.51 ms |
| 46da307+dirty | 1213.45 ms | 1207.96 ms | -5.49 ms |
| c7f264b+dirty | 1229.78 ms | 1225.84 ms | -3.94 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 459a438+dirty | 3.19 MiB | 4.55 MiB | 1.36 MiB |
| 170d5ea+dirty | 3.19 MiB | 4.55 MiB | 1.36 MiB |
| a31630c+dirty | 3.19 MiB | 4.54 MiB | 1.36 MiB |
| 8ece263+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| 49ef936+dirty | 3.19 MiB | 4.54 MiB | 1.36 MiB |
| 23080e5+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| eb07ba3+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 20d5eaa+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 46da307+dirty | 3.19 MiB | 4.44 MiB | 1.25 MiB |
| c7f264b+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
alwx
force-pushed
the
alwx/improvement/traceparent-support
branch
from
17e753a to
befae1e
Compare
alwx
changed the title
propagateTraceparentpropagateTraceparent
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 459a438+dirty | 1222.12 ms | 1214.60 ms | -7.53 ms |
| 170d5ea+dirty | 1219.27 ms | 1231.90 ms | 12.63 ms |
| a31630c+dirty | 1229.09 ms | 1230.94 ms | 1.85 ms |
| 8ece263+dirty | 1217.29 ms | 1213.35 ms | -3.94 ms |
| 49ef936+dirty | 1228.42 ms | 1217.09 ms | -11.33 ms |
| 23080e5+dirty | 1216.02 ms | 1224.94 ms | 8.91 ms |
| eb07ba3+dirty | 1222.46 ms | 1220.37 ms | -2.08 ms |
| 20d5eaa+dirty | 1231.12 ms | 1226.00 ms | -5.12 ms |
| 46da307+dirty | 1217.08 ms | 1224.16 ms | 7.08 ms |
| c7f264b+dirty | 1211.82 ms | 1218.04 ms | 6.22 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 459a438+dirty | 2.63 MiB | 3.98 MiB | 1.35 MiB |
| 170d5ea+dirty | 2.63 MiB | 3.98 MiB | 1.35 MiB |
| a31630c+dirty | 2.63 MiB | 3.98 MiB | 1.34 MiB |
| 8ece263+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| 49ef936+dirty | 2.63 MiB | 3.98 MiB | 1.34 MiB |
| 23080e5+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| eb07ba3+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 20d5eaa+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 46da307+dirty | 2.63 MiB | 3.87 MiB | 1.24 MiB |
| c7f264b+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
alwx
changed the title
propagateTraceparentpropagateTraceparent
alwx
changed the title
propagateTraceparentpropagateTraceparent
|
Could you check the test files? there is a test where you expect propagateTraceparent to be true but the result was false. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
Fixes #5115
📜 Description
Updates the init method to accept
propagateTraceparentheader and passes it to the JavaScript SDK client.The code also includes tests — those only check if
propagateTraceparentis actually being passed to the JS SDK client. There is no need to write extra tests becausepropagateTraceparentis already covered by tests in the JS SDK (here: https://github.com/getsentry/sentry-javascript/blob/develop/packages/core/test/lib/utils/traceData.test.ts)📝 Checklist
sendDefaultPIIis enabled🔮 Next steps