ref: Test deprecated cleanup #5358
Merged
+141
−132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d916aa3 | 425.37 ms | 427.02 ms | 1.65 ms |
| 05bef0e+dirty | 349.78 ms | 334.04 ms | -15.74 ms |
| bc9680d | 375.15 ms | 401.12 ms | 25.97 ms |
| 69602ce | 417.47 ms | 443.52 ms | 26.05 ms |
| 136effd+dirty | 398.57 ms | 494.91 ms | 96.34 ms |
| d751a5d+dirty | 434.24 ms | 486.08 ms | 51.84 ms |
| 8d20c8e+dirty | 480.27 ms | 503.35 ms | 23.08 ms |
| 8db9631+dirty | 442.78 ms | 461.96 ms | 19.18 ms |
| 46bd012 | 387.09 ms | 404.47 ms | 17.38 ms |
| 1226664+dirty | 347.45 ms | 386.60 ms | 39.15 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d916aa3 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 05bef0e+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| bc9680d | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 69602ce | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 136effd+dirty | 43.75 MiB | 47.99 MiB | 4.23 MiB |
| d751a5d+dirty | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 8d20c8e+dirty | 43.75 MiB | 47.99 MiB | 4.23 MiB |
| 8db9631+dirty | 17.75 MiB | 19.70 MiB | 1.96 MiB |
| 46bd012 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 1226664+dirty | 17.75 MiB | 19.74 MiB | 1.99 MiB |
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c9e95bd+dirty | 1240.19 ms | 1246.33 ms | 6.14 ms |
| c1573b3+dirty | 1203.33 ms | 1202.47 ms | -0.86 ms |
| fa7bb7e+dirty | 1216.23 ms | 1225.04 ms | 8.81 ms |
| f081f58+dirty | 1219.10 ms | 1217.57 ms | -1.53 ms |
| 128ee72+dirty | 1218.16 ms | 1219.18 ms | 1.03 ms |
| 2b89ce9+dirty | 1229.30 ms | 1239.40 ms | 10.10 ms |
| 818a608+dirty | 1205.76 ms | 1208.00 ms | 2.24 ms |
| 8e653ac+dirty | 1218.63 ms | 1223.88 ms | 5.24 ms |
| f70acbf+dirty | 1235.71 ms | 1243.14 ms | 7.43 ms |
| 07808fb+dirty | 1233.31 ms | 1232.77 ms | -0.54 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c9e95bd+dirty | 2.63 MiB | 3.87 MiB | 1.24 MiB |
| c1573b3+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| fa7bb7e+dirty | 2.63 MiB | 4.01 MiB | 1.38 MiB |
| f081f58+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 128ee72+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 2b89ce9+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| 818a608+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| 8e653ac+dirty | 2.63 MiB | 4.01 MiB | 1.38 MiB |
| f70acbf+dirty | 2.63 MiB | 3.98 MiB | 1.34 MiB |
| 07808fb+dirty | 2.63 MiB | 3.99 MiB | 1.36 MiB |
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c9e95bd+dirty | 1205.83 ms | 1207.38 ms | 1.55 ms |
| c1573b3+dirty | 1245.69 ms | 1245.48 ms | -0.21 ms |
| fa7bb7e+dirty | 1226.27 ms | 1241.88 ms | 15.61 ms |
| f081f58+dirty | 1208.37 ms | 1215.56 ms | 7.19 ms |
| 128ee72+dirty | 1204.73 ms | 1205.02 ms | 0.29 ms |
| 2b89ce9+dirty | 1241.19 ms | 1254.20 ms | 13.01 ms |
| 818a608+dirty | 1218.84 ms | 1223.18 ms | 4.34 ms |
| 8e653ac+dirty | 1215.46 ms | 1220.20 ms | 4.75 ms |
| f70acbf+dirty | 1239.00 ms | 1242.53 ms | 3.53 ms |
| 07808fb+dirty | 1240.76 ms | 1251.00 ms | 10.24 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c9e95bd+dirty | 3.19 MiB | 4.44 MiB | 1.25 MiB |
| c1573b3+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| fa7bb7e+dirty | 3.19 MiB | 4.58 MiB | 1.39 MiB |
| f081f58+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 128ee72+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 2b89ce9+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| 818a608+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| 8e653ac+dirty | 3.19 MiB | 4.58 MiB | 1.39 MiB |
| f70acbf+dirty | 3.19 MiB | 4.54 MiB | 1.36 MiB |
| 07808fb+dirty | 3.19 MiB | 4.56 MiB | 1.37 MiB |
Contributor
|
@lucas-zimerman I noticed the two failing tests on another PR too and I believe they might be related to a recent
I'm planning to revisit this tomorrow |
Collaborator
Author
|
yeah they are unrelated since the PR only changed the JavaScript tests. |
antonis
approved these changes
Nov 12, 2025
Contributor
antonis
left a comment
antonis
left a comment
There was a problem hiding this comment.
LGTM 🎸
Thank you for handling this Lucas 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Cleanup of deprecated tests.
Also adde todo notes for the experimental flags for replay that will be removed on a major version.
💡 Motivation and Context
💚 How did you test it?
CI test.
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog