Skip to content

Conversation

@lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Nov 11, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Lets ignore the local sample .env file so we can change it locally and testing different sets of env setup for the samples.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog.

@lucas-zimerman lucas-zimerman changed the title ignore env Ref: ignore env from sample apps Nov 11, 2025
@lucas-zimerman lucas-zimerman added the ready-to-merge Triggers the full CI test suite label Nov 11, 2025
@github-actions
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 568.30 ms 603.85 ms 35.55 ms
Size 43.75 MiB 47.99 MiB 4.24 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d916aa3 425.37 ms 427.02 ms 1.65 ms
05bef0e+dirty 349.78 ms 334.04 ms -15.74 ms
bc9680d 375.15 ms 401.12 ms 25.97 ms
69602ce 417.47 ms 443.52 ms 26.05 ms
136effd+dirty 398.57 ms 494.91 ms 96.34 ms
d751a5d+dirty 434.24 ms 486.08 ms 51.84 ms
8d20c8e+dirty 480.27 ms 503.35 ms 23.08 ms
8db9631+dirty 442.78 ms 461.96 ms 19.18 ms
46bd012 387.09 ms 404.47 ms 17.38 ms
1226664+dirty 347.45 ms 386.60 ms 39.15 ms

App size

Revision Plain With Sentry Diff
d916aa3 17.75 MiB 20.15 MiB 2.41 MiB
05bef0e+dirty 17.75 MiB 19.70 MiB 1.95 MiB
bc9680d 17.75 MiB 20.15 MiB 2.41 MiB
69602ce 17.75 MiB 19.68 MiB 1.94 MiB
136effd+dirty 43.75 MiB 47.99 MiB 4.23 MiB
d751a5d+dirty 17.75 MiB 19.68 MiB 1.94 MiB
8d20c8e+dirty 43.75 MiB 47.99 MiB 4.23 MiB
8db9631+dirty 17.75 MiB 19.70 MiB 1.96 MiB
46bd012 17.75 MiB 20.15 MiB 2.41 MiB
1226664+dirty 17.75 MiB 19.74 MiB 1.99 MiB

@github-actions
Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 382.21 ms 398.31 ms 16.10 ms
Size 43.94 MiB 48.82 MiB 4.88 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
21c9e75+dirty 356.73 ms 381.06 ms 24.33 ms
46bd012+dirty 333.76 ms 359.24 ms 25.48 ms
e76d0d3+dirty 358.22 ms 378.65 ms 20.43 ms
136effd+dirty 451.30 ms 450.87 ms -0.43 ms
8d20c8e+dirty 469.90 ms 502.00 ms 32.10 ms
9f211e3+dirty 371.00 ms 432.51 ms 61.51 ms
818a608+dirty 350.29 ms 397.38 ms 47.09 ms
5ee3314+dirty 358.69 ms 394.00 ms 35.31 ms
59f3a84+dirty 359.69 ms 407.54 ms 47.86 ms
95aaf8a+dirty 342.82 ms 393.75 ms 50.93 ms

App size

Revision Plain With Sentry Diff
21c9e75+dirty 7.15 MiB 8.42 MiB 1.27 MiB
46bd012+dirty 7.15 MiB 8.42 MiB 1.27 MiB
e76d0d3+dirty 7.15 MiB 8.44 MiB 1.28 MiB
136effd+dirty 43.94 MiB 48.81 MiB 4.88 MiB
8d20c8e+dirty 43.94 MiB 48.81 MiB 4.88 MiB
9f211e3+dirty 7.15 MiB 8.41 MiB 1.26 MiB
818a608+dirty 7.15 MiB 8.41 MiB 1.26 MiB
5ee3314+dirty 7.15 MiB 8.43 MiB 1.28 MiB
59f3a84+dirty 7.15 MiB 8.43 MiB 1.28 MiB
95aaf8a+dirty 7.15 MiB 8.41 MiB 1.26 MiB

@github-actions
Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1213.91 ms 1217.40 ms 3.48 ms
Size 3.41 MiB 4.58 MiB 1.17 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c9e95bd+dirty 1205.83 ms 1207.38 ms 1.55 ms
c1573b3+dirty 1245.69 ms 1245.48 ms -0.21 ms
fa7bb7e+dirty 1226.27 ms 1241.88 ms 15.61 ms
f081f58+dirty 1208.37 ms 1215.56 ms 7.19 ms
128ee72+dirty 1204.73 ms 1205.02 ms 0.29 ms
2b89ce9+dirty 1241.19 ms 1254.20 ms 13.01 ms
818a608+dirty 1218.84 ms 1223.18 ms 4.34 ms
8e653ac+dirty 1215.46 ms 1220.20 ms 4.75 ms
f70acbf+dirty 1239.00 ms 1242.53 ms 3.53 ms
07808fb+dirty 1240.76 ms 1251.00 ms 10.24 ms

App size

Revision Plain With Sentry Diff
c9e95bd+dirty 3.19 MiB 4.44 MiB 1.25 MiB
c1573b3+dirty 3.19 MiB 4.38 MiB 1.19 MiB
fa7bb7e+dirty 3.19 MiB 4.58 MiB 1.39 MiB
f081f58+dirty 3.41 MiB 4.58 MiB 1.17 MiB
128ee72+dirty 3.41 MiB 4.58 MiB 1.17 MiB
2b89ce9+dirty 3.19 MiB 4.48 MiB 1.29 MiB
818a608+dirty 3.19 MiB 4.48 MiB 1.29 MiB
8e653ac+dirty 3.19 MiB 4.58 MiB 1.39 MiB
f70acbf+dirty 3.19 MiB 4.54 MiB 1.36 MiB
07808fb+dirty 3.19 MiB 4.56 MiB 1.37 MiB

@github-actions
Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1208.18 ms 1206.29 ms -1.90 ms
Size 3.41 MiB 4.58 MiB 1.17 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c9e95bd+dirty 1240.19 ms 1246.33 ms 6.14 ms
c1573b3+dirty 1203.33 ms 1202.47 ms -0.86 ms
fa7bb7e+dirty 1216.23 ms 1225.04 ms 8.81 ms
f081f58+dirty 1219.10 ms 1217.57 ms -1.53 ms
128ee72+dirty 1218.16 ms 1219.18 ms 1.03 ms
2b89ce9+dirty 1229.30 ms 1239.40 ms 10.10 ms
818a608+dirty 1205.76 ms 1208.00 ms 2.24 ms
8e653ac+dirty 1218.63 ms 1223.88 ms 5.24 ms
f70acbf+dirty 1235.71 ms 1243.14 ms 7.43 ms
07808fb+dirty 1233.31 ms 1232.77 ms -0.54 ms

App size

Revision Plain With Sentry Diff
c9e95bd+dirty 2.63 MiB 3.87 MiB 1.24 MiB
c1573b3+dirty 2.63 MiB 3.81 MiB 1.18 MiB
fa7bb7e+dirty 2.63 MiB 4.01 MiB 1.38 MiB
f081f58+dirty 3.41 MiB 4.58 MiB 1.17 MiB
128ee72+dirty 3.41 MiB 4.58 MiB 1.17 MiB
2b89ce9+dirty 2.63 MiB 3.91 MiB 1.28 MiB
818a608+dirty 2.63 MiB 3.91 MiB 1.28 MiB
8e653ac+dirty 2.63 MiB 4.01 MiB 1.38 MiB
f70acbf+dirty 2.63 MiB 3.98 MiB 1.34 MiB
07808fb+dirty 2.63 MiB 3.99 MiB 1.36 MiB

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good idea 👍

@antonis antonis merged commit c64a7af into main Nov 12, 2025
90 of 97 checks passed
@antonis antonis deleted the lz/ignore-env branch November 12, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Triggers the full CI test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants