-
Notifications
You must be signed in to change notification settings - Fork 21
Open
Description
@philipphofmann was trying to release sentry-cocoa 5.1.10 after 5.1.10-beta.0 had been released.
craft fails because a file 5.1.10.json already exists.
While there is a fix to be made in craft, a question that is relevant for the registry is whether pre-release versions should generate symlinks in the same way as regular releases.
sentry-release-registry/bin/sync-links
Lines 21 to 32 in 8d4baf5
| version_info = VersionInfo.parse(base.rsplit('.', 1)[0]) | |
| with open(path) as f: | |
| if version_info != VersionInfo.parse(json.load(f)['version']): | |
| error('Filename does not match version (%s)' % path) | |
| target_files = [ | |
| '%s.json' % version_info.major, | |
| '%s.%s.json' % (version_info.major, version_info.minor), | |
| '%s.%s.%s.json' % (version_info.major, version_info.minor, version_info.patch), | |
| 'latest.json', | |
| ] |
For the purposes for what the registry is used, when 5.1.10-beta.0 is released, is it correct to make 5.json, 5.1.json, 5.1.10.json and latest.json all point to the pre-release version file 5.1.10-beta.0.json?
Metadata
Metadata
Assignees
Labels
No labels
