Skip to content

Commit 14ef446

Browse files
authored
Fix issues with specs (#2511)
* Fix a crash from ActiveSupport * Add ostruct for ruby-head
1 parent a1d2941 commit 14ef446

File tree

7 files changed

+22
-0
lines changed

7 files changed

+22
-0
lines changed

sentry-delayed_job/spec/spec_helper.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
require "debug/prelude"
66
rescue LoadError
77
end
8+
9+
require "logger"
10+
811
require "active_record"
912
require "delayed_job"
1013
require "delayed_job_active_record"

sentry-opentelemetry/Gemfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ git_source(:github) { |name| "https://github.com/#{name}.git" }
66
# Specify your gem's dependencies in sentry-ruby.gemspec
77
gemspec
88

9+
gem "ostruct" if RUBY_VERSION >= "3.4"
10+
911
gem "opentelemetry-sdk"
1012
gem "opentelemetry-instrumentation-rails"
1113

sentry-rails/spec/isolated/active_job_activation.rb

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# frozen_string_literal: true
22

3+
# Fixing crash:
4+
# activesupport-6.1.7.10/lib/active_support/logger_thread_safe_level.rb:16:in
5+
# . `<module:LoggerThreadSafeLevel>': uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger (NameError)
6+
require "logger"
7+
38
# for https://github.com/getsentry/sentry-ruby/issues/1249
49
require "active_job/railtie"
510
# Rails 7.2 added HealthCheckController, which requires ActionController

sentry-resque/Gemfile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ git_source(:github) { |name| "https://github.com/#{name}.git" }
55

66
# Specify your gem's dependencies in sentry-ruby.gemspec
77
gemspec
8+
9+
gem "ostruct" if RUBY_VERSION >= "3.4"
10+
811
gem "sentry-ruby", path: "../sentry-ruby"
912

1013
gem "resque-retry", "~> 1.8"

sentry-ruby/Gemfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ rack_version = ENV["RACK_VERSION"]
99
rack_version = "3.0.0" if rack_version.nil?
1010
gem "rack", "~> #{Gem::Version.new(rack_version)}" unless rack_version == "0"
1111

12+
gem "ostruct" if RUBY_VERSION >= "3.4"
13+
1214
redis_rb_version = ENV.fetch("REDIS_RB_VERSION", "5.0")
1315
gem "redis", "~> #{redis_rb_version}"
1416

sentry-sidekiq/spec/sentry/rails_spec.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
return unless ENV["WITH_SENTRY_RAILS"]
44

5+
require "logger"
6+
57
require "rails"
68
require "sentry-rails"
79
require "spec_helper"

sentry-sidekiq/spec/spec_helper.rb

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,11 @@
2222

2323
require "sentry-ruby"
2424

25+
# Fixing crash:
26+
# activesupport-6.1.7.10/lib/active_support/logger_thread_safe_level.rb:16:in
27+
# . `<module:LoggerThreadSafeLevel>': uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger (NameError)
28+
require "logger"
29+
2530
require 'simplecov'
2631

2732
SimpleCov.start do

0 commit comments

Comments
 (0)