Skip to content

Commit 234187f

Browse files
committed
WIP
1 parent 4b0eaab commit 234187f

File tree

13 files changed

+57
-59
lines changed

13 files changed

+57
-59
lines changed

.devcontainer/Dockerfile

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,7 @@ ENV LANG=C.UTF-8 \
4747
PATH=$PATH:${GEM_HOME}/bin \
4848
REDIS_HOST=redis
4949

50-
USER sentry
51-
52-
FROM base AS dev
50+
FROM build AS dev
5351

5452
RUN apt-get update && apt-get install -y --no-install-recommends \
5553
chromium \
@@ -59,7 +57,7 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
5957

6058
USER sentry
6159

62-
FROM base AS rails-mini
60+
FROM build AS rails-mini
6361

6462
USER sentry
6563

.devcontainer/devcontainer.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "sentry-ruby",
33
"dockerComposeFile": "docker-compose.yml",
4-
"service": "sentry",
4+
"service": "sentry-dev",
55
"workspaceFolder": "/workspace/sentry",
66
"features": {
77
"ghcr.io/devcontainers/features/github-cli": {},
@@ -25,6 +25,5 @@
2525
"rubyLsp.formatter": "auto"
2626
}
2727
},
28-
"remoteUser": "sentry",
29-
"postCreateCommand": ".devcontainer/setup --with-foreman"
28+
"remoteUser": "sentry"
3029
}

.devcontainer/docker-compose.yml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,16 @@ services:
55
dockerfile: Dockerfile
66
target: dev
77
args:
8-
IMAGE: ${IMAGE}
9-
VERSION: ${VERSION}
8+
IMAGE: ${IMAGE:-ruby}
9+
VERSION: ${VERSION:-3.4.5}
1010
volumes:
1111
- ..:/workspace/sentry:cached
1212
- sentry_e2e_logs:/workspace/sentry/log
1313
- sentry_ruby_gems:/workspace/gems
1414
command: sleep infinity
15-
environment:
16-
- REDIS_URL=${REDIS_URL:-redis://redis:6379/0}
15+
post_start:
16+
- command: .devcontainer/setup --with-foreman
17+
entrypoint: .devcontainer/entrypoint-sentry-dev.sh
1718
env_file: [".env"]
1819
depends_on:
1920
- redis
@@ -39,6 +40,8 @@ services:
3940
- redis
4041
- sentry-rails-mini
4142
- sentry-svelte-mini
43+
profiles:
44+
- e2e
4245

4346
sentry-rails-mini:
4447
build:

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@ Gemfile.lock
1414
*.rdb
1515
.rgignore
1616

17-
/node_modules/
17+
node_modules

Gemfile

Lines changed: 1 addition & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,45 +1,12 @@
11
# frozen_string_literal: true
22

3-
source "https://rubygems.org"
4-
git_source(:github) { |name| "https://github.com/#{name}.git" }
5-
6-
gem "jar-dependencies" if RUBY_PLATFORM == "java"
7-
gem "rake", "~> 12.0"
8-
9-
ruby_version = Gem::Version.new(RUBY_VERSION)
10-
11-
# Development tools
12-
if ruby_version >= Gem::Version.new("2.7.0")
13-
gem "debug", github: "ruby/debug", platform: :ruby
14-
gem "irb"
15-
gem "ruby-lsp-rspec" if ruby_version >= Gem::Version.new("3.0.0") && RUBY_PLATFORM != "java"
16-
end
17-
18-
if RUBY_VERSION >= "3.5"
19-
gem "cgi"
20-
end
21-
22-
# For RSpec
23-
gem "rspec", "~> 3.0"
24-
gem "rspec-retry"
25-
gem "simplecov"
26-
gem "simplecov-cobertura", "~> 1.4"
27-
gem "rexml"
28-
29-
if ruby_version >= Gem::Version.new("3.4")
30-
gem "ostruct"
31-
end
3+
eval_gemfile "Gemfile.dev"
324

335
group :e2e do
346
gem "capybara"
357
gem "selenium-webdriver"
368
end
379

38-
group :rubocop do
39-
gem "rubocop-rails-omakase"
40-
gem "rubocop-packaging"
41-
end
42-
4310
group :sentry do
4411
gem "sentry-ruby", path: "sentry-ruby"
4512
gem "sentry-rails", path: "sentry-rails"

Gemfile.dev

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
# frozen_string_literal: true
2+
3+
source "https://rubygems.org"
4+
5+
git_source(:github) { |name| "https://github.com/#{name}.git" }
6+
7+
gem "jar-dependencies" if RUBY_PLATFORM == "java"
8+
gem "rake", "~> 12.0"
9+
10+
ruby_version = Gem::Version.new(RUBY_VERSION)
11+
12+
# Development tools
13+
if ruby_version >= Gem::Version.new("2.7.0")
14+
gem "debug", github: "ruby/debug", platform: :ruby
15+
gem "irb"
16+
gem "ruby-lsp-rspec" if ruby_version >= Gem::Version.new("3.0.0") && RUBY_PLATFORM != "java"
17+
end
18+
19+
if RUBY_VERSION >= "3.5"
20+
gem "cgi"
21+
end
22+
23+
# For RSpec
24+
gem "rspec", "~> 3.0"
25+
gem "rspec-retry"
26+
gem "simplecov"
27+
gem "simplecov-cobertura", "~> 1.4"
28+
gem "rexml"
29+
30+
if ruby_version >= Gem::Version.new("3.4")
31+
gem "ostruct"
32+
end
33+
34+
group :rubocop do
35+
gem "rubocop-rails-omakase"
36+
gem "rubocop-packaging"
37+
end

Procfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
rails: cd spec/apps/rails-mini && bundle exec app.rb
1+
rails: cd spec/apps/rails-mini && bundle exec ruby app.rb
22
svelte: cd spec/apps/svelte-mini && npm run dev

sentry-delayed_job/Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
source "https://rubygems.org"
44
git_source(:github) { |name| "https://github.com/#{name}.git" }
55

6-
eval_gemfile "../Gemfile"
6+
eval_gemfile "../Gemfile.dev"
77

88
# Specify your gem's dependencies in sentry-ruby.gemspec
99
gemspec

sentry-opentelemetry/Gemfile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,11 @@
33
source "https://rubygems.org"
44
git_source(:github) { |name| "https://github.com/#{name}.git" }
55

6-
eval_gemfile "../Gemfile"
6+
eval_gemfile "../Gemfile.dev"
77

88
# Specify your gem's dependencies in sentry-ruby.gemspec
99
gemspec
1010

11-
gem "ostruct" if RUBY_VERSION >= "3.4"
12-
1311
gem "opentelemetry-sdk"
1412
gem "opentelemetry-instrumentation-rails"
1513

sentry-rails/Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
source "https://rubygems.org"
44
git_source(:github) { |name| "https://github.com/#{name}.git" }
55

6-
eval_gemfile "../Gemfile"
6+
eval_gemfile "../Gemfile.dev"
77

88
# Specify your gem's dependencies in sentry-ruby.gemspec
99
gemspec

0 commit comments

Comments
 (0)