Add new configuration callbacks (#2724)

* Yield config from its constructor

* feat(configuration): add before/after callbacks

* Update CHANGELOG

Author: solnic

CHANGELOG.md

@@ -3,6 +3,7 @@
 ### Internal
 
 - Fix leftover `config.logger` call in `graphql` patch ([#2722](https://github.com/getsentry/sentry-ruby/2722)
+- Add `Configuration.before` and `Configuration.after` to run hooks before and after given event ([#2724](https://github.com/getsentry/sentry-ruby/pull/2724))
 
 ## 5.27.1
 

sentry-ruby/lib/sentry-ruby.rb

@@ -239,8 +239,7 @@ def add_attachment(**opts)
     # @yieldparam config [Configuration]
     # @return [void]
     def init(&block)
-      config = Configuration.new
-      yield(config) if block_given?
+      config = Configuration.new(&block)
 
       config.detect_release
       apply_patches(config)

sentry-ruby/lib/sentry/configuration.rb

@@ -400,7 +400,23 @@ def post_initialization_callbacks
 
       # allow extensions to add their hooks to the Configuration class
       def add_post_initialization_callback(&block)
-        post_initialization_callbacks << block
+        callbacks[:initialize][:after] << block
+      end
+
+      def before(event, &block)
+        callbacks[event.to_sym][:before] << block
+      end
+
+      def after(event, &block)
+        callbacks[event.to_sym][:after] << block
+      end
+
+      # @!visibility private
+      def callbacks
+        @callbacks ||= {
+          initialize: { before: [], after: [] },
+          configured: { before: [], after: [] }
+        }
       end
 
       def validations
@@ -444,6 +460,8 @@ def build_validation_proc(optional, type)
     validate :profiles_sample_rate, optional: true, type: :numeric
 
     def initialize
+      run_callbacks(:before, :initialize)
+
       self.app_dirs_pattern = APP_DIRS_PATTERN
       self.debug = Sentry::Utils::EnvHelper.env_to_bool(ENV["SENTRY_DEBUG"])
       self.background_worker_threads = (processor_count / 2.0).ceil
@@ -498,9 +516,13 @@ def initialize
       @structured_logging = StructuredLoggingConfiguration.new
       @gem_specs = Hash[Gem::Specification.map { |spec| [spec.name, spec.version.to_s] }] if Gem::Specification.respond_to?(:map)
 
-      run_post_initialization_callbacks
-
       self.max_log_events = LogEventBuffer::DEFAULT_MAX_EVENTS
+
+      run_callbacks(:after, :initialize)
+
+      yield(self) if block_given?
+
+      run_callbacks(:after, :configured)
     end
 
     def validate
@@ -784,8 +806,8 @@ def running_on_heroku?
       File.directory?("/etc/heroku") && !ENV["CI"]
     end
 
-    def run_post_initialization_callbacks
-      self.class.post_initialization_callbacks.each do |hook|
+    def run_callbacks(hook, event)
+      self.class.callbacks[event][hook].each do |hook|
         instance_eval(&hook)
       end
     end

sentry-ruby/spec/sentry/configuration_spec.rb

@@ -605,6 +605,39 @@ class SentryConfigurationSample < Sentry::Configuration
     end
   end
 
+  describe '.before' do
+    it 'calls a hook before given event' do
+      config = Class.new(Sentry::Configuration) do
+        attr_reader :info
+
+        before(:initialize) do
+          @info = "debug is #{debug.inspect}"
+        end
+      end.new do |config|
+        config.debug = true
+      end
+
+      expect(config.info).to eq("debug is nil")
+      expect(config.debug).to be(true)
+    end
+  end
+
+  describe '.after' do
+    it 'calls a hook after given event' do
+      config = Class.new(Sentry::Configuration) do
+        attr_reader :info
+
+        after(:configured) do
+          @info = "debug was set to #{debug}"
+        end
+      end.new do |config|
+        config.debug = true
+      end
+
+      expect(config.info).to eq("debug was set to true")
+    end
+  end
+
   describe "#skip_rake_integration" do
     it "returns false by default" do
       expect(subject.skip_rake_integration).to eq(false)