[sentry-rails] add support for isolated specs

Author: solnic

lib/sentry/test/rake_tasks.rb

@@ -0,0 +1,59 @@
+# frozen_string_literal: true
+
+require "rake/clean"
+require "rspec/core/rake_task"
+
+module Sentry
+  module Test
+    module RakeTasks
+      extend Rake::DSL
+
+      def self.define_spec_tasks(options = {})
+        opts = {
+          isolated_specs_pattern: "spec/isolated/**/*_spec.rb",
+          spec_pattern: nil,
+          spec_exclude_pattern: nil,
+          spec_rspec_opts: nil,
+          isolated_rspec_opts: nil
+        }.merge(options)
+
+        RSpec::Core::RakeTask.new(:spec).tap do |task|
+          task.pattern = opts[:spec_pattern] if opts[:spec_pattern]
+          task.exclude_pattern = opts[:spec_exclude_pattern] if opts[:spec_exclude_pattern]
+          task.rspec_opts = opts[:spec_rspec_opts] if opts[:spec_rspec_opts]
+        end
+
+        namespace :spec do
+          RSpec::Core::RakeTask.new(:isolated).tap do |task|
+            task.pattern = opts[:isolated_specs_pattern]
+            task.rspec_opts = opts[:isolated_rspec_opts] if opts[:isolated_rspec_opts]
+          end
+        end
+      end
+
+      # Define versioned specs task (sentry-rails specific)
+      def self.define_versioned_specs_task(options = {})
+        opts = {
+          rspec_opts: "--order rand"
+        }.merge(options)
+
+        namespace :spec do
+          RSpec::Core::RakeTask.new(:versioned).tap do |task|
+            ruby_ver_dir = RUBY_VERSION.split(".")[0..1].join(".")
+            matching_dir = Dir["spec/versioned/*"].detect { |dir| File.basename(dir) <= ruby_ver_dir }
+
+            unless matching_dir
+              puts "No versioned specs found for ruby #{RUBY_VERSION}"
+              exit 0
+            end
+
+            puts "Running versioned specs from #{matching_dir} for ruby #{RUBY_VERSION}"
+
+            task.rspec_opts = opts[:rspec_opts]
+            task.pattern = "#{matching_dir}/**/*_spec.rb"
+          end
+        end
+      end
+    end
+  end
+end

sentry-rails/Rakefile

@@ -1,34 +1,17 @@
 # frozen_string_literal: true
 
 require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+require_relative "../lib/sentry/test/rake_tasks"
 
-RSpec::Core::RakeTask.new(:spec).tap do |task|
-  task.rspec_opts = "--order rand"
-  task.pattern = "spec/sentry/**/*_spec.rb"
-end
+Sentry::Test::RakeTasks.define_spec_tasks(
+  spec_pattern: "spec/sentry/**/*_spec.rb",
+  spec_rspec_opts: "--order rand --format progress",
+  isolated_specs_pattern: "spec/isolated/**/*_spec.rb",
+  isolated_rspec_opts: "--format progress"
+)
 
-namespace :spec do
-  RSpec::Core::RakeTask.new(:versioned).tap do |task|
-    ruby_ver_dir = RUBY_VERSION.split(".")[0..1].join(".")
-    matching_dir = Dir["spec/versioned/*"].detect { |dir| File.basename(dir) <= ruby_ver_dir }
+Sentry::Test::RakeTasks.define_versioned_specs_task(
+  rspec_opts: "--order rand --format progress"
+)
 
-    unless matching_dir
-      puts "No versioned specs found for ruby #{RUBY_VERSION}"
-      exit 0
-    end
-
-    puts "Running versioned specs from #{matching_dir} for ruby #{RUBY_VERSION}"
-
-    task.rspec_opts = "--order rand"
-    task.pattern = "#{matching_dir}/**/*_spec.rb"
-  end
-end
-
-task :isolated_specs do
-  Dir["spec/isolated/*"].each do |file|
-    sh "bundle exec ruby #{file}"
-  end
-end
-
-task default: [:spec, :"spec:versioned", :isolated_specs]
+task default: [:spec, :"spec:versioned", :"spec:isolated"]

sentry-ruby/Rakefile

@@ -6,16 +6,13 @@ CLOBBER.include "pkg"
 require "bundler/gem_helper"
 Bundler::GemHelper.install_tasks(name: "sentry-ruby")
 
-require "rspec/core/rake_task"
+require_relative "../lib/sentry/test/rake_tasks"
 
 ISOLATED_SPECS = "spec/isolated/**/*_spec.rb"
 
-RSpec::Core::RakeTask.new(:spec).tap do |task|
-  task.exclude_pattern = ISOLATED_SPECS
-end
+Sentry::Test::RakeTasks.define_spec_tasks(
+  isolated_specs_pattern: ISOLATED_SPECS,
+  spec_exclude_pattern: ISOLATED_SPECS
+)
 
-RSpec::Core::RakeTask.new(:isolated_specs).tap do |task|
-  task.pattern = ISOLATED_SPECS
-end
-
-task default: [:spec, :isolated_specs]
+task default: [:spec, :"spec:isolated"]