Patch our own Breadcrumb::SentryLogger

Otherwise this resulted in stack error

Author: solnic

sentry-ruby/lib/sentry/std_lib_logger.rb

@@ -13,9 +13,9 @@ module StdLibLogger
     }.freeze
 
     def add(severity, message = nil, progname = nil, &block)
-      super
+      result = super
 
-      return unless Sentry.initialized? && Sentry.get_current_hub
+      return result unless Sentry.initialized? && Sentry.get_current_hub
 
       # exclude sentry SDK logs -- to prevent recursive log action,
       # do not process internal logs again
@@ -36,14 +36,16 @@ def add(severity, message = nil, progname = nil, &block)
         end
       end
 
-      super
+      result
     end
   end
 end
 
 Sentry.register_patch(:logger) do |config|
   if config.enable_logs
-    ::Logger.prepend(Sentry::StdLibLogger)
+    require "sentry/breadcrumb/sentry_logger"
+
+    Sentry::Breadcrumb::SentryLogger.prepend(Sentry::StdLibLogger)
   else
     Sentry.sdk_logger.warn(":logger patch enabled but `enable_logs` is turned off - skipping applying patch")
   end

sentry-ruby/spec/sentry/std_lib_logger_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 RSpec.describe Sentry::StdLibLogger do
-  let(:logger) { ::Logger.new(IO::NULL) }
+  let(:logger) { ::Logger.new($stdout) }
 
   context "when enable_logs is set to true but logger patch is not enabled" do
     before do
@@ -11,7 +11,9 @@
     end
 
     it "does not send log using stdlib logger" do
-      logger.send(:info, "Hello World")
+      expect {
+        logger.send(:info, "Hello World")
+      }.to output(/Hello World/).to_stdout
 
       expect(sentry_logs).to be_empty
     end
@@ -29,7 +31,9 @@
     ["info", "warn", "error", "fatal"].each do |level|
       describe "##{level}" do
         it "send logs using stdlib logger" do
-          logger.send(level, "Hello World")
+          expect {
+            logger.send(level, "Hello World")
+          }.to output(/Hello World/).to_stdout
 
           expect(sentry_logs).to_not be_empty