Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.18%. Comparing base (bf8d8c5) to head (536166e).
Report is 2 commits behind head on master.

@@           Coverage Diff           @@
##           master    #2503   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files         128      128           
  Lines        4837     4845    +8     
=======================================
+ Hits         4749     4757    +8     
  Misses         88       88           

@solnic sorry for the delay. Updated!

What's the intended interaction with report_after_job_retries? At the moment report_after_job_retries takes precedence and reports aren't sent until retries are exhausted regardless of attempt_threshold.

I think it would be useful if when report_after_job_retries: true then attempt_threshold could be used to selectively lower the threshold for some jobs (so attempt_threshold would take precedence).

What do you think? It's just a matter of flipping the order of the conditionals.

personally I have no objection to that... I think my use case would be supported either way!

Any reasons this is not documented anywhere?

Any reasons this is not documented anywhere?

@Linuus good point, we should definitely document this and related features as it's kinda tricky 😅 I'll make sure we get it done!

Any reasons this is not documented anywhere?

@Linuus good point, we should definitely document this and related features as it's kinda tricky 😅 I'll make sure we get it done!

Thanks :) I was mostly curious if it was some beta/internal thing. Just to make sure we don't depend on something we shouldn't.

@Linuus oh, sorry about the confusion. Let me clarify then - it is a first-class feature and you can rely on this 🙂

One issue with this solution is it means jobs that are out of the developer's control (e.g. Sidekiq::Batch::Callback) cannot be configured with sidekiq_options. Instead, you need to set via some Sidekiq middleware.