Unify Logs and Metrics implementations #2826
Merged
+208
−315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl0thentr0py
force-pushed
the
neel/unify-logs-metrics
branch
3 times, most recently
from
83d69f3 to
3a1fba7
Compare
sl0thentr0py
commented
Jan 8, 2026
| ] | ||
|
|
||
| SENTRY_ATTRIBUTES = { | ||
| "sentry.trace.parent_span_id" => :parent_span_id, |
Member
Author
There was a problem hiding this comment.
this is now just span_id top level field
sl0thentr0py
commented
Jan 8, 2026
sl0thentr0py
force-pushed
the
neel/unify-logs-metrics
branch
from
3a1fba7 to
1299839
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
* Make `LogEvent` go through `scope.apply_to_telemetry` * Populate default and user attributes in `scope.apply_to_telemetry` * Simplify LogEvent to be more simpler with serialization logic, remove all unnecessary fields
sl0thentr0py
force-pushed
the
neel/unify-logs-metrics
branch
from
1299839 to
0f6d57a
Compare
solnic
requested changes
Jan 12, 2026
| }.compact | ||
|
|
||
| telemetry.attributes = user_attributes.merge(telemetry.attributes) | ||
| end |
Collaborator
There was a problem hiding this comment.
@sl0thentr0py would be good to optimize this to avoid extra hash allocations, otherwise this will be a performance regression.
solnic
reviewed
Jan 12, 2026
sl0thentr0py
force-pushed
the
neel/unify-logs-metrics
branch
from
8c6a0a9 to
dcd81f7
Compare
solnic
reviewed
Jan 12, 2026
Collaborator
solnic
left a comment
solnic
left a comment
There was a problem hiding this comment.
@sl0thentr0py one more tweak 🙏🏻
sl0thentr0py
force-pushed
the
neel/unify-logs-metrics
branch
from
dcd81f7 to
580896e
Compare
Co-authored-by: Peter Solnica <[email protected]>
sl0thentr0py
force-pushed
the
neel/unify-logs-metrics
branch
from
a0f051a to
94da548
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LogEventgo throughscope.apply_to_telemetryinstead ofscope.apply_to_eventscope.apply_to_telemetryLogEventserialization logic, remove all unnecessary fieldsIssues