Skip to content

Commit 16bc423

Browse files
committed
fix bug and added test
1 parent 15e2f90 commit 16bc423

File tree

2 files changed

+17
-1
lines changed

2 files changed

+17
-1
lines changed

src/DependencyInjection/SentryExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ protected function loadInternal(array $mergedConfig, ContainerBuilder $container
7878
$this->registerCacheTracingConfiguration($container, $mergedConfig['tracing']);
7979
$this->registerHttpClientTracingConfiguration($container, $mergedConfig['tracing']);
8080

81-
if (!class_exists(TokenStorageInterface::class)) {
81+
if (!interface_exists(TokenStorageInterface::class)) {
8282
$container->removeDefinition(LoginListener::class);
8383
}
8484
}

tests/DependencyInjection/Compiler/AddLoginListenerTagPassTest.php

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,20 @@ public function testProcess(): void
2828

2929
$this->assertSame([['event' => AuthenticationSuccessEvent::class, 'method' => 'handleAuthenticationSuccessEvent']], $listenerDefinition->getTag('kernel.event_listener'));
3030
}
31+
32+
public function testProcessLoginSuccess(): void
33+
{
34+
if (!class_exists(LoginSuccessEvent::class)) {
35+
$this->markTestSkipped('Skipping this test because LoginSuccessEvent does not exist.');
36+
}
37+
38+
$container = new ContainerBuilder();
39+
$container->register(LoginListener::class)->setPublic(true);
40+
$container->addCompilerPass(new AddLoginListenerTagPass());
41+
$container->compile();
42+
43+
$listenerDefinition = $container->getDefinition(LoginListener::class);
44+
45+
$this->assertSame([['event' => LoginSuccessEvent::class, 'method' => 'handleLoginSuccessEvent']], $listenerDefinition->getTag('kernel.event_listener'));
46+
}
3147
}

0 commit comments

Comments
 (0)