Capture invalid IP address exceptions (#931)

Author: stayallive

phpstan-baseline.neon

@@ -332,7 +332,7 @@ parameters:
 
 		-
 			message: "#^Access to undefined constant Symfony\\\\Component\\\\HttpKernel\\\\HttpKernelInterface\\:\\:MASTER_REQUEST\\.$#"
-			count: 6
+			count: 7
 			path: tests/EventListener/RequestListenerTest.php
 
 		-

src/EventListener/RequestListener.php

@@ -56,7 +56,11 @@ public function handleKernelRequestEvent(RequestEvent $event): void
             $user = $scope->getUser() ?? new UserDataBag();
 
             if (null === $user->getIpAddress()) {
-                $user->setIpAddress($event->getRequest()->getClientIp());
+                try {
+                    $user->setIpAddress($event->getRequest()->getClientIp());
+                } catch (\InvalidArgumentException $e) {
+                    // If the IP is in an invalid format, we ignore it
+                }
             }
 
             $scope->setUser($user);

tests/EventListener/RequestListenerTest.php

@@ -121,6 +121,17 @@ public function handleKernelRequestEventDataProvider(): \Generator
             new UserDataBag('foo_user', null, '::1'),
             new UserDataBag('foo_user', null, '::1'),
         ];
+
+        yield 'remote address empty' => [
+            new RequestEvent(
+                $this->createMock(HttpKernelInterface::class),
+                new Request([], [], [], [], [], ['REMOTE_ADDR' => '']),
+                \defined(HttpKernelInterface::class . '::MAIN_REQUEST') ? HttpKernelInterface::MAIN_REQUEST : HttpKernelInterface::MASTER_REQUEST
+            ),
+            $this->getMockedClientWithOptions(new Options(['send_default_pii' => true])),
+            new UserDataBag(),
+            new UserDataBag(),
+        ];
     }
 
     /**