add different test file for older php/symfony versions

Author: Litarnus

tests/End2End/App/Command/CrashingSubcommandTestCommand.php

@@ -29,7 +29,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $this->logger->error('subcommand crash 1 error');
 
         if (null !== $this->getApplication()) {
-            $this->getApplication()->doRun(new ArrayInput(['command' => "sentry:breadcrumb:test"]), new NullOutput());
+            $this->getApplication()->doRun(new ArrayInput(['command' => 'sentry:breadcrumb:test']), new NullOutput());
         }
 
         $this->logger->error('subcommand error 2 error');

tests/End2End/App/KernelForBufferTest.php

@@ -17,7 +17,9 @@ public function registerContainerConfiguration(LoaderInterface $loader): void
         parent::registerContainerConfiguration($loader);
         $loader->load(__DIR__ . '/config_buffer_test.yml');
 
-        if (!$this->supportsHubId()) {
+        if ($this->supportsHubId()) {
+            $loader->load(__DIR__ . '/config_buffer_test_newer_versions.yml');
+        } else {
             $loader->load(__DIR__ . '/config_buffer_test_php72.yml');
         }
     }
@@ -30,9 +32,7 @@ private function supportsHubId(): bool
         try {
             if (class_exists('Composer\InstalledVersions')) {
                 $version = \Composer\InstalledVersions::getVersion('symfony/monolog-bundle');
-                if ($version && version_compare($version, '3.7.0', '>=')) {
-                    return true;
-                }
+                return $version && version_compare($version, '3.7.0', '>=');
             }
 
             return false;

tests/End2End/App/config_buffer_test.yml

@@ -35,16 +35,4 @@ monolog:
       type: stream
       path: "%kernel.logs_dir%/%kernel.environment%.log"
       level: debug
-    sentry:
-      type: sentry
-      level: warning
-      hub_id: 'Sentry\State\HubInterface'
-    sentry_breadcrumbs:
-      type: service
-      name: sentry_breadcrumbs
-      id: Sentry\Monolog\BreadcrumbHandler
-    sentry_buffer:
-      type: buffer
-      handler: sentry
-      level: notice
-      buffer_size: 50
+

tests/End2End/App/config_buffer_test_newer_versions.yml

@@ -0,0 +1,15 @@
+monolog:
+  handlers:
+    sentry:
+      type: sentry
+      level: warning
+      hub_id: 'Sentry\State\HubInterface'
+    sentry_breadcrumbs:
+      type: service
+      name: sentry_breadcrumbs
+      id: Sentry\Monolog\BreadcrumbHandler
+    sentry_buffer:
+      type: buffer
+      handler: sentry
+      level: notice
+      buffer_size: 50

tests/End2End/BreadcrumbTestCommandTest.php

@@ -68,6 +68,7 @@ public function testBreadcrumbWithConsoleListener()
         $this->assertCount(2, $event->getBreadcrumbs());
         $this->assertEquals('breadcrumb 1 error', $event->getBreadcrumbs()[0]->getMessage());
         $this->assertCount(1, $event->getExceptions());
+        $this->assertNotNull($event->getMessage());
         $this->assertStringStartsWith('Error thrown while running command', $event->getMessage());
     }