move controller registration into main config

Author: Litarnus

tests/End2End/App/Controller/TracingController.php

@@ -29,50 +29,26 @@ public function __construct(HubInterface $hub, ?Connection $connection = null)
 
     public function pingDatabase(): Response
     {
-        try {
-            $this->hub->setSpan(
-                $this->hub->getSpan()
-                    ->startChild($this->createSpan())
-            );
+        $this->hub->setSpan(
+            $this->hub->getSpan()
+                ->startChild($this->createSpan())
+        );
 
-            if ($this->connection) {
-                $this->connection->executeQuery('SELECT 1');
-            }
-
-            return new Response('Success');
-        } catch (\Throwable $e) {
-            $errorMessage = sprintf(
-                "Exception: %s\nMessage: %s\nFile: %s\nLine: %d",
-                get_class($e),
-                $e->getMessage(),
-                $e->getFile(),
-                $e->getLine()
-            );
-
-            return new Response($errorMessage, 200);
+        if ($this->connection) {
+            $this->connection->executeQuery('SELECT 1');
         }
+
+        return new Response('Success');
     }
 
     public function ignoredTransaction(): Response
     {
-        try {
-            $this->hub->setSpan(
-                $this->hub->getSpan()
-                    ->startChild($this->createSpan())
-            );
+        $this->hub->setSpan(
+            $this->hub->getSpan()
+                ->startChild($this->createSpan())
+        );
 
-            return new Response('Success');
-        } catch (\Throwable $e) {
-            $errorMessage = sprintf(
-                "Exception: %s\nMessage: %s\nFile: %s\nLine: %d",
-                get_class($e),
-                $e->getMessage(),
-                $e->getFile(),
-                $e->getLine()
-            );
-
-            return new Response($errorMessage, 200);
-        }
+        return new Response('Success');
     }
 
     private function createSpan(): SpanContext

tests/End2End/App/config.yml

@@ -33,6 +33,13 @@ services:
     tags:
       - controller.service_arguments
 
+  Sentry\SentryBundle\Tests\End2End\App\Controller\TracingController:
+    arguments:
+      $hub: '@Sentry\State\HubInterface'
+      $connection: '@?doctrine.dbal.default_connection'
+    tags:
+      - controller.service_arguments
+
   Sentry\SentryBundle\Tests\End2End\App\Command\MainCommand:
     tags: [{ name: 'console.command', command: 'main-command' }]
 

tests/End2End/App/tracing.yml

@@ -3,11 +3,3 @@ sentry:
     enabled: true
   options:
     traces_sample_rate: 1
-
-services:
-  Sentry\SentryBundle\Tests\End2End\App\Controller\TracingController:
-    arguments:
-      $hub: '@Sentry\State\HubInterface'
-      $connection: '@?doctrine.dbal.default_connection'
-    tags:
-      - { name: controller.service_arguments }