PHPStan + CS

Author: Litarnus

phpstan-baseline.neon

@@ -90,6 +90,11 @@ parameters:
 			count: 1
 			path: src/DependencyInjection/SentryExtension.php
 
+		-
+			message: "#^Cannot access offset 'before_send_metric' on mixed\\.$#"
+			count: 1
+			path: src/DependencyInjection/SentryExtension.php
+
 		-
 			message: "#^Parameter \\#1 \\$array of function array_filter expects array, mixed given\\.$#"
 			count: 1
@@ -102,7 +107,7 @@ parameters:
 
 		-
 			message: "#^Parameter \\#1 \\$id of class Symfony\\\\Component\\\\DependencyInjection\\\\Reference constructor expects string, mixed given\\.$#"
-			count: 11
+			count: 12
 			path: src/DependencyInjection/SentryExtension.php
 
 		-
@@ -170,21 +175,6 @@ parameters:
 			count: 1
 			path: src/EventListener/LoginListener.php
 
-		-
-			message: "#^Instanceof between Throwable and Symfony\\\\Component\\\\Messenger\\\\Exception\\\\DelayedMessageHandlingException will always evaluate to false\\.$#"
-			count: 1
-			path: src/EventListener/MessengerListener.php
-
-		-
-			message: "#^Instanceof between Throwable and Symfony\\\\Component\\\\Messenger\\\\Exception\\\\HandlerFailedException will always evaluate to false\\.$#"
-			count: 1
-			path: src/EventListener/MessengerListener.php
-
-		-
-			message: "#^Result of && is always false\\.$#"
-			count: 2
-			path: src/EventListener/MessengerListener.php
-
 		-
 			message: "#^Call to an undefined method Symfony\\\\Component\\\\HttpKernel\\\\Event\\\\KernelEvent\\:\\:isMasterRequest\\(\\)\\.$#"
 			count: 1

src/DependencyInjection/SentryExtension.php

@@ -320,7 +320,7 @@ private function registerHttpClientTracingConfiguration(ContainerBuilder $contai
     }
 
     /**
-     * @param string[] $integrations
+     * @param string[]             $integrations
      * @param array<string, mixed> $config
      *
      * @return array<Reference|Definition>
@@ -352,12 +352,12 @@ private function configureRequestIntegration(array $integrations, bool $useDefau
 
     /**
      * @param class-string<IntegrationInterface> $integrationClass
-     * @param array<Reference|Definition> $integrations
+     * @param array<Reference|Definition>        $integrations
      */
     private function isIntegrationEnabled(string $integrationClass, array $integrations): bool
     {
         foreach ($integrations as $integration) {
-            if ($integration instanceof Reference && $integrationClass === (string)$integration) {
+            if ($integration instanceof Reference && $integrationClass === (string) $integration) {
                 return true;
             }
 

tests/DependencyInjection/SentryExtensionTest.php

@@ -499,7 +499,7 @@ private function createContainerFromFixture(string $fixtureFile): ContainerBuild
 
     /**
      * @param array<int, mixed> $methodCall
-     * @param mixed[] $arguments
+     * @param mixed[]           $arguments
      */
     private function assertDefinitionMethodCallAt(array $methodCall, string $method, array $arguments): void
     {

tests/End2End/Fixtures/SentryCallbacks.php

@@ -1,20 +1,21 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Sentry\SentryBundle\Tests\End2End\Fixtures;
 
 use Sentry\Metrics\Types\Metric;
 
 class SentryCallbacks
 {
-
     public static function getBeforeSendMetric(): callable
     {
         return static function (Metric $metric): ?Metric {
-            if ($metric->getName() === 'test-counter') {
+            if ('test-counter' === $metric->getName()) {
                 return null;
             }
+
             return $metric;
         };
     }
-
 }