-
-
Notifications
You must be signed in to change notification settings - Fork 77
Open
Description
Some of our wizards today actively enable source map generation (e.g. Angular). Some others don't do anything but let the meta framework SDK's build plugin take care of setting hidden as a default (e.g NextJS). This however, misses the case where users actively disabled sourceMap settings, in which case our plugins also don't enable it (i.e. respect users' decisions but warn about it).
We should adjust our wizards to do the following:
- if no specific source map settings are found:
- do nothing, if we can override source maps generation at build time
- enable source maps (ideally to
'hidden',trueotherwise) if we can't override at build time
- if source maps generation is disabled (e.g.
sourceMap: false), ask if users want to enable it- set to
'hidden'(ortrueif hidden does not apply). - set
filesToDeleteAfterUploadto a generic glob that matches on all.js.mapfiles
- set to
Today's behaviour:
- Angular: Always enable with
true, even if users disabled it beforehand - NextJS:
- does nothing, let's build time handle it
- (exception:
widenClientFileUpload: true)
- Nuxt:
- sets
hiddenfor client - unsure about server
- sets
- SvelteKit: Does nothing, defers to build time plugin
- Remix:
- For Vite: Enables source map generation in Vite config (
true), instructstrueas fallback - For CLI (pre-Vite): Enables source map generation via
--sourcemapCLI arg
- For Vite: Enables source map generation in Vite config (
- Sourcemaps
- Either actively modifies code to
true - Or instructs users to set
true
- Either actively modifies code to
Metadata
Metadata
Assignees
Labels
No labels