Skip to content

Commit 00958f9

Browse files
snigdhasceorourke
authored andcommitted
Fix types
1 parent cf13b1f commit 00958f9

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

src/sentry/models/groupopenperiod.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ def get_open_periods_for_group(
243243
return open_periods
244244

245245

246-
def create_open_period(group: Group, start_time: datetime) -> GroupOpenPeriod:
246+
def create_open_period(group: Group, start_time: datetime) -> None:
247247
if not features.has("organizations:issue-open-periods", group.project.organization):
248248
return
249249

@@ -254,7 +254,7 @@ def create_open_period(group: Group, start_time: datetime) -> GroupOpenPeriod:
254254

255255
# There are some historical cases where we log multiple regressions for the same group,
256256
# but we only want to create a new open period for the first regression
257-
return GroupOpenPeriod.objects.create(
257+
GroupOpenPeriod.objects.create(
258258
group=group,
259259
project=group.project,
260260
date_started=start_time,

tests/sentry/workflow_engine/models/test_incident_groupopenperiod.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,12 @@ def test_create_second_relationship(self) -> None:
159159

160160
open_period.group.update(status=GroupStatus.RESOLVED)
161161
open_period.update(date_ended=timezone.now())
162-
open_period_2 = create_open_period(open_period.group, timezone.now())
162+
create_open_period(open_period.group, timezone.now())
163+
open_period_2 = (
164+
GroupOpenPeriod.objects.filter(group=open_period.group)
165+
.order_by("-date_started")
166+
.first()
167+
)
163168

164169
# Create new incident and new relationship
165170
incident2 = self.create_incident(

0 commit comments

Comments
 (0)