feat(uptime): Add feature flag to prevent creating issue platform issues for uptime (#74530)

This adds a flag to control whether uptime monitors will create issues
in the issue platform

Author: wedamija

src/sentry/features/temporary.py

@@ -469,6 +469,8 @@ def register_temporary_features(manager: FeatureManager):
     manager.add("organizations:uptime-automatic-subscription-creation", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE)
     # Enabled returning uptime monitors from the rule api
     manager.add("organizations:uptime-rule-api", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE)
+    # Enable creating issues via the issue platform
+    manager.add("organizations:uptime-create-issues", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE)
     # Enables uptime related settings for projects and orgs
     manager.add('organizations:uptime-settings', OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE)
     manager.add("organizations:use-metrics-layer", OrganizationFeature, FeatureHandlerStrategy.REMOTE)

src/sentry/uptime/consumers/results_consumer.py

@@ -10,6 +10,7 @@
     CheckResult,
 )
 
+from sentry import features
 from sentry.conf.types.kafka_definition import Topic
 from sentry.remote_subscriptions.consumers.result_consumer import (
     ResultProcessor,
@@ -175,13 +176,19 @@ def handle_result_for_project_active_mode(
             project_subscription.uptime_status == UptimeStatus.OK
             and result["status"] == CHECKSTATUS_FAILURE
         ):
-            create_issue_platform_occurrence(result, project_subscription)
+            if features.has(
+                "organizations:uptime-create-issues", project_subscription.project.organization
+            ):
+                create_issue_platform_occurrence(result, project_subscription)
             project_subscription.update(uptime_status=UptimeStatus.FAILED)
         elif (
             project_subscription.uptime_status == UptimeStatus.FAILED
             and result["status"] == CHECKSTATUS_SUCCESS
         ):
-            resolve_uptime_issue(project_subscription)
+            if features.has(
+                "organizations:uptime-create-issues", project_subscription.project.organization
+            ):
+                resolve_uptime_issue(project_subscription)
             project_subscription.update(uptime_status=UptimeStatus.OK)
 
 

tests/sentry/uptime/consumers/test_results_consumers.py

@@ -64,7 +64,9 @@ def send_result(self, result: CheckResult):
 
     def test(self):
         result = self.create_uptime_result(self.subscription.subscription_id)
-        with mock.patch("sentry.uptime.consumers.results_consumer.metrics") as metrics:
+        with mock.patch(
+            "sentry.uptime.consumers.results_consumer.metrics"
+        ) as metrics, self.feature("organizations:uptime-create-issues"):
             self.send_result(result)
             metrics.incr.assert_has_calls(
                 [
@@ -81,12 +83,33 @@ def test(self):
         self.project_subscription.refresh_from_db()
         assert self.project_subscription.uptime_status == UptimeStatus.FAILED
 
+    def test_no_create_issues_feature(self):
+        result = self.create_uptime_result(self.subscription.subscription_id)
+        with mock.patch("sentry.uptime.consumers.results_consumer.metrics") as metrics:
+            self.send_result(result)
+            metrics.incr.assert_has_calls(
+                [
+                    call(
+                        "uptime.result_processor.handle_result_for_project",
+                        tags={"status": CHECKSTATUS_FAILURE, "mode": "auto_detected_active"},
+                    ),
+                ]
+            )
+
+        hashed_fingerprint = md5(str(self.project_subscription.id).encode("utf-8")).hexdigest()
+        with pytest.raises(Group.DoesNotExist):
+            Group.objects.get(grouphash__hash=hashed_fingerprint)
+        self.project_subscription.refresh_from_db()
+        assert self.project_subscription.uptime_status == UptimeStatus.FAILED
+
     def test_resolve(self):
         result = self.create_uptime_result(
             self.subscription.subscription_id,
             scheduled_check_time=datetime.now() - timedelta(minutes=5),
         )
-        with mock.patch("sentry.uptime.consumers.results_consumer.metrics") as metrics:
+        with mock.patch(
+            "sentry.uptime.consumers.results_consumer.metrics"
+        ) as metrics, self.feature("organizations:uptime-create-issues"):
             self.send_result(result)
             metrics.incr.assert_has_calls(
                 [
@@ -109,7 +132,9 @@ def test_resolve(self):
             status=CHECKSTATUS_SUCCESS,
             scheduled_check_time=datetime.now() - timedelta(minutes=4),
         )
-        with mock.patch("sentry.uptime.consumers.results_consumer.metrics") as metrics:
+        with mock.patch(
+            "sentry.uptime.consumers.results_consumer.metrics"
+        ) as metrics, self.feature("organizations:uptime-create-issues"):
             self.send_result(result)
             metrics.incr.assert_has_calls(
                 [
@@ -127,7 +152,9 @@ def test_resolve(self):
     def test_no_subscription(self):
         subscription_id = uuid.uuid4().hex
         result = self.create_uptime_result(subscription_id)
-        with mock.patch("sentry.uptime.consumers.results_consumer.metrics") as metrics:
+        with mock.patch(
+            "sentry.uptime.consumers.results_consumer.metrics"
+        ) as metrics, self.feature("organizations:uptime-create-issues"):
             self.send_result(result)
             metrics.incr.assert_has_calls([call("uptime.result_processor.subscription_not_found")])
 
@@ -137,7 +164,9 @@ def test_skip_already_processed(self):
             build_last_update_key(self.project_subscription),
             int(result["scheduled_check_time_ms"]),
         )
-        with mock.patch("sentry.uptime.consumers.results_consumer.metrics") as metrics:
+        with mock.patch(
+            "sentry.uptime.consumers.results_consumer.metrics"
+        ) as metrics, self.feature("organizations:uptime-create-issues"):
             self.send_result(result)
             metrics.incr.assert_has_calls(
                 [
@@ -163,6 +192,7 @@ def test_missed(self):
         with (
             mock.patch("sentry.uptime.consumers.results_consumer.metrics") as metrics,
             mock.patch("sentry.uptime.consumers.results_consumer.logger") as logger,
+            self.feature("organizations:uptime-create-issues"),
         ):
             self.send_result(result)
             metrics.incr.assert_called_once_with(
@@ -189,7 +219,9 @@ def test_onboarding_failure(self):
         redis = _get_cluster()
         key = build_onboarding_failure_key(self.project_subscription)
         assert redis.get(key) is None
-        with mock.patch("sentry.uptime.consumers.results_consumer.metrics") as metrics:
+        with mock.patch(
+            "sentry.uptime.consumers.results_consumer.metrics"
+        ) as metrics, self.feature("organizations:uptime-create-issues"):
             self.send_result(result)
             metrics.incr.assert_has_calls(
                 [
@@ -216,6 +248,7 @@ def test_onboarding_failure(self):
                 "sentry.uptime.consumers.results_consumer.ONBOARDING_FAILURE_THRESHOLD", new=2
             ),
             self.tasks(),
+            self.feature("organizations:uptime-create-issues"),
         ):
             self.send_result(result)
             metrics.incr.assert_has_calls(
@@ -251,7 +284,9 @@ def test_onboarding_success_ongoing(self):
         redis = _get_cluster()
         key = build_onboarding_failure_key(self.project_subscription)
         assert redis.get(key) is None
-        with mock.patch("sentry.uptime.consumers.results_consumer.metrics") as metrics:
+        with mock.patch(
+            "sentry.uptime.consumers.results_consumer.metrics"
+        ) as metrics, self.feature("organizations:uptime-create-issues"):
             self.send_result(result)
             metrics.incr.assert_has_calls(
                 [
@@ -284,7 +319,7 @@ def test_onboarding_success_graduate(self):
         assert redis.get(key) is None
         with mock.patch(
             "sentry.uptime.consumers.results_consumer.metrics"
-        ) as metrics, self.tasks():
+        ) as metrics, self.tasks(), self.feature("organizations:uptime-create-issues"):
             self.send_result(result)
             metrics.incr.assert_has_calls(
                 [