fix(ourlogs): Add some missing aliases (#97632)

### Summary
Adds aliases for precise and observed timestamp, which should be
emitted.

Author: k-fish

src/sentry/search/eap/ourlogs/attributes.py

@@ -42,6 +42,22 @@
             search_type="string",
             validator=is_event_id_or_list,
         ),
+        ResolvedAttribute(
+            public_alias="timestamp_precise",
+            internal_name="sentry.timestamp_precise",
+            search_type="number",
+        ),
+        ResolvedAttribute(
+            public_alias="observed_timestamp",
+            internal_name="sentry.observed_timestamp_nanos",
+            internal_type=constants.STRING,  # Stored as string, but we want to search as a number.
+            search_type="number",
+        ),
+        ResolvedAttribute(
+            public_alias="payload_size",
+            internal_name="sentry.payload_size_bytes",
+            search_type="byte",
+        ),
         simple_sentry_field("browser.name"),
         simple_sentry_field("browser.version"),
         simple_sentry_field("environment"),

src/sentry/snuba/rpc_dataset_common.py

@@ -157,6 +157,7 @@ def get_table_rpc_request(cls, query: TableQuery) -> TableRequest:
             query.selected_columns,
             has_aggregates=any(equation for equation in equations if equation.is_aggregate),
         )
+
         all_columns = columns + equations
         contexts = resolver.resolve_contexts(query_contexts + column_contexts)
         # We allow orderby function_aliases if they're a selected_column

tests/sentry/search/eap/test_ourlogs.py

@@ -279,3 +279,50 @@ def test_monoid_functions(function_name, proto_function) -> None:
             extrapolation_mode=ExtrapolationMode.EXTRAPOLATION_MODE_SAMPLE_WEIGHTED,
         )
         assert virtual_context is None
+
+
+@pytest.mark.parametrize(
+    "test_case",
+    [
+        {
+            "attribute_definition": OURLOG_DEFINITIONS.columns["observed_timestamp"],
+            "search_term": 1234567890,
+            "expected_value": AttributeValue(val_str="1234567890.0"),
+            "expected_search_proto_type": AttributeKey.Type.TYPE_STRING,
+        },
+        {
+            "attribute_definition": OURLOG_DEFINITIONS.columns["observed_timestamp"],
+            "search_term": "1111111111",
+            "expected_value": AttributeValue(val_str="1111111111.0"),
+            "expected_search_proto_type": AttributeKey.Type.TYPE_STRING,
+        },
+        {
+            "attribute_definition": OURLOG_DEFINITIONS.columns["payload_size"],
+            "search_term": 1337,
+            "expected_value": AttributeValue(val_double=1337),
+            "expected_search_proto_type": AttributeKey.Type.TYPE_DOUBLE,
+        },
+    ],
+)
+def test_attribute_search(test_case) -> None:
+    attribute_definition = test_case["attribute_definition"]
+    search_term = test_case["search_term"]
+    expected_value = test_case["expected_value"]
+    expected_search_proto_type = test_case["expected_search_proto_type"]
+    attribute_alias = attribute_definition.public_alias
+    resolver = SearchResolver(
+        params=SnubaParams(), config=SearchResolverConfig(), definitions=OURLOG_DEFINITIONS
+    )
+    query = f"{attribute_alias}:{search_term}"
+    where, having, _ = resolver.resolve_query(query)
+
+    assert where == TraceItemFilter(
+        comparison_filter=ComparisonFilter(
+            key=AttributeKey(
+                name=attribute_definition.internal_name, type=expected_search_proto_type
+            ),
+            op=ComparisonFilter.OP_EQUALS,
+            value=expected_value,
+        )
+    )
+    assert having is None

tests/snuba/api/endpoints/test_organization_events_ourlogs.py

@@ -301,6 +301,33 @@ def test_count_meta_type_is_integer(self) -> None:
         assert response.data["data"] == [{"message": "foo", "count()": 1}]
         assert response.data["meta"]["fields"]["count()"] == "integer"
 
+    def test_payload_bytes_meta_type_is_byte(self) -> None:
+        one_day_ago = before_now(days=1).replace(microsecond=0)
+
+        log1 = self.create_ourlog(
+            {"body": "foo"},
+            attributes={"sentry.payload_size_bytes": 1234567},
+            timestamp=one_day_ago,
+        )
+        self.store_ourlogs([log1])
+
+        request = {
+            "field": ["message", "payload_size"],
+            "project": self.project.id,
+            "dataset": self.dataset,
+        }
+
+        response = self.do_request(
+            {
+                **request,
+                "query": "message:foo payload_size:1234567",
+            }
+        )
+        assert response.status_code == 200, response.content
+        assert response.data["data"] == [{"message": "foo", "payload_size": 1234567}]
+        assert response.data["meta"]["fields"]["payload_size"] == "size"
+        assert response.data["meta"]["units"]["payload_size"] == "byte"
+
     def test_pagelimit(self) -> None:
         log = self.create_ourlog(
             {"body": "test"},

tests/snuba/api/endpoints/test_project_trace_item_details.py

@@ -77,7 +77,7 @@ def test_simple(self) -> None:
                 "value": str(timestamp_nanos),
             },
             {
-                "name": "tags[sentry.timestamp_precise,number]",
+                "name": "timestamp_precise",
                 "type": "int",
                 "value": str(timestamp_nanos),
             },
@@ -133,7 +133,7 @@ def test_simple_using_logs_item_type(self) -> None:
                     "value": str(timestamp_nanos),
                 },
                 {
-                    "name": "tags[sentry.timestamp_precise,number]",
+                    "name": "timestamp_precise",
                     "type": "int",
                     "value": str(timestamp_nanos),
                 },
@@ -328,7 +328,7 @@ def test_logs_with_a_meta_key(self) -> None:
                     "value": str(timestamp_nanos),
                 },
                 {
-                    "name": "tags[sentry.timestamp_precise,number]",
+                    "name": "timestamp_precise",
                     "type": "int",
                     "value": str(timestamp_nanos),
                 },
@@ -377,7 +377,7 @@ def test_user_attributes_collide_with_sentry_attributes(self) -> None:
                     "value": str(timestamp_nanos),
                 },
                 {
-                    "name": "tags[sentry.timestamp_precise,number]",
+                    "name": "timestamp_precise",
                     "type": "int",
                     "value": str(timestamp_nanos),
                 },