Merge pull request #4927 from getsentry/bugfix/allow-more-chars-in-release

Soften release version regex

Author: mitsuhiko

src/sentry/api/endpoints/project_releases.py

@@ -1,5 +1,4 @@
 from __future__ import absolute_import
-import string
 
 from django.db import IntegrityError, transaction
 
@@ -43,20 +42,15 @@ def list_releases_scenario(runner):
 
 
 class ReleaseSerializer(serializers.Serializer):
-    version = serializers.RegexField(r'[a-zA-Z0-9\-_\.]', max_length=64, required=True)
+    version = serializers.RegexField(r'^[a-zA-Z0-9\-_\. \(\)]+\Z',
+                                     max_length=64, required=True)
     ref = serializers.CharField(max_length=64, required=False)
     url = serializers.URLField(required=False)
     owner = UserField(required=False)
     dateStarted = serializers.DateTimeField(required=False)
     dateReleased = serializers.DateTimeField(required=False)
     commits = ListField(child=CommitSerializer(), required=False)
 
-    def validate_version(self, attrs, source):
-        value = attrs[source]
-        if not set(value).isdisjoint(set(string.whitespace)):
-            raise serializers.ValidationError('Enter a valid value')
-        return attrs
-
 
 class ProjectReleasesEndpoint(ProjectEndpoint):
     doc_section = DocSection.RELEASES

tests/sentry/api/endpoints/test_project_releases.py

@@ -113,6 +113,29 @@ def test_minimal(self):
         assert release.organization == project.organization
         assert release.projects.first() == project
 
+    def test_ios_release(self):
+        self.login_as(user=self.user)
+
+        project = self.create_project(name='foo')
+
+        url = reverse('sentry-api-0-project-releases', kwargs={
+            'organization_slug': project.organization.slug,
+            'project_slug': project.slug,
+        })
+        response = self.client.post(url, data={
+            'version': '1.2.1 (123)',
+        })
+
+        assert response.status_code == 201, response.content
+        assert response.data['version']
+
+        release = Release.objects.get(
+            version=response.data['version'],
+        )
+        assert not release.owner
+        assert release.organization == project.organization
+        assert release.projects.first() == project
+
     def test_duplicate(self):
         self.login_as(user=self.user)