feat(prevent): Add logaf sensitivity dropdown to ai config (#101040)

(cherry picked from commit 8580194)

Author: suejung-sentry

static/app/types/prevent.tsx

@@ -1,6 +1,8 @@
 // Add any new providers here e.g., 'github' | 'bitbucket' | 'gitlab'
 export type PreventAIProvider = 'github';
 
+export type Sensitivity = 'low' | 'medium' | 'high' | 'critical';
+
 interface PreventAIRepo {
   fullName: string;
   id: string;
@@ -18,7 +20,7 @@ export interface PreventAIOrg {
 interface PreventAIFeatureConfig {
   enabled: boolean;
   triggers: PreventAIFeatureTriggers;
-  sensitivity?: string;
+  sensitivity?: Sensitivity;
 }
 
 export interface PreventAIFeatureTriggers {

static/app/views/prevent/preventAI/hooks/useUpdatePreventAIFeature.spec.tsx

@@ -25,7 +25,6 @@ describe('useUpdatePreventAIFeature', () => {
             test_generation: {
               enabled: false,
               triggers: {on_command_phrase: false, on_ready_for_review: false},
-              sensitivity: 'medium',
             },
             bug_prediction: {
               enabled: false,
@@ -46,7 +45,6 @@ describe('useUpdatePreventAIFeature', () => {
           test_generation: {
             enabled: false,
             triggers: {on_command_phrase: false, on_ready_for_review: false},
-            sensitivity: 'medium',
           },
           bug_prediction: {
             enabled: false,
@@ -193,19 +191,19 @@ describe('useUpdatePreventAIFeature', () => {
       expect(feature?.triggers.on_ready_for_review).toBe(true);
     });
 
-    it('should preserve sensitivity', () => {
+    it('should update sensitivity', () => {
       const config = structuredClone(mockOrg.preventAiConfigGithub!);
       const updatedConfig = makePreventAIConfig(config, {
         feature: 'bug_prediction',
-        enabled: false,
+        enabled: true,
         orgName: 'org-1',
         repoName: 'repo-xyz',
-        trigger: {on_ready_for_review: true},
+        sensitivity: 'low',
       });
       const feature =
         updatedConfig.github_organizations?.['org-1']?.repo_overrides?.['repo-xyz']
           ?.bug_prediction;
-      expect(feature?.sensitivity).toBe('medium');
+      expect(feature?.sensitivity).toBe('low');
     });
   });
 });

static/app/views/prevent/preventAI/hooks/useUpdatePreventAIFeature.tsx

@@ -1,6 +1,10 @@
 import {updateOrganization} from 'sentry/actionCreators/organizations';
 import type {Organization} from 'sentry/types/organization';
-import type {PreventAIConfig, PreventAIFeatureTriggers} from 'sentry/types/prevent';
+import type {
+  PreventAIConfig,
+  PreventAIFeatureTriggers,
+  Sensitivity,
+} from 'sentry/types/prevent';
 import {fetchMutation, useMutation} from 'sentry/utils/queryClient';
 import useOrganization from 'sentry/utils/useOrganization';
 
@@ -10,6 +14,7 @@ interface UpdatePreventAIFeatureParams {
   orgName: string;
   // if repoName is provided, edit repo_overrides for that repo, otherwise edit org_defaults
   repoName?: string;
+  sensitivity?: Sensitivity;
   trigger?: Partial<PreventAIFeatureTriggers>;
 }
 
@@ -73,7 +78,7 @@ export function makePreventAIConfig(
   featureConfig[params.feature] = {
     enabled: params.enabled,
     triggers: {...featureConfig[params.feature].triggers, ...params.trigger},
-    sensitivity: featureConfig[params.feature].sensitivity,
+    sensitivity: params.sensitivity ?? featureConfig[params.feature].sensitivity,
   };
 
   return updatedConfig;

static/app/views/prevent/preventAI/manageReposPanel.spec.tsx

@@ -35,6 +35,7 @@ describe('ManageReposPanel', () => {
           bug_prediction: {
             enabled: true,
             triggers: {on_command_phrase: true, on_ready_for_review: false},
+            sensitivity: 'medium',
           },
           test_generation: {
             enabled: false,
@@ -43,6 +44,7 @@ describe('ManageReposPanel', () => {
           vanilla: {
             enabled: true,
             triggers: {on_command_phrase: false, on_ready_for_review: false},
+            sensitivity: 'medium',
           },
         },
         repo_overrides: {},
@@ -69,9 +71,9 @@ describe('ManageReposPanel', () => {
 
   it('shows feature toggles with correct initial state', async () => {
     render(<ManageReposPanel {...defaultProps} />, {organization: mockOrganization});
-    expect(await screen.findByLabelText(/PR Review/i)).toBeChecked();
-    expect(await screen.findByLabelText(/Test Generation/i)).not.toBeChecked();
-    expect(await screen.findByLabelText(/Error Prediction/i)).toBeChecked();
+    expect(await screen.findByLabelText(/Enable PR Review/i)).toBeChecked();
+    expect(await screen.findByLabelText(/Enable Test Generation/i)).not.toBeChecked();
+    expect(await screen.findByLabelText(/Enable Error Prediction/i)).toBeChecked();
     expect(
       await screen.findByLabelText(/Auto Run on Opened Pull Requests/i)
     ).not.toBeChecked();
@@ -84,9 +86,9 @@ describe('ManageReposPanel', () => {
       isLoading: true,
     };
     render(<ManageReposPanel {...defaultProps} />, {organization: mockOrganization});
-    expect(await screen.findByLabelText(/PR Review/i)).toBeDisabled();
-    expect(await screen.findByLabelText(/Test Generation/i)).toBeDisabled();
-    expect(await screen.findByLabelText(/Error Prediction/i)).toBeDisabled();
+    expect(await screen.findByLabelText(/Enable PR Review/i)).toBeDisabled();
+    expect(await screen.findByLabelText(/Enable Test Generation/i)).toBeDisabled();
+    expect(await screen.findByLabelText(/Enable Error Prediction/i)).toBeDisabled();
   });
 
   it('shows error message if updateError is present', async () => {
@@ -99,6 +101,22 @@ describe('ManageReposPanel', () => {
     expect(await screen.findByText(/Could not update settings/i)).toBeInTheDocument();
   });
 
+  it('shows sensitivity options when feature is enabled', async () => {
+    render(<ManageReposPanel {...defaultProps} />, {organization: mockOrganization});
+    const prReviewCheckbox = await screen.findByLabelText(/Enable PR Review/i);
+    const errorPredictionCheckbox = await screen.findByLabelText(
+      /Enable Error Prediction/i
+    );
+    expect(prReviewCheckbox).toBeChecked();
+    expect(errorPredictionCheckbox).toBeChecked();
+    expect(
+      await screen.findByTestId(/pr-review-sensitivity-dropdown/i)
+    ).toBeInTheDocument();
+    expect(
+      await screen.findByTestId(/error-prediction-sensitivity-dropdown/i)
+    ).toBeInTheDocument();
+  });
+
   describe('getRepoConfig', () => {
     it('returns repo override config when present', () => {
       const orgConfig: PreventAIOrgConfig = {

static/app/views/prevent/preventAI/manageReposPanel.tsx

@@ -1,5 +1,6 @@
 import {Alert} from 'sentry/components/core/alert';
 import {Button} from 'sentry/components/core/button';
+import {CompactSelect} from 'sentry/components/core/compactSelect';
 import {Flex} from 'sentry/components/core/layout';
 import {ExternalLink} from 'sentry/components/core/link';
 import {Switch} from 'sentry/components/core/switch';
@@ -9,7 +10,7 @@ import SlideOverPanel from 'sentry/components/slideOverPanel';
 import {IconClose} from 'sentry/icons';
 import {t, tct} from 'sentry/locale';
 import {type PreventAIOrgConfig} from 'sentry/types/prevent';
-import type {PreventAIFeatureConfigsByName} from 'sentry/types/prevent';
+import type {PreventAIFeatureConfigsByName, Sensitivity} from 'sentry/types/prevent';
 import useOrganization from 'sentry/utils/useOrganization';
 import {useUpdatePreventAIFeature} from 'sentry/views/prevent/preventAI/hooks/useUpdatePreventAIFeature';
 
@@ -20,6 +21,31 @@ interface ManageReposPanelProps {
   repoName: string;
 }
 
+interface SensitivityOption {
+  details: string;
+  label: string;
+  value: Sensitivity;
+}
+
+const sensitivityOptions: SensitivityOption[] = [
+  {value: 'low', label: 'Low', details: 'Post all potential issues for maximum breadth.'},
+  {
+    value: 'medium',
+    label: 'Medium',
+    details: 'Post likely issues for a balance of thoroughness and noise.',
+  },
+  {
+    value: 'high',
+    label: 'High',
+    details: 'Post only major issues to highlight most impactful findings.',
+  },
+  {
+    value: 'critical',
+    label: 'Critical',
+    details: 'Post only high-impact, high-sensitivity issues for maximum focus.',
+  },
+];
+
 function ManageReposPanel({
   collapsed,
   onClose,
@@ -111,9 +137,9 @@ function ManageReposPanel({
               justify="between"
             >
               <Flex direction="column" gap="sm">
-                <Text size="md">Enable PR Review</Text>
+                <Text size="md">{t('Enable PR Review')}</Text>
                 <Text variant="muted" size="sm">
-                  Run when @sentry review is commented on a PR.
+                  {t('Run when @sentry review is commented on a PR.')}
                 </Text>
               </Flex>
               <Switch
@@ -132,6 +158,41 @@ function ManageReposPanel({
                 aria-label="Enable PR Review"
               />
             </Flex>
+            {repoConfig.vanilla.enabled && (
+              <Flex paddingLeft="xl" direction="column">
+                <Flex direction="column" borderLeft="muted" paddingLeft="md">
+                  <FieldGroup
+                    label={<Text size="md">{t('Sensitivity')}</Text>}
+                    help={
+                      <Text size="xs" variant="muted">
+                        {t('Set the sensitivity level for PR review analysis.')}
+                      </Text>
+                    }
+                    alignRight
+                    flexibleControlStateSize
+                  >
+                    <CompactSelect
+                      value={repoConfig.vanilla.sensitivity ?? 'medium'}
+                      options={sensitivityOptions}
+                      disabled={isLoading || !canEditSettings}
+                      onChange={async option =>
+                        await enableFeature({
+                          feature: 'vanilla',
+                          enabled: true,
+                          orgName,
+                          repoName,
+                          sensitivity: option.value,
+                        })
+                      }
+                      aria-label="PR Review Sensitivity"
+                      menuWidth={350}
+                      maxMenuWidth={500}
+                      data-test-id="pr-review-sensitivity-dropdown"
+                    />
+                  </FieldGroup>
+                </Flex>
+              </Flex>
+            )}
           </Flex>
 
           {/* Test Generation Feature */}
@@ -145,9 +206,9 @@ function ManageReposPanel({
               justify="between"
             >
               <Flex direction="column" gap="sm">
-                <Text size="md">Enable Test Generation</Text>
+                <Text size="md">{t('Enable Test Generation')}</Text>
                 <Text variant="muted" size="sm">
-                  Run when @sentry generate-test is commented on a PR.
+                  {t('Run when @sentry generate-test is commented on a PR.')}
                 </Text>
               </Flex>
               <Switch
@@ -179,9 +240,9 @@ function ManageReposPanel({
               justify="between"
             >
               <Flex direction="column" gap="sm">
-                <Text size="md">Enable Error Prediction</Text>
+                <Text size="md">{t('Enable Error Prediction')}</Text>
                 <Text variant="muted" size="sm">
-                  Allow organization members to review potential bugs.
+                  {t('Allow organization members to review potential bugs.')}
                 </Text>
               </Flex>
               <Switch
@@ -190,7 +251,6 @@ function ManageReposPanel({
                 disabled={isLoading || !canEditSettings}
                 onChange={async () => {
                   const newValue = !repoConfig.bug_prediction.enabled;
-                  // Enable/disable the main bug prediction feature
                   await enableFeature({
                     feature: 'bug_prediction',
                     enabled: newValue,
@@ -202,23 +262,45 @@ function ManageReposPanel({
               />
             </Flex>
             {repoConfig.bug_prediction.enabled && (
-              // width 150% because FieldGroup > FieldDescription has fixed width 50%
-              <Flex paddingLeft="xl" width="150%">
-                <Flex
-                  direction="column"
-                  borderLeft="muted"
-                  radius="md"
-                  paddingLeft="md"
-                  width="100%"
-                >
+              <Flex paddingLeft="xl" direction="column">
+                <Flex direction="column" borderLeft="muted" paddingLeft="md">
+                  <FieldGroup
+                    label={<Text size="md">{t('Sensitivity')}</Text>}
+                    help={
+                      <Text size="xs" variant="muted">
+                        {t('Set the sensitivity level for error prediction.')}
+                      </Text>
+                    }
+                    alignRight
+                    flexibleControlStateSize
+                  >
+                    <CompactSelect
+                      value={repoConfig.bug_prediction.sensitivity ?? 'medium'}
+                      options={sensitivityOptions}
+                      disabled={isLoading || !canEditSettings}
+                      onChange={async option =>
+                        await enableFeature({
+                          feature: 'bug_prediction',
+                          enabled: true,
+                          orgName,
+                          repoName,
+                          sensitivity: option.value,
+                        })
+                      }
+                      aria-label="Error Prediction Sensitivity"
+                      menuWidth={350}
+                      maxMenuWidth={500}
+                      data-test-id="error-prediction-sensitivity-dropdown"
+                    />
+                  </FieldGroup>
                   <FieldGroup
                     label={<Text size="md">{t('Auto Run on Opened Pull Requests')}</Text>}
                     help={
                       <Text size="xs" variant="muted">
                         {t('Run when a PR is published, ignoring new pushes.')}
                       </Text>
                     }
-                    inline
+                    alignRight
                     flexibleControlStateSize
                   >
                     <Switch
@@ -243,10 +325,10 @@ function ManageReposPanel({
                     label={<Text size="md">{t('Run When Mentioned')}</Text>}
                     help={
                       <Text size="xs" variant="muted">
-                        {t('Run when @sentry review is commented on a PR')}
+                        {t('Run when @sentry review is commented on a PR.')}
                       </Text>
                     }
-                    inline
+                    alignRight
                     flexibleControlStateSize
                   >
                     <Switch

tests/js/fixtures/prevent.ts

@@ -1,3 +1,5 @@
+import type {Sensitivity} from 'sentry/types/prevent';
+
 export function PreventAIConfigFixture() {
   return {
     schema_version: 'v1',
@@ -7,17 +9,17 @@ export function PreventAIConfigFixture() {
         bug_prediction: {
           enabled: false,
           triggers: {on_command_phrase: false, on_ready_for_review: false},
-          sensitivity: 'medium',
+          sensitivity: 'medium' as Sensitivity,
         },
         test_generation: {
           enabled: false,
           triggers: {on_command_phrase: false, on_ready_for_review: false},
-          sensitivity: 'medium',
+          sensitivity: 'medium' as Sensitivity,
         },
         vanilla: {
           enabled: false,
           triggers: {on_command_phrase: false, on_ready_for_review: false},
-          sensitivity: 'medium',
+          sensitivity: 'medium' as Sensitivity,
         },
       },
       repo_overrides: {},