Skip to content

Commit 0ad4c4d

Browse files
authored
fix(severity): Add option to route severity requests to GPU (#95992)
as part of [migration plan](https://www.notion.so/sentry/Moving-severity-and-fixability-services-to-GPU-2348b10e4b5d80688a64e3235a653744?source=copy_link#2348b10e4b5d800aa55dccb0695ed2ba) to serve severity on `group-ingest` pods need to wait for getsentry/ops#16321 before increasing option value from 0
1 parent 91cc114 commit 0ad4c4d

File tree

2 files changed

+21
-1
lines changed

2 files changed

+21
-1
lines changed

src/sentry/event_manager.py

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@
108108
from sentry.models.releaseprojectenvironment import ReleaseProjectEnvironment
109109
from sentry.models.releases.release_project import ReleaseProject
110110
from sentry.net.http import connection_from_url
111+
from sentry.options.rollout import in_random_rollout
111112
from sentry.performance_issues.performance_detection import detect_performance_problems
112113
from sentry.performance_issues.performance_problem import PerformanceProblem
113114
from sentry.plugins.base import plugins
@@ -1947,6 +1948,12 @@ def _process_existing_aggregate(
19471948
timeout=settings.SEER_SEVERITY_TIMEOUT, # Defaults to 300 milliseconds
19481949
)
19491950

1951+
severity_connection_pool_gpu = connection_from_url(
1952+
settings.SEER_GROUPING_URL,
1953+
retries=settings.SEER_SEVERITY_RETRIES,
1954+
timeout=settings.SEER_SEVERITY_TIMEOUT, # Defaults to 300 milliseconds
1955+
)
1956+
19501957

19511958
def _get_severity_metadata_for_group(
19521959
event: Event, project_id: int, group_type: int | None
@@ -2168,8 +2175,14 @@ def _get_severity_score(event: Event) -> tuple[float, str]:
21682175
"issues.severity.seer-timout",
21692176
settings.SEER_SEVERITY_TIMEOUT / 1000,
21702177
)
2178+
2179+
if in_random_rollout("issues.severity.gpu-rollout-rate"):
2180+
connection_pool = severity_connection_pool_gpu
2181+
else:
2182+
connection_pool = severity_connection_pool
2183+
21712184
response = make_signed_seer_api_request(
2172-
severity_connection_pool,
2185+
connection_pool,
21732186
"/v0/issues/severity-score",
21742187
body=orjson.dumps(payload),
21752188
timeout=timeout,

src/sentry/options/defaults.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -928,6 +928,13 @@
928928
flags=FLAG_ALLOW_EMPTY | FLAG_AUTOMATOR_MODIFIABLE,
929929
)
930930

931+
register(
932+
"issues.severity.gpu-rollout-rate",
933+
type=Float,
934+
default=0.0,
935+
flags=FLAG_AUTOMATOR_MODIFIABLE,
936+
)
937+
931938
register(
932939
"issues.priority.projects-allowlist",
933940
type=Sequence,

0 commit comments

Comments
 (0)