Skip to content

Commit 0af4648

Browse files
chore(insights): Removes unused transaction filter in web vitals queries (#105431)
Removes an unused `!transaction:"<< unparameterized >>"` filter.
1 parent 5cdd076 commit 0af4648

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

static/app/views/insights/browser/webVitals/components/webVitalsDetailPanel.spec.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ describe('WebVitalsDetailPanel', () => {
6767
'count()',
6868
],
6969
query:
70-
'span.op:[ui.interaction.click,ui.interaction.hover,ui.interaction.drag,ui.interaction.press,ui.webvital.cls,ui.webvital.lcp,pageload,""] !transaction:"<< unparameterized >>"',
70+
'span.op:[ui.interaction.click,ui.interaction.hover,ui.interaction.drag,ui.interaction.press,ui.webvital.cls,ui.webvital.lcp,pageload,""]',
7171
}),
7272
})
7373
);
@@ -100,7 +100,7 @@ describe('WebVitalsDetailPanel', () => {
100100
'sum(measurements.score.weight.lcp)',
101101
],
102102
query:
103-
'span.op:[ui.interaction.click,ui.interaction.hover,ui.interaction.drag,ui.interaction.press,ui.webvital.cls,ui.webvital.lcp,pageload,""] !transaction:"<< unparameterized >>"',
103+
'span.op:[ui.interaction.click,ui.interaction.hover,ui.interaction.drag,ui.interaction.press,ui.webvital.cls,ui.webvital.lcp,pageload,""]',
104104
}),
105105
})
106106
);
@@ -133,7 +133,7 @@ describe('WebVitalsDetailPanel', () => {
133133
'opportunity_score(measurements.score.total)',
134134
],
135135
query:
136-
'span.op:[ui.interaction.click,ui.interaction.hover,ui.interaction.drag,ui.interaction.press,ui.webvital.cls,ui.webvital.lcp,pageload,""] !transaction:"<< unparameterized >>" avg(measurements.score.total):>=0 count_scores(measurements.score.lcp):>0',
136+
'span.op:[ui.interaction.click,ui.interaction.hover,ui.interaction.drag,ui.interaction.press,ui.webvital.cls,ui.webvital.lcp,pageload,""] avg(measurements.score.total):>=0 count_scores(measurements.score.lcp):>0',
137137
}),
138138
})
139139
);

static/app/views/insights/browser/webVitals/settings.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export const MODULE_DOC_LINK =
1010
'https://docs.sentry.io/product/insights/frontend/web-vitals/';
1111

1212
export const DEFAULT_QUERY_FILTER =
13-
'span.op:[ui.interaction.click,ui.interaction.hover,ui.interaction.drag,ui.interaction.press,ui.webvital.cls,ui.webvital.lcp,pageload,""] !transaction:"<< unparameterized >>"';
13+
'span.op:[ui.interaction.click,ui.interaction.hover,ui.interaction.drag,ui.interaction.press,ui.webvital.cls,ui.webvital.lcp,pageload,""]';
1414

1515
export const MODULE_FEATURES = ['insight-modules'];
1616

static/app/views/insights/browser/webVitals/views/pageOverview.spec.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ describe('PageOverview', () => {
101101
'count()',
102102
],
103103
query:
104-
'span.op:[ui.interaction.click,ui.interaction.hover,ui.interaction.drag,ui.interaction.press,ui.webvital.cls,ui.webvital.lcp,pageload,""] !transaction:"<< unparameterized >>"',
104+
'span.op:[ui.interaction.click,ui.interaction.hover,ui.interaction.drag,ui.interaction.press,ui.webvital.cls,ui.webvital.lcp,pageload,""]',
105105
}),
106106
})
107107
);
@@ -133,7 +133,7 @@ describe('PageOverview', () => {
133133
`count_scores(measurements.score.inp)`,
134134
],
135135
query:
136-
'span.op:[ui.interaction.click,ui.interaction.hover,ui.interaction.drag,ui.interaction.press,ui.webvital.cls,ui.webvital.lcp,pageload,""] !transaction:"<< unparameterized >>"',
136+
'span.op:[ui.interaction.click,ui.interaction.hover,ui.interaction.drag,ui.interaction.press,ui.webvital.cls,ui.webvital.lcp,pageload,""]',
137137
}),
138138
})
139139
);

static/app/views/insights/browser/webVitals/views/webVitalsLandingPage.spec.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ describe('WebVitalsLandingPage', () => {
123123
'count_scores(measurements.score.total)',
124124
],
125125
query:
126-
'span.op:[ui.interaction.click,ui.interaction.hover,ui.interaction.drag,ui.interaction.press,ui.webvital.cls,ui.webvital.lcp,pageload,""] !transaction:"<< unparameterized >>" avg(measurements.score.total):>=0',
126+
'span.op:[ui.interaction.click,ui.interaction.hover,ui.interaction.drag,ui.interaction.press,ui.webvital.cls,ui.webvital.lcp,pageload,""] avg(measurements.score.total):>=0',
127127
}),
128128
})
129129
);
@@ -143,7 +143,7 @@ describe('WebVitalsLandingPage', () => {
143143
'count()',
144144
],
145145
query:
146-
'span.op:[ui.interaction.click,ui.interaction.hover,ui.interaction.drag,ui.interaction.press,ui.webvital.cls,ui.webvital.lcp,pageload,""] !transaction:"<< unparameterized >>"',
146+
'span.op:[ui.interaction.click,ui.interaction.hover,ui.interaction.drag,ui.interaction.press,ui.webvital.cls,ui.webvital.lcp,pageload,""]',
147147
}),
148148
})
149149
);
@@ -175,7 +175,7 @@ describe('WebVitalsLandingPage', () => {
175175
`count_scores(measurements.score.inp)`,
176176
],
177177
query:
178-
'span.op:[ui.interaction.click,ui.interaction.hover,ui.interaction.drag,ui.interaction.press,ui.webvital.cls,ui.webvital.lcp,pageload,""] !transaction:"<< unparameterized >>"',
178+
'span.op:[ui.interaction.click,ui.interaction.hover,ui.interaction.drag,ui.interaction.press,ui.webvital.cls,ui.webvital.lcp,pageload,""]',
179179
}),
180180
})
181181
);

static/app/views/performance/landing/widgets/components/widgetContainer.spec.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -969,7 +969,7 @@ describe('Performance > Widgets > WidgetContainer', () => {
969969
'count_scores(measurements.score.total)',
970970
],
971971
query:
972-
'span.op:[ui.interaction.click,ui.interaction.hover,ui.interaction.drag,ui.interaction.press,ui.webvital.cls,ui.webvital.lcp,pageload,""] !transaction:"<< unparameterized >>" avg(measurements.score.total):>=0',
972+
'span.op:[ui.interaction.click,ui.interaction.hover,ui.interaction.drag,ui.interaction.press,ui.webvital.cls,ui.webvital.lcp,pageload,""] avg(measurements.score.total):>=0',
973973
}),
974974
})
975975
);

0 commit comments

Comments
 (0)