Revert setting extrapolation mode to sample weighted (#104136)

Author: shruthilayaj

src/sentry/explore/translation/alerts_translation.py

@@ -13,7 +13,12 @@
     handle_send_historical_data_to_seer,
 )
 from sentry.snuba.dataset import Dataset
-from sentry.snuba.models import QuerySubscription, SnubaQuery, SnubaQueryEventType
+from sentry.snuba.models import (
+    ExtrapolationMode,
+    QuerySubscription,
+    SnubaQuery,
+    SnubaQueryEventType,
+)
 from sentry.snuba.tasks import update_subscription_in_snuba
 from sentry.utils.db import atomic_transaction
 from sentry.workflow_engine.models.data_condition import DataCondition
@@ -88,6 +93,11 @@ def translate_detector_and_update_subscription_in_snuba(snuba_query: SnubaQuery)
     snuba_query.query = translated_query
     snuba_query.dataset = Dataset.EventsAnalyticsPlatform.value
 
+    if snapshot["dataset"] == Dataset.PerformanceMetrics.value:
+        snuba_query.extrapolation_mode = ExtrapolationMode.SERVER_WEIGHTED.value
+    elif snapshot["dataset"] == Dataset.Transactions.value:
+        snuba_query.extrapolation_mode = ExtrapolationMode.NONE.value
+
     with atomic_transaction(
         using=(
             router.db_for_write(SnubaQuery),

tests/sentry/explore/translation/test_alerts_translation.py

@@ -4,6 +4,9 @@
 import orjson
 import pytest
 from sentry_protos.snuba.v1.request_common_pb2 import TraceItemType
+from sentry_protos.snuba.v1.trace_item_attribute_pb2 import (
+    ExtrapolationMode as RPCExtrapolationMode,
+)
 from sentry_protos.snuba.v1.trace_item_attribute_pb2 import Function
 from sentry_protos.snuba.v1.trace_item_filter_pb2 import ComparisonFilter
 from urllib3.response import HTTPResponse
@@ -25,7 +28,7 @@
     StoreDataResponse,
 )
 from sentry.snuba.dataset import Dataset
-from sentry.snuba.models import SnubaQuery, SnubaQueryEventType
+from sentry.snuba.models import ExtrapolationMode, SnubaQuery, SnubaQueryEventType
 from sentry.snuba.subscriptions import create_snuba_query, create_snuba_subscription
 from sentry.testutils.cases import SnubaTestCase, TestCase
 from sentry.testutils.helpers.features import with_feature
@@ -160,6 +163,7 @@ def test_translate_alert_rule_simple_count(self, mock_create_rpc) -> None:
         assert snuba_query.dataset == Dataset.EventsAnalyticsPlatform.value
         assert snuba_query.aggregate == "count(span.duration)"
         assert snuba_query.query == "(span.duration:>100) AND is_transaction:1"
+        assert snuba_query.extrapolation_mode == ExtrapolationMode.SERVER_WEIGHTED.value
 
         event_types = list(
             SnubaQueryEventType.objects.filter(snuba_query=snuba_query).values_list(
@@ -202,6 +206,10 @@ def test_translate_alert_rule_simple_count(self, mock_create_rpc) -> None:
         assert expression.aggregation.key.name == "sentry.project_id"
         assert expression.aggregation.label == "count(span.duration)"
         assert expression.label == "count(span.duration)"
+        assert (
+            expression.aggregation.extrapolation_mode
+            == RPCExtrapolationMode.EXTRAPOLATION_MODE_SERVER_ONLY
+        )
 
         assert len(rpc_time_series_request.group_by) == 0
 
@@ -256,6 +264,7 @@ def test_translate_alert_rule_p95(self, mock_create_rpc) -> None:
         assert snuba_query.dataset == Dataset.EventsAnalyticsPlatform.value
         assert snuba_query.aggregate == "p95(span.duration)"
         assert snuba_query.query == "(transaction.method:GET) AND is_transaction:1"
+        assert snuba_query.extrapolation_mode == ExtrapolationMode.NONE.value
 
         event_types = list(
             SnubaQueryEventType.objects.filter(snuba_query=snuba_query).values_list(
@@ -321,6 +330,7 @@ def test_translate_alert_rule_count_unique(self, mock_create_rpc) -> None:
         assert snuba_query.dataset == Dataset.EventsAnalyticsPlatform.value
         assert snuba_query.aggregate == "count_unique(user)"
         assert snuba_query.query == "(transaction:/api/*) AND is_transaction:1"
+        assert snuba_query.extrapolation_mode == ExtrapolationMode.SERVER_WEIGHTED.value
 
         assert mock_create_rpc.called
         call_args = mock_create_rpc.call_args
@@ -377,6 +387,7 @@ def test_translate_alert_rule_empty_query(self, mock_create_rpc) -> None:
         assert snuba_query.dataset == Dataset.EventsAnalyticsPlatform.value
         assert snuba_query.aggregate == "count(span.duration)"
         assert snuba_query.query == "is_transaction:1"
+        assert snuba_query.extrapolation_mode == ExtrapolationMode.NONE.value
 
         assert mock_create_rpc.called
         call_args = mock_create_rpc.call_args