Skip to content

Commit 11e96af

Browse files
authored
fix(replays): Remove one too many of the same aliases (#97540)
1 parent f17ceaf commit 11e96af

File tree

1 file changed

+32
-9
lines changed

1 file changed

+32
-9
lines changed

src/sentry/replays/query.py

Lines changed: 32 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,10 @@ def query_replays_dataset_tagkey_values(
232232
if tag_substr_query:
233233
where.append(
234234
Condition(
235-
Function("positionCaseInsensitive", parameters=[grouped_column, tag_substr_query]),
235+
Function(
236+
"positionCaseInsensitive",
237+
parameters=[grouped_column, tag_substr_query],
238+
),
236239
Op.NEQ,
237240
0,
238241
)
@@ -269,7 +272,9 @@ def query_replays_dataset_tagkey_values(
269272
tenant_ids=tenant_ids,
270273
)
271274
return raw_snql_query(
272-
snuba_request, referrer="replays.query.query_replays_dataset_tagkey_values", use_cache=True
275+
snuba_request,
276+
referrer="replays.query.query_replays_dataset_tagkey_values",
277+
use_cache=True,
273278
)
274279

275280

@@ -280,7 +285,10 @@ def anyIfNonZeroIP(
280285
) -> Function:
281286
return Function(
282287
"anyIf",
283-
parameters=[Column(column_name), Function("greater", parameters=[Column(column_name), 0])],
288+
parameters=[
289+
Column(column_name),
290+
Function("greater", parameters=[Column(column_name), 0]),
291+
],
284292
alias=alias or column_name if aliased else None,
285293
)
286294

@@ -305,7 +313,8 @@ def _sorted_aggregated_urls(agg_urls_column, alias):
305313
"arrayMap",
306314
parameters=[
307315
Lambda(
308-
["url_tuple"], Function("tupleElement", parameters=[Identifier("url_tuple"), 2])
316+
["url_tuple"],
317+
Function("tupleElement", parameters=[Identifier("url_tuple"), 2]),
309318
),
310319
agg_urls_column,
311320
],
@@ -314,7 +323,8 @@ def _sorted_aggregated_urls(agg_urls_column, alias):
314323
"arrayMap",
315324
parameters=[
316325
Lambda(
317-
["url_tuple"], Function("tupleElement", parameters=[Identifier("url_tuple"), 1])
326+
["url_tuple"],
327+
Function("tupleElement", parameters=[Identifier("url_tuple"), 1]),
318328
),
319329
agg_urls_column,
320330
],
@@ -450,7 +460,11 @@ def _collect_event_ids(alias, ids_type_list):
450460
parameters=[
451461
Lambda(
452462
["error_id_no_dashes"],
453-
_strip_uuid_dashes("error_id_no_dashes", Identifier("error_id_no_dashes")),
463+
_strip_uuid_dashes(
464+
"error_id_no_dashes",
465+
Identifier("error_id_no_dashes"),
466+
aliased=False,
467+
),
454468
),
455469
Function("flatten", [id_types_to_aggregate]),
456470
],
@@ -558,7 +572,11 @@ def _empty_uuids_lambda():
558572
"browser": ["browser_name", "browser_version"],
559573
"device": ["device_name", "device_brand", "device_family", "device_model"],
560574
"sdk": ["sdk_name", "sdk_version"],
561-
"ota_updates": ["ota_updates_channel", "ota_updates_runtime_version", "ota_updates_update_id"],
575+
"ota_updates": [
576+
"ota_updates_channel",
577+
"ota_updates_runtime_version",
578+
"ota_updates_update_id",
579+
],
562580
"tags": ["tk", "tv"],
563581
# Nested fields. Useful for selecting searchable fields.
564582
"user.id": ["user_id"],
@@ -634,7 +652,10 @@ def _empty_uuids_lambda():
634652
"replay_id": Column("replay_id"),
635653
"agg_project_id": Function(
636654
"anyIf",
637-
parameters=[Column("project_id"), Function("equals", parameters=[Column("segment_id"), 0])],
655+
parameters=[
656+
Column("project_id"),
657+
Function("equals", parameters=[Column("segment_id"), 0]),
658+
],
638659
alias="agg_project_id",
639660
),
640661
"trace_ids": Function(
@@ -762,7 +783,9 @@ def _empty_uuids_lambda():
762783
"click.text": Function("groupArray", parameters=[Column("click_text")], alias="click_text"),
763784
"click.title": Function("groupArray", parameters=[Column("click_title")], alias="click_title"),
764785
"click.component_name": Function(
765-
"groupArray", parameters=[Column("click_component_name")], alias="click_component_name"
786+
"groupArray",
787+
parameters=[Column("click_component_name")],
788+
alias="click_component_name",
766789
),
767790
"error_ids": _collect_new_errors(),
768791
"warning_ids": _collect_event_ids("warning_ids", ["warning_id"]),

0 commit comments

Comments
 (0)