fix(aci): Don't dedup actions by workflow (#109251)

We previously deduped by workflow id to preserve consistency with legacy
behavior.
However, conceptually, we don't want to send the same notification to
the same destination for the same issue just because it came from
different sources.

Fixes ISWF-1946.

Author: kcons

src/sentry/workflow_engine/models/action.py

@@ -152,11 +152,8 @@ def trigger(self, event_data: WorkflowEventData, notification_uuid: str) -> None
             },
         )
 
-    def get_dedup_key(self, workflow_id: int | None) -> str:
+    def get_dedup_key(self) -> str:
         key_parts = [self.type]
-        if workflow_id is not None:
-            key_parts.append(str(workflow_id))
-
         if self.integration_id:
             key_parts.append(str(self.integration_id))
 

src/sentry/workflow_engine/processors/action.py

@@ -231,9 +231,7 @@ def get_unique_active_actions(
         if action.status != ObjectStatus.ACTIVE:
             continue
 
-        # workflow_id is annotated in the queryset
-        workflow_id = getattr(action, "workflow_id")
-        dedup_key = action.get_dedup_key(workflow_id)
+        dedup_key = action.get_dedup_key()
         previous_action_id = dedup_key_to_action_id.get(dedup_key)
         if previous_action_id is not None:
             dropped[dedup_key].add(previous_action_id)

tests/sentry/workflow_engine/processors/test_action_deduplication.py

@@ -588,7 +588,7 @@ def test_deduplicate_actions_single_action(self) -> None:
         assert result_ids[0] == single_action.id
 
     def test_deduplicate_actions_same_actions_different_workflows(self) -> None:
-        """Test that identical actions from different workflows are NOT deduplicated."""
+        """Test that identical actions from different workflows are deduplicated."""
         # Create two identical Slack actions
         slack_action_1 = self.create_action(
             type=Action.Type.SLACK,
@@ -611,6 +611,8 @@ def test_deduplicate_actions_same_actions_different_workflows(self) -> None:
         )
 
         # Annotate with different workflow IDs
+        # We don't use this, but it is expected to be present,
+        # so this mostly confirms we don't use it for deduplication.
         actions_queryset = Action.objects.filter(
             id__in=[slack_action_1.id, slack_action_2.id]
         ).annotate(
@@ -623,8 +625,6 @@ def test_deduplicate_actions_same_actions_different_workflows(self) -> None:
 
         result = get_unique_active_actions(actions_queryset, self.group)
 
-        # Both actions should remain since they're from different workflows
+        # Only one action should remain; we don't take workflow into account for deduplication
         result_ids = list(result.values_list("id", flat=True))
-        assert len(result_ids) == 2
-        assert slack_action_1.id in result_ids
-        assert slack_action_2.id in result_ids
+        assert len(result_ids) == 1

tests/sentry/workflow_engine/processors/test_workflow.py

@@ -427,7 +427,7 @@ def test_workflow_fire_history_with_action_deduping(
         process_workflows(self.batch_client, self.event_data, FROZEN_TIME)
 
         assert WorkflowFireHistory.objects.count() == 3
-        assert mock_trigger_action.call_count == 3
+        assert mock_trigger_action.call_count == 1
 
     def test_uses_issue_stream_workflows(self) -> None:
         issue_occurrence = self.build_occurrence()