ref(emails): Update perf issue email subject (#40072)

Update the default email subject line for performance issues to be the
short id + issue type rather than the short id + title.

Author: ceorourke

src/sentry/eventstore/models.py

@@ -20,6 +20,7 @@
 from sentry.models import EventDict
 from sentry.snuba.events import Column, Columns
 from sentry.spans.grouping.api import load_span_grouping_config
+from sentry.types.issues import GROUP_TYPE_TO_TEXT, GroupCategory
 from sentry.utils import json
 from sentry.utils.cache import memoize
 from sentry.utils.canonical import CanonicalKeyView
@@ -495,6 +496,8 @@ def get_email_subject(self) -> str:
         template = self.project.get_option("mail:subject_template")
         if template:
             template = EventSubjectTemplate(template)
+        elif self.group.issue_category == GroupCategory.PERFORMANCE:
+            template = EventSubjectTemplate("$shortID - $issueType")
         else:
             template = DEFAULT_SUBJECT_TEMPLATE
         return cast(
@@ -753,6 +756,8 @@ def __getitem__(self, name: str) -> str:
             return cast(str, self.event.organization.slug)
         elif name == "title":
             return self.event.title
+        elif name == "issueType":
+            return cast(str, GROUP_TYPE_TO_TEXT.get(self.event.group.issue_type, "Issue"))
         raise KeyError
 
 

src/sentry/types/issues.py

@@ -29,6 +29,17 @@ class GroupCategory(Enum):
     GroupType.PERFORMANCE_N_PLUS_ONE_DB_QUERIES: GroupCategory.PERFORMANCE,
 }
 
+GROUP_TYPE_TO_TEXT = {
+    GroupType.ERROR: "Error",
+    GroupType.PERFORMANCE_N_PLUS_ONE: "N+1 Query",
+    GroupType.PERFORMANCE_SLOW_SPAN: "Slow Span",
+    GroupType.PERFORMANCE_SEQUENTIAL_SLOW_SPANS: "Sequential Slow Spans",
+    GroupType.PERFORMANCE_LONG_TASK_SPANS: "Long Task Spans",
+    GroupType.PERFORMANCE_RENDER_BLOCKING_ASSET_SPAN: "Render Blocking Asset Span",
+    GroupType.PERFORMANCE_DUPLICATE_SPANS: "Duplicate Spans",
+    GroupType.PERFORMANCE_N_PLUS_ONE_DB_QUERIES: "N+1 DB Queries",
+}
+
 
 def get_category_type_mapping():
     category_type_mapping = defaultdict(list)

tests/sentry/mail/test_actions.py

@@ -186,7 +186,7 @@ def test_full_integration_performance(self):
         assert len(mail.outbox) == 1
         sent = mail.outbox[0]
         assert sent.to == [self.user.email]
-        assert "/country_by_code/" in sent.subject
+        assert "N+1 DB Queries" in sent.subject
 
     # XXX(gilbert): remove this later one
     @mock.patch("sentry.mail.actions.determine_eligible_recipients")

tests/sentry/mail/test_adapter.py

@@ -311,7 +311,7 @@ def test_simple_notification_perf(self):
             self.adapter.notify(notification, ActionTargetType.ISSUE_OWNERS)
 
         msg = mail.outbox[0]
-        assert msg.subject == "[Sentry] BAR-1 - /books/"
+        assert msg.subject == "[Sentry] BAR-1 - N+1 DB Queries"
         checked_values = [
             "Transaction Name",
             # TODO: Not sure if this is right