Skip to content

Commit 1ea6a2e

Browse files
author
David Wang
authored
fix(crons): Add border back to non-sticky timeline header (#54770)
With the change from solid border to translucent box-shadow https://github.com/getsentry/sentry/pull/54399/files we lost the border for the non-sticky timeline header in the issue details page. Adds it back in Before: <img width="908" alt="image" src="https://github.com/getsentry/sentry/assets/9372512/205a14c3-b092-4815-b038-f5afe963ebcf"> After: <img width="917" alt="image" src="https://github.com/getsentry/sentry/assets/9372512/9ae6c602-1a24-45c1-9cd7-f511d15ab308">
1 parent 3bfe952 commit 1ea6a2e

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

static/app/views/monitors/components/overviewTimeline/gridLines.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@ const GridLineContainer = styled('div')`
124124
const LabelsContainer = styled('div')`
125125
position: relative;
126126
align-self: stretch;
127+
border-bottom: 1px solid ${p => p.theme.border};
127128
`;
128129

129130
const Gridline = styled('div')<{left: number}>`

static/app/views/monitors/components/overviewTimeline/index.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export function OverviewTimeline({monitorList}: Props) {
6363
<ResolutionSelector />
6464
</StickyResolutionSelector>
6565
<StickyGridLineTimeLabels>
66-
<GridLineTimeLabels
66+
<BorderlessGridLineTimeLabels
6767
timeWindow={timeWindow}
6868
end={nowRef.current}
6969
width={timelineWidth}
@@ -112,6 +112,11 @@ const StickyResolutionSelector = styled(Sticky)`
112112
}
113113
`;
114114

115+
// We don't need border here because it is already accomplished via box-shadow below
116+
const BorderlessGridLineTimeLabels = styled(GridLineTimeLabels)`
117+
border: none;
118+
`;
119+
115120
const StickyGridLineTimeLabels = styled(Sticky)`
116121
> * {
117122
height: 100%;

0 commit comments

Comments
 (0)