ref(ui): Remove getDynamicText from components (#97808)

scttcper · web-flow · commit 1f4ba8d79c46 · 2025-08-14T10:09:49.000-07:00
Removes calls to getDynamicText from components directory
diff --git a/static/app/components/errorBoundary.tsx b/static/app/components/errorBoundary.tsx
@@ -7,7 +7,6 @@ import DetailedError from 'sentry/components/errors/detailedError';
 import {IconClose} from 'sentry/icons';
 import {t} from 'sentry/locale';
 import {space} from 'sentry/styles/space';
-import getDynamicText from 'sentry/utils/getDynamicText';
 
 type DefaultProps = {
   mini: boolean;
@@ -139,10 +138,7 @@ class ErrorBoundary extends Component<Props, State> {
     return (
       <Wrapper data-test-id="error-boundary">
         <DetailedError
-          heading={getDynamicText({
-            value: getExclamation(),
-            fixed: exclamation[0],
-          })}
+          heading={getExclamation()}
           message={t(
             `Something went horribly wrong rendering this page.
 We use a decent error reporting service so this will probably be fixed soon. Unless our error reporting service is also broken. That would be awkward.
diff --git a/static/app/components/events/eventMetadata.tsx b/static/app/components/events/eventMetadata.tsx
@@ -9,7 +9,6 @@ import {t} from 'sentry/locale';
 import {space} from 'sentry/styles/space';
 import type {Event} from 'sentry/types/event';
 import type {OrganizationSummary} from 'sentry/types/organization';
-import getDynamicText from 'sentry/utils/getDynamicText';
 import Projects from 'sentry/utils/projects';
 
 type Props = {
@@ -30,12 +29,7 @@ function EventMetadata({event, organization, projectId}: Props) {
       <SectionHeading>{t('Event ID')}</SectionHeading>
       <MetadataContainer data-test-id="event-id">{event.eventID}</MetadataContainer>
       <MetadataContainer>
-        <DateTime
-          date={getDynamicText({
-            value: event.dateCreated || (event.endTimestamp || 0) * 1000,
-            fixed: 'Dummy timestamp',
-          })}
-        />
+        <DateTime date={event.dateCreated || (event.endTimestamp || 0) * 1000} />
       </MetadataContainer>
       <Projects orgId={organization.slug} slugs={[projectId]}>
         {({projects}) => {
diff --git a/static/app/components/events/interfaces/breadcrumbs/breadcrumb/time/index.tsx b/static/app/components/events/interfaces/breadcrumbs/breadcrumb/time/index.tsx
@@ -6,7 +6,6 @@ import Highlight from 'sentry/components/highlight';
 import {space} from 'sentry/styles/space';
 import {defined} from 'sentry/utils';
 import {getFormattedTimestamp} from 'sentry/utils/date/getFormattedTimestamp';
-import getDynamicText from 'sentry/utils/getDynamicText';
 
 type Props = {
   searchTerm: string;
@@ -43,10 +42,7 @@ const Time = memo(function Time({
         }
         containerDisplayMode="inline-flex"
       >
-        {getDynamicText({
-          value: <Highlight text={searchTerm}>{displayTime}</Highlight>,
-          fixed: '00:00:00',
-        })}
+        <Highlight text={searchTerm}>{displayTime}</Highlight>
       </Tooltip>
     </Wrapper>
   );
diff --git a/static/app/components/events/interfaces/spans/newTraceDetailsSpanDetails.tsx b/static/app/components/events/interfaces/spans/newTraceDetailsSpanDetails.tsx
@@ -27,7 +27,6 @@ import {defined} from 'sentry/utils';
 import EventView from 'sentry/utils/discover/eventView';
 import {SavedQueryDatasets} from 'sentry/utils/discover/types';
 import {generateEventSlug} from 'sentry/utils/discover/urls';
-import getDynamicText from 'sentry/utils/getDynamicText';
 import {safeURL} from 'sentry/utils/url/safeURL';
 import {useLocation} from 'sentry/utils/useLocation';
 import useProjects from 'sentry/utils/useProjects';
@@ -513,25 +512,15 @@ function NewTraceDetailsSpanDetail(props: SpanDetailProps) {
                 )}
               </Row>
               <Row title={t('Date Range')}>
-                {getDynamicText({
-                  fixed: 'Mar 16, 2020 9:10:12 AM UTC',
-                  value: (
-                    <Fragment>
-                      <DateTime date={startTimestamp * 1000} year seconds timeZone />
-                      {` (${startTimeWithLeadingZero})`}
-                    </Fragment>
-                  ),
-                })}
+                <Fragment>
+                  <DateTime date={startTimestamp * 1000} year seconds timeZone />
+                  {` (${startTimeWithLeadingZero})`}
+                </Fragment>
                 <br />
-                {getDynamicText({
-                  fixed: 'Mar 16, 2020 9:10:13 AM UTC',
-                  value: (
-                    <Fragment>
-                      <DateTime date={endTimestamp * 1000} year seconds timeZone />
-                      {` (${endTimeWithLeadingZero})`}
-                    </Fragment>
-                  ),
-                })}
+                <Fragment>
+                  <DateTime date={endTimestamp * 1000} year seconds timeZone />
+                  {` (${endTimeWithLeadingZero})`}
+                </Fragment>
               </Row>
               <Row title={t('Origin')}>
                 {span.origin === undefined ? null : String(span.origin)}
diff --git a/static/app/components/events/interfaces/spans/spanDetail.tsx b/static/app/components/events/interfaces/spans/spanDetail.tsx
@@ -39,7 +39,6 @@ import {trackAnalytics} from 'sentry/utils/analytics';
 import EventView from 'sentry/utils/discover/eventView';
 import {SavedQueryDatasets} from 'sentry/utils/discover/types';
 import {generateEventSlug} from 'sentry/utils/discover/urls';
-import getDynamicText from 'sentry/utils/getDynamicText';
 import type {
   QuickTraceEvent,
   TraceErrorOrIssue,
@@ -513,26 +512,16 @@ function SpanDetail(props: Props) {
               </Row>
               <Row title="Status">{span.status || ''}</Row>
               <Row title="Start Date">
-                {getDynamicText({
-                  fixed: 'Mar 16, 2020 9:10:12 AM UTC',
-                  value: (
-                    <Fragment>
-                      <DateTime date={startTimestamp * 1000} year seconds timeZone />
-                      {` (${startTimeWithLeadingZero})`}
-                    </Fragment>
-                  ),
-                })}
+                <Fragment>
+                  <DateTime date={startTimestamp * 1000} year seconds timeZone />
+                  {` (${startTimeWithLeadingZero})`}
+                </Fragment>
               </Row>
               <Row title="End Date">
-                {getDynamicText({
-                  fixed: 'Mar 16, 2020 9:10:13 AM UTC',
-                  value: (
-                    <Fragment>
-                      <DateTime date={endTimestamp * 1000} year seconds timeZone />
-                      {` (${endTimeWithLeadingZero})`}
-                    </Fragment>
-                  ),
-                })}
+                <Fragment>
+                  <DateTime date={endTimestamp * 1000} year seconds timeZone />
+                  {` (${endTimeWithLeadingZero})`}
+                </Fragment>
               </Row>
               <Row title="Duration">{durationString}</Row>
               <Row title="Operation">{span.op || ''}</Row>
diff --git a/static/app/components/fileSize.tsx b/static/app/components/fileSize.tsx
@@ -2,7 +2,6 @@ import styled from '@emotion/styled';
 
 import {formatBytesBase2} from 'sentry/utils/bytes/formatBytesBase2';
 import {formatBytesBase10} from 'sentry/utils/bytes/formatBytesBase10';
-import getDynamicText from 'sentry/utils/getDynamicText';
 
 type Props = {
   bytes: number;
@@ -15,10 +14,7 @@ function FileSize(props: Props) {
 
   return (
     <Span className={className}>
-      {getDynamicText({
-        value: base === 10 ? formatBytesBase10(bytes) : formatBytesBase2(bytes),
-        fixed: 'xx KB',
-      })}
+      {base === 10 ? formatBytesBase10(bytes) : formatBytesBase2(bytes)}
     </Span>
   );
 }
diff --git a/static/app/components/footer.tsx b/static/app/components/footer.tsx
@@ -9,7 +9,6 @@ import {t} from 'sentry/locale';
 import ConfigStore from 'sentry/stores/configStore';
 import {useLegacyStore} from 'sentry/stores/useLegacyStore';
 import {space} from 'sentry/styles/space';
-import getDynamicText from 'sentry/utils/getDynamicText';
 import useOrganization from 'sentry/utils/useOrganization';
 
 type SentryLogoProps = SVGIconProps & {
@@ -42,16 +41,8 @@ function BaseFooter({className}: Props) {
         {isSelfHosted && (
           <Fragment>
             {'Sentry '}
-            {getDynamicText({
-              fixed: 'Acceptance Test',
-              value: version.current,
-            })}
-            <Build>
-              {getDynamicText({
-                fixed: 'test',
-                value: version.build.substring(0, 7),
-              })}
-            </Build>
+            {version.current}
+            <Build>{version.build.substring(0, 7)}</Build>
           </Fragment>
         )}
         {privacyUrl && <FooterLink href={privacyUrl}>{t('Privacy Policy')}</FooterLink>}
diff --git a/static/app/components/group/inboxBadges/timesTag.tsx b/static/app/components/group/inboxBadges/timesTag.tsx
@@ -4,7 +4,6 @@ import TimeSince from 'sentry/components/timeSince';
 import {IconClock} from 'sentry/icons';
 import {t} from 'sentry/locale';
 import {space} from 'sentry/styles/space';
-import getDynamicText from 'sentry/utils/getDynamicText';
 
 /**
  * Used in new inbox
@@ -21,34 +20,26 @@ function TimesTag({lastSeen, firstSeen}: Props) {
   return (
     <Wrapper>
       <StyledIconClock size="xs" color="gray300" />
-      {lastSeen &&
-        getDynamicText({
-          value: (
-            <TimeSince
-              tooltipPrefix={t('Last Seen')}
-              date={lastSeen}
-              suffix={t('ago')}
-              unitStyle="short"
-            />
-          ),
-          fixed: '10s ago',
-        })}
+      {lastSeen && (
+        <TimeSince
+          tooltipPrefix={t('Last Seen')}
+          date={lastSeen}
+          suffix={t('ago')}
+          unitStyle="short"
+        />
+      )}
       {firstSeen && lastSeen && (
         <Separator className="hidden-xs hidden-sm">&nbsp;|&nbsp;</Separator>
       )}
-      {firstSeen &&
-        getDynamicText({
-          value: (
-            <TimeSince
-              tooltipPrefix={t('First Seen')}
-              date={firstSeen}
-              suffix={t('old')}
-              className="hidden-xs hidden-sm"
-              unitStyle="short"
-            />
-          ),
-          fixed: '10s old',
-        })}
+      {firstSeen && (
+        <TimeSince
+          tooltipPrefix={t('First Seen')}
+          date={firstSeen}
+          suffix={t('old')}
+          className="hidden-xs hidden-sm"
+          unitStyle="short"
+        />
+      )}
     </Wrapper>
   );
 }
diff --git a/static/app/components/group/releaseStats.tsx b/static/app/components/group/releaseStats.tsx
@@ -15,7 +15,6 @@ import type {Organization} from 'sentry/types/organization';
 import type {Project} from 'sentry/types/project';
 import type {CurrentRelease, Release} from 'sentry/types/release';
 import {defined} from 'sentry/utils';
-import getDynamicText from 'sentry/utils/getDynamicText';
 import {useApiQuery} from 'sentry/utils/queryClient';
 
 type Props = {
@@ -121,10 +120,7 @@ function GroupReleaseStats({
                   organization={organization}
                   projectId={projectId}
                   projectSlug={projectSlug}
-                  date={getDynamicText({
-                    value: group.lastSeen,
-                    fixed: '2016-01-13T03:08:25Z',
-                  })}
+                  date={group.lastSeen}
                   dateGlobal={allEnvironments.lastSeen}
                   environment={shortEnvironmentLabel}
                   release={lastRelease}
@@ -144,10 +140,7 @@ function GroupReleaseStats({
                   organization={organization}
                   projectId={projectId}
                   projectSlug={projectSlug}
-                  date={getDynamicText({
-                    value: group.firstSeen,
-                    fixed: '2015-08-13T03:08:25Z',
-                  })}
+                  date={group.firstSeen}
                   dateGlobal={allEnvironments.firstSeen}
                   environment={shortEnvironmentLabel}
                   release={firstRelease}
diff --git a/static/app/components/timeSince.tsx b/static/app/components/timeSince.tsx
@@ -6,7 +6,6 @@ import type {TooltipProps} from 'sentry/components/core/tooltip';
 import {Tooltip} from 'sentry/components/core/tooltip';
 import {t} from 'sentry/locale';
 import getDuration from 'sentry/utils/duration/getDuration';
-import getDynamicText from 'sentry/utils/getDynamicText';
 import type {ColorOrAlias} from 'sentry/utils/theme';
 import {useUser} from 'sentry/utils/useUser';
 
@@ -160,12 +159,7 @@ function TimeSince({
     : 'MMMM D, YYYY h:mm A z';
   const format = options?.clock24Hours ? 'MMMM D, YYYY HH:mm z' : tooltipFormat;
 
-  const tooltip = getDynamicText({
-    fixed: options?.clock24Hours
-      ? 'November 3, 2020 08:57 UTC'
-      : 'November 3, 2020 8:58 AM UTC',
-    value: moment(dateObj).format(format),
-  });
+  const tooltip = moment(dateObj).format(format);
 
   return (
     <Tooltip
