Skip to content

Commit 1f6a9d6

Browse files
authored
fix(trace-navigator): Trace not found alert dismiss button (#28056)
The component is not updating when the state changes. This ensures to check that when the state changes from the dismiss button, the alert is removed.
1 parent 2e01b2d commit 1f6a9d6

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

static/app/views/organizationGroupDetails/quickTrace/issueQuickTrace.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,11 @@ class IssueQuickTrace extends Component<Props, State> {
4242
this.promptsCheck();
4343
}
4444

45-
shouldComponentUpdate(nextProps) {
46-
return this.props.event !== nextProps.event;
45+
shouldComponentUpdate(nextProps, nextState: State) {
46+
return (
47+
this.props.event !== nextProps.event ||
48+
this.state.shouldShow !== nextState.shouldShow
49+
);
4750
}
4851

4952
async promptsCheck() {

0 commit comments

Comments
 (0)