ref(uptime): {scheduled -> actual}_check_time_us for trace (#97793)

Author: evanpurkhiser

src/sentry/snuba/trace.py

@@ -360,7 +360,7 @@ def _serialize_columnar_uptime_item(
         row_dict["http_status_code"].val_int if "http_status_code" in row_dict else None
     )
     request_url = row_dict["request_url"].val_str
-    scheduled_check_time_us = row_dict["scheduled_check_time_us"].val_int
+    actual_check_time_us = row_dict["actual_check_time_us"].val_int
     check_duration_us = (
         row_dict["check_duration_us"].val_int if "check_duration_us" in row_dict else 0
     )
@@ -412,8 +412,8 @@ def get_value(attr_name: str, attr_value: AttributeValue):
             if resolved_val is not None:
                 additional_attrs[resolved_column.public_alias] = resolved_val
 
-    span["start_timestamp"] = scheduled_check_time_us / 1_000_000
-    span["end_timestamp"] = (scheduled_check_time_us + check_duration_us) / 1_000_000
+    span["start_timestamp"] = actual_check_time_us / 1_000_000
+    span["end_timestamp"] = (actual_check_time_us + check_duration_us) / 1_000_000
     span["duration"] = check_duration_us / 1_000.0
     description = f"Uptime Check [{check_status}] - {request_url}"
     if http_status_code:

tests/snuba/api/endpoints/test_organization_trace.py

@@ -41,7 +41,7 @@ def test_basic_uptime_item_serialization(self):
             "http_status_code": ProtoAttributeValue(val_int=200),
             "request_url": ProtoAttributeValue(val_str="https://example.com"),
             "original_url": ProtoAttributeValue(val_str="https://example.com"),
-            "scheduled_check_time_us": ProtoAttributeValue(val_int=1700000000000000),
+            "actual_check_time_us": ProtoAttributeValue(val_int=1700000000000000),
             "check_duration_us": ProtoAttributeValue(val_int=500000),
             "subscription_id": ProtoAttributeValue(val_str="sub-456"),
             "region": ProtoAttributeValue(val_str="us-east-1"),
@@ -86,7 +86,7 @@ def test_redirect_chain_serialization(self):
             "http_status_code": ProtoAttributeValue(val_int=301),
             "request_url": ProtoAttributeValue(val_str="https://www.example.com"),
             "original_url": ProtoAttributeValue(val_str="https://example.com"),
-            "scheduled_check_time_us": ProtoAttributeValue(val_int=1700000000000000),
+            "actual_check_time_us": ProtoAttributeValue(val_int=1700000000000000),
             "check_duration_us": ProtoAttributeValue(val_int=300000),
             "request_sequence": ProtoAttributeValue(val_int=1),
         }
@@ -109,7 +109,7 @@ def test_null_and_missing_fields(self):
             "check_status": ProtoAttributeValue(val_str="failure"),
             "http_status_code": ProtoAttributeValue(is_null=True),
             "request_url": ProtoAttributeValue(val_str="https://test.com"),
-            "scheduled_check_time_us": ProtoAttributeValue(val_int=1700000000000000),
+            "actual_check_time_us": ProtoAttributeValue(val_int=1700000000000000),
             "dns_lookup_duration_us": ProtoAttributeValue(val_int=50000),
             "tcp_connection_duration_us": ProtoAttributeValue(is_null=True),
         }