Skip to content

Commit 22d79a3

Browse files
authored
ref(issue-list): Create copy of overview.tsx as a functional component (#82935)
Same as #82784 which got reverted, with the addition of a type failure fix. Adds a copy of overview.tsx (and tests) that is a functional component. I mostly copied it 1 for 1, so the resulting component is not much better than the original. We need a starting place first to start making more improvements. This new component is only rendered if the issue-stream-functional-refactor flag is enabled. We will test this internally before rolling out more widely and deleting the original to reduce risk. The most significant changes were around data fetching and caching, since converting things to useEffects resulted in some bugs and test failures that the original lifecycle methods managed to avoid somehow. For example, we are now using the requestParams object to determine if we should refetch instead of checking against previous props for everything individually. I have also removed issue-stream-performance checks in this version of the component since that complicated things significantly.
1 parent 1e4ea5b commit 22d79a3

File tree

4 files changed

+2676
-3
lines changed

4 files changed

+2676
-3
lines changed

static/app/routes.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import {ModuleName} from 'sentry/views/insights/types';
2525
import {GroupEventDetailsLoading} from 'sentry/views/issueDetails/groupEventDetails/groupEventDetailsLoading';
2626
import {Tab, TabPaths} from 'sentry/views/issueDetails/types';
2727
import IssueListContainer from 'sentry/views/issueList';
28-
import IssueListOverview from 'sentry/views/issueList/overview';
28+
import {OverviewWrapper} from 'sentry/views/issueList/overviewWrapper';
2929
import OrganizationContainer from 'sentry/views/organizationContainer';
3030
import OrganizationLayout from 'sentry/views/organizationLayout';
3131
import OrganizationRoot from 'sentry/views/organizationRoot';
@@ -1903,8 +1903,8 @@ function buildRoutes() {
19031903

19041904
const issueListRoutes = (
19051905
<Route path="/issues" component={errorHandler(IssueListContainer)} withOrgPath>
1906-
<IndexRoute component={errorHandler(IssueListOverview)} />
1907-
<Route path="searches/:searchId/" component={errorHandler(IssueListOverview)} />
1906+
<IndexRoute component={errorHandler(OverviewWrapper)} />
1907+
<Route path="searches/:searchId/" component={errorHandler(OverviewWrapper)} />
19081908
</Route>
19091909
);
19101910

0 commit comments

Comments
 (0)