Merge pull request #5022 from getsentry/bugfix/releases

Permit almost anything for releases again

Author: mitsuhiko

src/sentry/api/endpoints/project_releases.py

@@ -16,6 +16,9 @@
 from sentry.utils.apidocs import scenario, attach_scenarios
 
 
+BAD_RELEASE_CHARS = '\n\f\t/'
+
+
 @scenario('CreateNewRelease')
 def create_new_release_scenario(runner):
     runner.request(
@@ -42,15 +45,20 @@ def list_releases_scenario(runner):
 
 
 class ReleaseSerializer(serializers.Serializer):
-    version = serializers.RegexField(r'^[a-zA-Z0-9\-_\. \(\)]+\Z',
-                                     max_length=64, required=True)
+    version = serializers.CharField(max_length=64, required=True)
     ref = serializers.CharField(max_length=64, required=False)
     url = serializers.URLField(required=False)
     owner = UserField(required=False)
     dateStarted = serializers.DateTimeField(required=False)
     dateReleased = serializers.DateTimeField(required=False)
     commits = ListField(child=CommitSerializer(), required=False)
 
+    def validate_version(self, attrs, source):
+        value = attrs[source]
+        if any(c in value for c in BAD_RELEASE_CHARS) or value in ('.', '..'):
+            raise serializers.ValidationError('Invalid value for release')
+        return attrs
+
 
 class ProjectReleasesEndpoint(ProjectEndpoint):
     doc_section = DocSection.RELEASES

tests/sentry/api/endpoints/test_organization_releases.py

@@ -344,11 +344,11 @@ def test_version_whitespace(self):
         assert response.status_code == 400, response.content
 
         response = self.client.post(url, data={
-            'version': '1.2.3',
+            'version': '1.2.3+dev',
             'projects': [project.slug]
         })
         assert response.status_code == 201, response.content
-        assert response.data['version'] == '1.2.3'
+        assert response.data['version'] == '1.2.3+dev'
 
         release = Release.objects.get(
             organization_id=org.id,