Skip to content

Commit 23837cd

Browse files
Abdkhan14Abdullah Khan
andauthored
feat(trace-eap-waterfall): Show header for only logs trace view (#97487)
- We shouldn't be rendering the placeholder when there are no spans but some logs in the trace view. Co-authored-by: Abdullah Khan <[email protected]>
1 parent fb46556 commit 23837cd

File tree

1 file changed

+7
-1
lines changed
  • static/app/views/performance/newTraceDetails/traceHeader

1 file changed

+7
-1
lines changed

static/app/views/performance/newTraceDetails/traceHeader/index.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import {PlaceHolder} from 'sentry/views/performance/newTraceDetails/traceHeader/
2222
import Projects from 'sentry/views/performance/newTraceDetails/traceHeader/projects';
2323
import {TraceHeaderComponents} from 'sentry/views/performance/newTraceDetails/traceHeader/styles';
2424
import type {TraceTree} from 'sentry/views/performance/newTraceDetails/traceModels/traceTree';
25+
import {useTraceContextSections} from 'sentry/views/performance/newTraceDetails/useTraceContextSections';
2526

2627
import {getTraceViewBreadcrumbs} from './breadcrumbs';
2728
import {Meta} from './meta';
@@ -43,6 +44,10 @@ export function TraceMetaDataHeader(props: TraceMetadataHeaderProps) {
4344
const {view} = useDomainViewFilters();
4445
const moduleURLBuilder = useModuleURLBuilder(true);
4546
const {projects} = useProjects();
47+
const {hasLogs} = useTraceContextSections({
48+
tree: props.tree,
49+
logs: props.logs,
50+
});
4651

4752
const isLoading =
4853
props.metaResults.status === 'pending' ||
@@ -54,7 +59,8 @@ export function TraceMetaDataHeader(props: TraceMetadataHeaderProps) {
5459
props.rootEventResults.status === 'error' ||
5560
props.tree.type === 'error';
5661

57-
if (isLoading || isError || props.tree.type === 'empty') {
62+
const noEvents = props.tree.type === 'empty' && !hasLogs;
63+
if (isLoading || isError || noEvents) {
5864
return <PlaceHolder organization={props.organization} traceSlug={props.traceSlug} />;
5965
}
6066

0 commit comments

Comments
 (0)