feat(grouping): Allow grouping by NSError (#23794)

Author: mitsuhiko

src/sentry/grouping/strategies/newstyle.py

@@ -432,10 +432,23 @@ def single_exception(exception, context, **meta):
         similarity_encoder=ident_encoder,
     )
 
-    if exception.mechanism and exception.mechanism.synthetic:
-        type_component.update(contributes=False, hint="ignored because exception is synthetic")
+    ns_error_component = None
+
+    if exception.mechanism:
+        if exception.mechanism.synthetic:
+            type_component.update(contributes=False, hint="ignored because exception is synthetic")
+        if exception.mechanism.meta and "ns_error" in exception.mechanism.meta:
+            ns_error_component = GroupingComponent(
+                id="ns-error",
+                values=[
+                    exception.mechanism.meta["ns_error"].get("domain"),
+                    exception.mechanism.meta["ns_error"].get("code"),
+                ],
+            )
 
     values = [stacktrace_component, type_component]
+    if ns_error_component is not None:
+        values.append(ns_error_component)
 
     if context["with_exception_value_fallback"]:
         value_component = GroupingComponent(id="value", similarity_encoder=text_shingle_encoder(5))
@@ -453,6 +466,16 @@ def single_exception(exception, context, **meta):
                 contributes_to_similarity=True,
                 hint="ignored because stacktrace takes precedence",
             )
+        if (
+            ns_error_component is not None
+            and ns_error_component.contributes
+            and value_component.contributes
+        ):
+            value_component.update(
+                contributes=False,
+                contributes_to_similarity=True,
+                hint="ignored because ns-error info takes precedence",
+            )
 
         values.append(value_component)