Merge pull request #2598 from getsentry/assignee-emails

Fix assignment notifications.

Author: ted kaemming

src/sentry/plugins/sentry_mail/models.py

@@ -244,7 +244,7 @@ def notify_about_activity(self, activity):
 
         if activity.type == Activity.ASSIGNED:
             # Only notify the assignee, and only if they are in the candidate set.
-            recipient_ids = candidate_ids & set((activity.data['assignee'],))
+            recipient_ids = candidate_ids & set(map(int, (activity.data['assignee'],)))
         elif activity.type == Activity.NOTE:
             recipient_ids = candidate_ids - set(
                 UserOption.objects.filter(

tests/sentry/plugins/mail/tests.py

@@ -263,6 +263,26 @@ def test_notify_digest_single_record(self, send, notify):
         assert send.call_count is 1
         assert notify.call_count is 1
 
+    def test_assignment(self):
+        activity = Activity.objects.create(
+            project=self.project,
+            group=self.group,
+            type=Activity.ASSIGNED,
+            user=self.create_user('[email protected]'),
+            data={
+                'assignee': str(self.user.id),
+            },
+        )
+
+        self.plugin.notify_about_activity(activity)
+
+        assert len(mail.outbox) == 1
+
+        msg = mail.outbox[0]
+
+        assert msg.subject == 'Re: [Sentry] [foo Bar] ERROR: Foo bar'
+        assert msg.to == [self.user.email]
+
     def test_note(self):
         user_foo = self.create_user('[email protected]')