Commit 2d6bf0d
authored
ref: growing input is no more (#86553)
All bow to useAutosizeInput and `<Input autosize/>`
I have opted to use <Input autosize as opposed to requiring everyone to
call the hook, as this allows us to ensure that the hook is correctly
called (value is required depending on if the input is controlled or
not), meaning that we can reduce the possible bug surface.
https://github.com/user-attachments/assets/a321da42-e648-42c7-ad94-e885ba99bb12
The PR is missing tests, I had started to write some and realized mid
way that I will have to mock pretty much all of the window styles
methods, defeating the purpose of the tests (I will give that another
go)
The GrowingInput component was also hiding a bug that caused react to
not throw warnings in development when only the value prop was provided
as it was providing its own onchange handler and then calling
`props.onChange?.()` which was always falsy
**Below** is what I originally typed into the draft PR and explains the
reasoning for ^ decision more in depth.
The question now is, do we expose this via hook, or do we build it into
the Input via autosize prop like `<Input autosize/>`? I think I am
leaning towards autosize prop as I believe it is more intuitive than
consuming a hook (which could still be exposed).
If we require users to call the hook, then the API would look something
like
```tsx
function Component() {
const ref = useAutosizeInput({value})
return <Input ref={ref}/>
}
```
The awkward part is that exposing it like this could that the DOM
structure could depend on the autosize prop (provided would use the CSS
only approach that @natemoo-re shared, which requires a wrapper
component). An alternative could be to add autosize to InputGroup and
require the prop to be set there, but that feels weird, as the autosize
input should be set on the input itself, and making InputGroup a
requirement for autosize to work feels sub-optimal.
```tsx
function Component(){
return (
<InputGroup autosize> // <- this feels weird, but also means that standalone inputs dont support autosize?
<InputGroup.Input/>
</InputGroup>
}
```
Finally, and the version that I am most leaning towards is to expose
this as an autosize bool prop on Input, and use the current JS handler
to measure resizing. This way, we can also ensure that the hook is
correctly called with the value props if the component is controlled,
and hide that last bit of complexity from the user (provided we dont use
the pure CSS solution for now)
```tsx
function Component() {
return <Input autosize/>
}
```
@natemoo-re @TkDodo @evanpurkhiser or anyone else reading this, feedback
and opinions would be much appreciated1 parent c153061 commit 2d6bf0d
File tree
8 files changed
+237
-229
lines changed- static/app
- components
- core/input
- searchQueryBuilder/tokens
- tokenizedInput/token
- views/issueList
8 files changed
+237
-229
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
| |||
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
32 | 33 | | |
33 | 34 | | |
34 | 35 | | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
35 | 39 | | |
36 | 40 | | |
37 | 41 | | |
| |||
41 | 45 | | |
42 | 46 | | |
43 | 47 | | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
48 | 57 | | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
54 | 139 | | |
55 | 140 | | |
56 | 141 | | |
57 | 142 | | |
58 | 143 | | |
59 | 144 | | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
60 | 151 | | |
61 | 152 | | |
62 | | - | |
| 153 | + | |
| 154 | + | |
63 | 155 | | |
64 | 156 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
This file was deleted.
This file was deleted.
0 commit comments