ref(issues): Move multiple endpoints and tests to issues folder (#97428)

JoshFerge · andrewshie-sentry · commit 3242405bc511 · 2025-08-12T15:18:20.000-07:00
## Summary Move multiple issue-related endpoints and the `issue_search` module from the API package to the issues package to better organize the codebase. ### Files Moved: **Endpoints:** - `group_attachments.py` - `team_all_unresolved_issues.py` - `team_issue_breakdown.py` - `organization_event_details.py` - `organization_issues_resolved_in_release.py` - `issue_search.py` (module) **Tests:** - `test_group_attachments.py` - `test_team_all_unresolved_issues.py` - `test_team_issue_breakdown.py` - `test_issue_search.py` ### Changes: - Updated all import references in `src/sentry/api/urls.py` - Updated imports in affected source files and tests - Maintained all existing functionality - Added proper type annotations to moved test files refs https://linear.app/getsentry/issue/RTC-1110/move-issues-endpoints-into-issues-app
diff --git a/pyproject.toml b/pyproject.toml
@@ -354,7 +354,6 @@ module = [
     "sentry.api.endpoints.project_repo_path_parsing",
     "sentry.api.endpoints.project_rules_configuration",
     "sentry.api.endpoints.release_thresholds.health_checks.*",
-    "sentry.api.endpoints.team_issue_breakdown",
     "sentry.api.event_search",
     "sentry.api.helpers.deprecation",
     "sentry.api.helpers.environments",
@@ -481,6 +480,7 @@ module = [
     "sentry.issues.endpoints.source_map_debug",
     "sentry.issues.endpoints.team_all_unresolved_issues",
     "sentry.issues.endpoints.team_groups_old",
+    "sentry.issues.endpoints.team_issue_breakdown",
     "sentry.issues.escalating.escalating",
     "sentry.issues.escalating.escalating_group_forecast",
     "sentry.issues.escalating.escalating_issues_alg",
diff --git a/src/sentry/api/helpers/group_index/index.py b/src/sentry/api/helpers/group_index/index.py
@@ -14,10 +14,10 @@
 from sentry import features, search
 from sentry.api.event_search import AggregateFilter, SearchFilter
 from sentry.api.helpers.environments import get_environment
-from sentry.api.issue_search import convert_query_values, parse_search_query
 from sentry.api.serializers import serialize
 from sentry.constants import DEFAULT_SORT_OPTION
 from sentry.exceptions import InvalidSearchQuery
+from sentry.issues.issue_search import convert_query_values, parse_search_query
 from sentry.models.environment import Environment
 from sentry.models.group import Group, looks_like_short_id
 from sentry.models.organization import Organization
diff --git a/src/sentry/api/serializers/rest_framework/dashboard.py b/src/sentry/api/serializers/rest_framework/dashboard.py
@@ -12,12 +12,12 @@
 from rest_framework import serializers
 
 from sentry import features, options
-from sentry.api.issue_search import parse_search_query
 from sentry.api.serializers.rest_framework import CamelSnakeSerializer
 from sentry.api.serializers.rest_framework.base import convert_dict_key_case, snake_to_camel_case
 from sentry.constants import ALL_ACCESS_PROJECTS
 from sentry.discover.arithmetic import ArithmeticError, categorize_columns
 from sentry.exceptions import InvalidSearchQuery
+from sentry.issues.issue_search import parse_search_query
 from sentry.models.dashboard import Dashboard
 from sentry.models.dashboard_permissions import DashboardPermissions
 from sentry.models.dashboard_widget import (
diff --git a/src/sentry/api/urls.py b/src/sentry/api/urls.py
@@ -275,6 +275,7 @@
     TeamGroupsOldEndpoint,
 )
 from sentry.issues.endpoints.browser_reporting_collector import BrowserReportingCollectorEndpoint
+from sentry.issues.endpoints.group_attachments import GroupAttachmentsEndpoint
 from sentry.issues.endpoints.group_current_release import GroupCurrentReleaseEndpoint
 from sentry.issues.endpoints.group_first_last_release import GroupFirstLastReleaseEndpoint
 from sentry.issues.endpoints.group_integration_details import GroupIntegrationDetailsEndpoint
@@ -289,6 +290,7 @@
 from sentry.issues.endpoints.organization_codeowners_associations import (
     OrganizationCodeOwnersAssociationsEndpoint,
 )
+from sentry.issues.endpoints.organization_event_details import OrganizationEventDetailsEndpoint
 from sentry.issues.endpoints.organization_group_search_view_starred_order import (
     OrganizationGroupSearchViewStarredOrderEndpoint,
 )
@@ -299,7 +301,11 @@
     OrganizationGroupSuspectTagsEndpoint,
 )
 from sentry.issues.endpoints.organization_issue_metrics import OrganizationIssueMetricsEndpoint
+from sentry.issues.endpoints.organization_issues_resolved_in_release import (
+    OrganizationIssuesResolvedInReleaseEndpoint,
+)
 from sentry.issues.endpoints.team_all_unresolved_issues import TeamAllUnresolvedIssuesEndpoint
+from sentry.issues.endpoints.team_issue_breakdown import TeamIssueBreakdownEndpoint
 from sentry.monitors.endpoints.organization_monitor_checkin_index import (
     OrganizationMonitorCheckInIndexEndpoint,
 )
@@ -561,7 +567,6 @@
 from .endpoints.event_owners import EventOwnersEndpoint
 from .endpoints.event_reprocessable import EventReprocessableEndpoint
 from .endpoints.filechange import CommitFileChangeEndpoint
-from .endpoints.group_attachments import GroupAttachmentsEndpoint
 from .endpoints.index import IndexEndpoint
 from .endpoints.internal import (
     InternalBeaconEndpoint,
@@ -585,7 +590,6 @@
 from .endpoints.organization_auth_provider_details import OrganizationAuthProviderDetailsEndpoint
 from .endpoints.organization_auth_providers import OrganizationAuthProvidersEndpoint
 from .endpoints.organization_config_repositories import OrganizationConfigRepositoriesEndpoint
-from .endpoints.organization_event_details import OrganizationEventDetailsEndpoint
 from .endpoints.organization_events import OrganizationEventsEndpoint
 from .endpoints.organization_events_facets import OrganizationEventsFacetsEndpoint
 from .endpoints.organization_events_facets_performance import (
@@ -621,9 +625,6 @@
 )
 from .endpoints.organization_events_trends_v2 import OrganizationEventsNewTrendsStatsEndpoint
 from .endpoints.organization_events_vitals import OrganizationEventsVitalsEndpoint
-from .endpoints.organization_issues_resolved_in_release import (
-    OrganizationIssuesResolvedInReleaseEndpoint,
-)
 from .endpoints.organization_measurements_meta import OrganizationMeasurementsMeta
 from .endpoints.organization_member import (
     OrganizationInviteRequestDetailsEndpoint,
@@ -758,7 +759,6 @@
 from .endpoints.setup_wizard import SetupWizard
 from .endpoints.system_health import SystemHealthEndpoint
 from .endpoints.system_options import SystemOptionsEndpoint
-from .endpoints.team_issue_breakdown import TeamIssueBreakdownEndpoint
 from .endpoints.user_organizationintegrations import UserOrganizationIntegrationsEndpoint
 from .endpoints.user_organizations import UserOrganizationsEndpoint
 from .endpoints.user_subscriptions import UserSubscriptionsEndpoint
diff --git a/src/sentry/issues/endpoints/group_attachments.py b/src/sentry/issues/endpoints/group_attachments.py
diff --git a/src/sentry/issues/endpoints/organization_event_details.py b/src/sentry/issues/endpoints/organization_event_details.py
diff --git a/src/sentry/issues/endpoints/organization_issues_count.py b/src/sentry/issues/endpoints/organization_issues_count.py
@@ -10,9 +10,9 @@
 from sentry.api.bases.organization import OrganizationEndpoint
 from sentry.api.helpers.group_index import validate_search_filter_permissions
 from sentry.api.helpers.group_index.validators import ValidationError
-from sentry.api.issue_search import convert_query_values, parse_search_query
 from sentry.api.utils import get_date_range_from_params
 from sentry.exceptions import InvalidParams
+from sentry.issues.issue_search import convert_query_values, parse_search_query
 from sentry.models.organization import Organization
 from sentry.organizations.services.organization.model import RpcOrganization
 from sentry.snuba import discover
diff --git a/src/sentry/issues/endpoints/organization_issues_resolved_in_release.py b/src/sentry/issues/endpoints/organization_issues_resolved_in_release.py
diff --git a/src/sentry/issues/endpoints/team_issue_breakdown.py b/src/sentry/issues/endpoints/team_issue_breakdown.py
diff --git a/src/sentry/issues/issue_search.py b/src/sentry/issues/issue_search.py
diff --git a/src/sentry/search/events/builder/errors.py b/src/sentry/search/events/builder/errors.py
@@ -17,7 +17,7 @@
     Request,
 )
 
-from sentry.api.issue_search import convert_query_values, convert_status_value
+from sentry.issues.issue_search import convert_query_values, convert_status_value
 from sentry.search.events.builder.discover import (
     DiscoverQueryBuilder,
     TimeseriesQueryBuilder,
diff --git a/src/sentry/workflow_engine/endpoints/organization_detector_index.py b/src/sentry/workflow_engine/endpoints/organization_detector_index.py
@@ -19,7 +19,6 @@
 from sentry.api.event_search import SearchConfig, SearchFilter, SearchKey, default_config
 from sentry.api.event_search import parse_search_query as base_parse_search_query
 from sentry.api.exceptions import ResourceDoesNotExist
-from sentry.api.issue_search import convert_actor_or_none_value
 from sentry.api.paginator import OffsetPaginator
 from sentry.api.serializers import serialize
 from sentry.apidocs.constants import (
@@ -35,6 +34,7 @@
 from sentry.deletions.models.scheduleddeletion import RegionScheduledDeletion
 from sentry.incidents.grouptype import MetricIssue
 from sentry.issues import grouptype
+from sentry.issues.issue_search import convert_actor_or_none_value
 from sentry.models.organization import Organization
 from sentry.models.project import Project
 from sentry.models.team import Team
diff --git a/tests/sentry/api/helpers/test_group_index.py b/tests/sentry/api/helpers/test_group_index.py
@@ -17,9 +17,9 @@
     handle_is_subscribed,
 )
 from sentry.api.helpers.group_index.validators import ValidationError
-from sentry.api.issue_search import parse_search_query
 from sentry.api.serializers import serialize
 from sentry.api.serializers.models.group import GroupSerializer
+from sentry.issues.issue_search import parse_search_query
 from sentry.models.activity import Activity
 from sentry.models.group import Group, GroupStatus
 from sentry.models.groupassignee import GroupAssignee
diff --git a/tests/sentry/issues/endpoints/test_group_attachments.py b/tests/sentry/issues/endpoints/test_group_attachments.py
@@ -1,3 +1,4 @@
+from collections.abc import Sequence
 from urllib.parse import urlencode
 
 from sentry.models.eventattachment import EventAttachment
@@ -9,7 +10,13 @@
 
 
 class GroupEventAttachmentsTest(APITestCase):
-    def create_attachment(self, type=None, event_id=None, file_name="hello.png", group_id=None):
+    def create_attachment(
+        self,
+        type: str | None = None,
+        event_id: str | None = None,
+        file_name: str = "hello.png",
+        group_id: int | None = None,
+    ) -> EventAttachment:
         if type is None:
             type = "event.attachment"
 
@@ -24,13 +31,18 @@ def create_attachment(self, type=None, event_id=None, file_name="hello.png", gro
 
         return self.attachment
 
-    def path(self, types=None, event_ids=None, screenshot=False):
+    def path(
+        self,
+        types: Sequence[str] | None = None,
+        event_ids: Sequence[str] | None = None,
+        screenshot: bool = False,
+    ) -> str:
         path = f"/api/0/issues/{self.group.id}/attachments/"
 
         query = [("types", t) for t in types or ()]
         query.extend([("event_id", id) for id in event_ids or ()])
         if screenshot:
-            query.append(("screenshot", 1))
+            query.append(("screenshot", "1"))
         if query:
             path += "?" + urlencode(query)
 
diff --git a/tests/sentry/issues/endpoints/test_team_all_unresolved_issues.py b/tests/sentry/issues/endpoints/test_team_all_unresolved_issues.py
@@ -1,12 +1,13 @@
 from datetime import datetime, timedelta, timezone
-from typing import Any
 
 from django.utils.timezone import now
+from rest_framework.response import Response
 
 from sentry.models.group import GroupStatus
 from sentry.models.groupassignee import GroupAssignee
 from sentry.models.groupenvironment import GroupEnvironment
 from sentry.models.grouphistory import GroupHistory, GroupHistoryStatus
+from sentry.models.project import Project
 from sentry.testutils.cases import APITestCase
 from sentry.testutils.helpers.datetime import before_now, freeze_time
 
@@ -179,7 +180,9 @@ def test_status_format(self) -> None:
             self.team.organization.slug, self.team.slug, statsPeriod="7d"
         )
 
-        def compare_response(response: Any, project: Any, expected_results: Any) -> None:
+        def compare_response(
+            response: Response, project: Project, expected_results: list[int]
+        ) -> None:
             start = (now() - timedelta(days=len(expected_results) - 1)).replace(
                 hour=0, minute=0, second=0, microsecond=0, tzinfo=timezone.utc
             )
@@ -224,7 +227,9 @@ def test_status_format_with_environment(self) -> None:
             self.team.organization.slug, self.team.slug, statsPeriod="7d", environment="production"
         )
 
-        def compare_response(response: Any, project: Any, expected_results: Any) -> None:
+        def compare_response(
+            response: Response, project: Project, expected_results: list[int]
+        ) -> None:
             start = (now() - timedelta(days=len(expected_results) - 1)).replace(
                 hour=0, minute=0, second=0, microsecond=0, tzinfo=timezone.utc
             )
diff --git a/tests/sentry/issues/endpoints/test_team_issue_breakdown.py b/tests/sentry/issues/endpoints/test_team_issue_breakdown.py
@@ -48,7 +48,9 @@ def test_status_format(self) -> None:
             self.team.organization.slug, self.team.slug, statsPeriod="7d", statuses=statuses
         )
 
-        def compare_response(statuses, data_for_day, **expected_status_counts):
+        def compare_response(
+            statuses: list[str], data_for_day: dict[str, int], **expected_status_counts: int
+        ) -> None:
             result = {status: 0 for status in statuses}
             result["total"] = 0
             result.update(expected_status_counts)
@@ -116,7 +118,9 @@ def test_filter_by_environment(self) -> None:
             environment="prod",
         )
 
-        def compare_response(statuses, data_for_day, **expected_status_counts):
+        def compare_response(
+            statuses: list[str], data_for_day: dict[str, int], **expected_status_counts: int
+        ) -> None:
             result = {status: 0 for status in statuses}
             result["total"] = 0
             result.update(expected_status_counts)
diff --git a/tests/sentry/issues/test_issue_search.py b/tests/sentry/issues/test_issue_search.py
@@ -9,7 +9,10 @@
     SearchKey,
     SearchValue,
 )
-from sentry.api.issue_search import (
+from sentry.exceptions import InvalidSearchQuery
+from sentry.issues.grouptype import GroupCategory
+from sentry.issues.grouptype import registry as GROUP_TYPE_REGISTRY
+from sentry.issues.issue_search import (
     convert_actor_or_none_value,
     convert_category_value,
     convert_device_class_value,
@@ -21,9 +24,6 @@
     parse_search_query,
     value_converters,
 )
-from sentry.exceptions import InvalidSearchQuery
-from sentry.issues.grouptype import GroupCategory
-from sentry.issues.grouptype import registry as GROUP_TYPE_REGISTRY
 from sentry.models.group import GROUP_SUBSTATUS_TO_STATUS_MAP, STATUS_QUERY_CHOICES, GroupStatus
 from sentry.models.release import ReleaseStatus
 from sentry.search.utils import get_teams_for_users
diff --git a/tests/snuba/search/test_backend.py b/tests/snuba/search/test_backend.py
@@ -7,7 +7,6 @@
 from django.utils import timezone
 
 from sentry import options
-from sentry.api.issue_search import convert_query_values, issue_search_config, parse_search_query
 from sentry.exceptions import InvalidSearchQuery
 from sentry.grouping.grouptype import ErrorGroupType
 from sentry.incidents.grouptype import MetricIssue
@@ -18,6 +17,7 @@
     PerformanceRenderBlockingAssetSpanGroupType,
 )
 from sentry.issues.ingest import send_issue_occurrence_to_eventstream
+from sentry.issues.issue_search import convert_query_values, issue_search_config, parse_search_query
 from sentry.models.environment import Environment
 from sentry.models.group import Group, GroupStatus
 from sentry.models.groupassignee import GroupAssignee
