ref(spans): Rename __sentry_internal to sentry._internal attributes (#97560)

See getsentry/sentry-conventions#98

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>

Author: jan-auer

src/sentry/spans/buffer.py

@@ -432,10 +432,10 @@ def flush_segments(self, now: int) -> dict[SegmentKey, FlushedSegment]:
 
                 val_data = val.setdefault("data", {})
                 if isinstance(val_data, dict):
-                    val_data["__sentry_internal_span_buffer_outcome"] = outcome
+                    val_data["sentry._internal.span_buffer_segment_id_outcome"] = outcome
 
                     if old_segment_id:
-                        val_data["__sentry_internal_old_segment_id"] = old_segment_id
+                        val_data["sentry._internal.span_buffer_old_segment_id"] = old_segment_id
 
                 val["segment_id"] = segment_span_id
 

static/app/views/performance/newTraceDetails/traceDrawer/details/span/eapSections/attributes.tsx

@@ -110,9 +110,14 @@ export function Attributes({
       attribute => !HIDDEN_ATTRIBUTES.includes(attribute.name)
     );
 
-    // `__sentry_internal` attributes are used to track internal system behavior (e.g., the span buffer outcomes). Only show these to Sentry staff.
+    // `sentry._internal` attributes are used to track internal system behavior (e.g., the span buffer outcomes). Only show these to Sentry staff.
     const onlyAllowedAttributes = onlyVisibleAttributes.filter(attribute => {
-      if (attribute.name.startsWith('__sentry_internal') && !isSentryEmployee) {
+      if (
+        (attribute.name.startsWith('sentry._internal') ||
+          attribute.name.startsWith('sentry._meta') ||
+          attribute.name.startsWith('__sentry_internal')) &&
+        !isSentryEmployee
+      ) {
         return false;
       }
 

tests/sentry/spans/consumers/process/test_consumer.py

@@ -77,7 +77,7 @@ def add_commit(offsets, force=False):
                 "spans": [
                     {
                         "data": {
-                            "__sentry_internal_span_buffer_outcome": "different",
+                            "sentry._internal.span_buffer_segment_id_outcome": "different",
                         },
                         "is_segment": True,
                         "project_id": 12,

tests/sentry/spans/test_buffer.py

@@ -46,7 +46,7 @@ def _output_segment(span_id: bytes, segment_id: bytes, is_segment: bool) -> Outp
     return OutputSpan(
         payload={
             "data": {
-                "__sentry_internal_span_buffer_outcome": "different",
+                "sentry._internal.span_buffer_segment_id_outcome": "different",
             },
             "span_id": span_id.decode("ascii"),
             "segment_id": segment_id.decode("ascii"),