feat(insights): use conditional functions frontend overview (#90815)

1. Use conditional versions of avg, sum, percentile and epm in frontend
overview
2. Remove `time_spent_percentage` (we'll only be showing time_spent for
now, aka `sum(span.duration)`)

Author: DominikB2014

static/app/views/insights/common/components/tableCells/renderHeadCell.tsx

@@ -31,6 +31,7 @@ const {
   TIME_SPENT_PERCENTAGE,
   SPS,
   EPM,
+  TPM,
   HTTP_RESPONSE_COUNT,
   HTTP_RESPONSE_RATE,
   CACHE_HIT_RATE,
@@ -48,6 +49,7 @@ const SORTABLE_FIELDS = new Set([
   `count()`,
   `${SPS}()`,
   `${EPM}()`,
+  `${TPM}()`,
   `${TIME_SPENT_PERCENTAGE}()`,
   `${HTTP_RESPONSE_COUNT}(5)`,
   `${HTTP_RESPONSE_COUNT}(4)`,
@@ -79,6 +81,10 @@ const SORTABLE_FIELDS = new Set([
   'failure_rate()',
   'performance_score(measurements.score.total)',
   'count_unique(user)',
+  'p50_if(span.duration,is_transaction,true)',
+  'p95_if(span.duration,is_transaction,true)',
+  'failure_rate_if(is_transaction,true)',
+  'sum_if(span.duration,is_transaction,true)',
 ]);
 
 const NUMERIC_FIELDS = new Set([

static/app/views/insights/constants.tsx

@@ -20,6 +20,12 @@ export const STARFISH_AGGREGATION_FIELDS: Record<
     defaultOutputType: 'number',
     valueType: FieldValueType.NUMBER,
   },
+  [SpanFunction.TPM]: {
+    desc: t('Transactions per minute'),
+    kind: FieldKind.FUNCTION,
+    defaultOutputType: 'number',
+    valueType: FieldValueType.NUMBER,
+  },
   [SpanFunction.TIME_SPENT_PERCENTAGE]: {
     desc: t('Span time spent percentage'),
     defaultOutputType: 'percentage',

static/app/views/insights/pages/frontend/frontendOverviewPage.tsx

@@ -191,14 +191,13 @@ function EAPOverviewPage() {
         'is_starred_transaction',
         'transaction',
         'project',
-        'epm()',
-        'p50(span.duration)',
-        'p95(span.duration)',
-        'failure_rate()',
-        'time_spent_percentage(span.duration)',
+        'tpm()',
+        'p50_if(span.duration,is_transaction,true)',
+        'p95_if(span.duration,is_transaction,true)',
+        'failure_rate_if(is_transaction,true)',
         'performance_score(measurements.score.total)',
         'count_unique(user)',
-        'sum(span.duration)',
+        'sum_if(span.duration,is_transaction,true)',
       ],
     },
     'api.performance.landing-table'

static/app/views/insights/pages/frontend/frontendOverviewTable.tsx

@@ -27,27 +27,25 @@ type Row = Pick<
   | 'is_starred_transaction'
   | 'transaction'
   | 'project'
-  | 'epm()'
-  | 'p50(span.duration)'
-  | 'p95(span.duration)'
-  | 'failure_rate()'
-  | 'time_spent_percentage(span.duration)'
+  | 'tpm()'
+  | 'p50_if(span.duration,is_transaction,true)'
+  | 'p95_if(span.duration,is_transaction,true)'
+  | 'failure_rate_if(is_transaction,true)'
   | 'count_unique(user)'
-  | 'sum(span.duration)'
+  | 'sum_if(span.duration,is_transaction,true)'
   | 'performance_score(measurements.score.total)'
 >;
 
 type Column = GridColumnHeader<
   | 'is_starred_transaction'
   | 'transaction'
   | 'project'
-  | 'epm()'
-  | 'p50(span.duration)'
-  | 'p95(span.duration)'
-  | 'failure_rate()'
-  | 'time_spent_percentage(span.duration)'
+  | 'tpm()'
+  | 'p50_if(span.duration,is_transaction,true)'
+  | 'p95_if(span.duration,is_transaction,true)'
+  | 'failure_rate_if(is_transaction,true)'
   | 'count_unique(user)'
-  | 'sum(span.duration)'
+  | 'sum_if(span.duration,is_transaction,true)'
   | 'performance_score(measurements.score.total)'
 >;
 
@@ -63,22 +61,22 @@ const COLUMN_ORDER: Column[] = [
     width: COL_WIDTH_UNDEFINED,
   },
   {
-    key: 'epm()',
+    key: 'tpm()',
     name: t('TPM'),
     width: COL_WIDTH_UNDEFINED,
   },
   {
-    key: `p50(span.duration)`,
+    key: `p50_if(span.duration,is_transaction,true)`,
     name: t('p50()'),
     width: COL_WIDTH_UNDEFINED,
   },
   {
-    key: 'p95(span.duration)',
+    key: `p95_if(span.duration,is_transaction,true)`,
     name: t('p95()'),
     width: COL_WIDTH_UNDEFINED,
   },
   {
-    key: 'failure_rate()',
+    key: 'failure_rate_if(is_transaction,true)',
     name: t('Failure Rate'),
     width: COL_WIDTH_UNDEFINED,
   },
@@ -88,7 +86,7 @@ const COLUMN_ORDER: Column[] = [
     width: COL_WIDTH_UNDEFINED,
   },
   {
-    key: 'time_spent_percentage(span.duration)',
+    key: 'sum_if(span.duration,is_transaction,true)',
     name: DataTitles.timeSpent,
     width: COL_WIDTH_UNDEFINED,
   },
@@ -103,12 +101,12 @@ const SORTABLE_FIELDS = [
   'is_starred_transaction',
   'transaction',
   'project',
-  'epm()',
-  'p50(span.duration)',
-  'p95(span.duration)',
-  'failure_rate()',
+  'tpm()',
+  'p50_if(span.duration,is_transaction,true)',
+  'p95_if(span.duration,is_transaction,true)',
+  'failure_rate_if(is_transaction,true)',
   'count_unique(user)',
-  'time_spent_percentage(span.duration)',
+  'sum_if(span.duration,is_transaction,true)',
   'performance_score(measurements.score.total)',
 ] as const;
 

static/app/views/insights/pages/frontend/settings.ts

@@ -45,6 +45,6 @@ export const FRONTEND_PLATFORMS: PlatformKey[] = frontend.filter(
 );
 
 export const DEFAULT_SORT: ValidSort = {
-  field: 'time_spent_percentage(span.duration)' satisfies EAPSpanProperty,
+  field: 'sum_if(span.duration,is_transaction,true)' satisfies EAPSpanProperty,
   kind: 'desc',
 };

static/app/views/insights/types.tsx

@@ -161,16 +161,27 @@ export type Aggregate =
   | (typeof COUNTER_AGGREGATES)[number]
   | (typeof DISTRIBUTION_AGGREGATES)[number];
 
+type CounterConditionalAggregate =
+  | `sum_if`
+  | `avg_if`
+  | `p50_if`
+  | `p75_if`
+  | `p90_if`
+  | `p95_if`
+  | `p99_if`;
+
 type ConditionalAggregate =
   | `avg_if`
   | `count_op`
+  | `failure_rate_if`
   | 'trace_status_rate'
   | 'time_spent_percentage';
 
 export const SPAN_FUNCTIONS = [
   'sps',
   'spm',
   'epm',
+  'tpm',
   'count',
   'time_spent_percentage',
   'http_response_rate',
@@ -261,6 +272,8 @@ export type EAPSpanResponse = {
     [SpanMetricsField.USER_GEO_SUBREGION]: SubregionCode;
   } & {
     [Property in SpanFields as `count_unique(${Property})`]: number;
+  } & {
+    [Property in SpanNumberFields as `${CounterConditionalAggregate}(${Property},${string},${string})`]: number;
   };
 
 export type EAPSpanProperty = keyof EAPSpanResponse;
@@ -443,6 +456,7 @@ export type SpanIndexedFieldTypes = SpanIndexedResponse;
 export enum SpanFunction {
   SPS = 'sps',
   EPM = 'epm',
+  TPM = 'tpm',
   TIME_SPENT_PERCENTAGE = 'time_spent_percentage',
   HTTP_RESPONSE_COUNT = 'http_response_count',
   HTTP_RESPONSE_RATE = 'http_response_rate',