You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
chore(cell-actions): use popper strategy fixed instead of portalling (#97593)
### Changes
Instead of portals, use the fixed strategy. Main reason is that
portalling the dropdown to document body does not work with tables in
modals due to stacking issues (e.g., planning to add cell actions to
viewer table modal in dashboards)
There should be no UI change to the dropdown. This change only applies
when `discover-cell-actions-v2` is enabled.
* only be enabled if necessary, e.g. when the dropdown menu is inside a small,
130
131
* scrollable container that messes with the menu's position. Some features, namely
131
132
* submenus, will not work correctly inside portals.
133
+
*
134
+
* Consider passing `strategy` as `'fixed'` before using `usePortal`
132
135
*/
133
136
usePortal?: boolean;
134
137
}
@@ -163,6 +166,8 @@ function DropdownMenu({
163
166
portalContainerRef,
164
167
shouldApplyMinWidth,
165
168
minMenuWidth,
169
+
// This prop is from popperJS and is an alternative to portals. Use this with components like modals where portalling to document body doesn't work well.
0 commit comments