Skip to content

Commit 39279e8

Browse files
committed
Migrate to ReactDOM.findDOMNode
1 parent 0276699 commit 39279e8

File tree

13 files changed

+35
-24
lines changed

13 files changed

+35
-24
lines changed

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
"react": "0.14.0",
2929
"react-bootstrap": "^0.27.0",
3030
"react-document-title": "^1.0.2",
31+
"react-dom": "^0.14.0",
3132
"react-lazy-load": "[email protected]:benvinegar/react-lazy-load.git#3abc798f58afdf34e4bf691e6324bcc636c579ae",
3233
"react-router": "[email protected]:benvinegar/react-router.git#f1ff6c68facff8cd5948e56e3bf9742ffe30625c",
3334
"react-sticky": "^2.5.2",

src/sentry/static/sentry/app/components/autoSelectText.jsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,20 @@
1-
import jQuery from "jquery";
21
import React from "react";
2+
import jQuery from "jquery";
3+
import ReactDOM from "react-dom";
34

45
const AutoSelectText = React.createClass({
56
componentDidMount() {
6-
let ref = React.findDOMNode(this.refs.element);
7+
let ref = ReactDOM.findDOMNode(this.refs.element);
78
jQuery(ref).bind('click', this.selectText);
89
},
910

1011
componentWillUnmount() {
11-
let ref = React.findDOMNode(this.refs.element);
12+
let ref = ReactDOM.findDOMNode(this.refs.element);
1213
jQuery(ref).unbind('click', this.selectText);
1314
},
1415

1516
selectText() {
16-
var node = React.findDOMNode(this.refs.element).firstChild;
17+
var node = ReactDOM.findDOMNode(this.refs.element).firstChild;
1718
if (document.selection) {
1819
let range = document.body.createTextRange();
1920
range.moveToElementText(node);

src/sentry/static/sentry/app/components/clippedBox.jsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import React from "react";
2+
import ReactDOM from "react-dom";
23

34
var ClippedBox = React.createClass({
45
propTypes: {
@@ -20,7 +21,7 @@ var ClippedBox = React.createClass({
2021
},
2122

2223
componentDidMount() {
23-
var renderedHeight = React.findDOMNode(this).offsetHeight;
24+
var renderedHeight = ReactDOM.findDOMNode(this).offsetHeight;
2425

2526
if (renderedHeight > this.props.clipHeight ) {
2627
/*eslint react/no-did-mount-set-state:0*/

src/sentry/static/sentry/app/components/dropdownLink.jsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
import classNames from "classnames";
21
import React from "react";
2+
import ReactDOM from "react-dom";
3+
import classNames from "classnames";
34

45
require("bootstrap/js/dropdown");
56

@@ -20,11 +21,11 @@ var DropdownLink = React.createClass({
2021
},
2122

2223
isOpen() {
23-
return React.findDOMNode(this).classList.contains("open");
24+
return ReactDOM.findDOMNode(this).classList.contains("open");
2425
},
2526

2627
close() {
27-
React.findDOMNode(this).classList.remove("open");
28+
ReactDOM.findDOMNode(this).classList.remove("open");
2829
},
2930

3031
onToggle(e) {

src/sentry/static/sentry/app/components/flotChart.jsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import React from 'react';
2+
import ReactDOM from 'react-dom';
23
import jQuery from 'jquery';
34
import moment from 'moment';
45

@@ -113,7 +114,7 @@ var FlotChart = React.createClass({
113114
lines: { show: false }
114115
};
115116

116-
var chart = React.findDOMNode(this.refs.chartNode);
117+
var chart = ReactDOM.findDOMNode(this.refs.chartNode);
117118
jQuery.plot(chart, series, plotOptions);
118119
},
119120

src/sentry/static/sentry/app/components/projectHeader/projectSelector.jsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import React from "react";
2+
import ReactDOM from "react-dom";
23
import Router from "react-router";
34
import jQuery from "jquery";
45
import ConfigStore from "../../stores/configStore";
@@ -132,7 +133,7 @@ var ProjectSelector = React.createClass({
132133
},
133134

134135
onOpen(evt) {
135-
React.findDOMNode(this.refs.filter).focus();
136+
ReactDOM.findDOMNode(this.refs.filter).focus();
136137
},
137138

138139
onClose() {
@@ -143,7 +144,7 @@ var ProjectSelector = React.createClass({
143144

144145
componentDidUpdate(prevProps, prevState) {
145146
// XXX(dcramer): fix odd dedraw issue as of Chrome 45.0.2454.15 dev (64-bit)
146-
var node = jQuery(React.findDOMNode(this.refs.container));
147+
var node = jQuery(ReactDOM.findDOMNode(this.refs.container));
147148
node.hide().show(0);
148149
},
149150

src/sentry/static/sentry/app/components/searchBar.jsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import React from "react";
2+
import ReactDOM from "react-dom";
23
var PureRenderMixin = require('react/addons').addons.PureRenderMixin;
34

45
var SearchBar = React.createClass({
@@ -24,7 +25,7 @@ var SearchBar = React.createClass({
2425
},
2526

2627
blur() {
27-
React.findDOMNode(this.refs.searchInput).blur();
28+
ReactDOM.findDOMNode(this.refs.searchInput).blur();
2829
},
2930

3031
onSubmit(evt) {

src/sentry/static/sentry/app/components/selectInput.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,12 @@ var SelectInput = React.createClass({
2323
},
2424

2525
create() {
26-
this.select2 = jQuery(this.refs.select.getDOMNode()).select2();
26+
this.select2 = jQuery(this.refs.select).select2();
2727
this.select2.on('change', this.onChange);
2828
},
2929

3030
destroy() {
31-
jQuery(this.refs.select.getDOMNode()).select2('destroy');
31+
jQuery(this.refs.select).select2('destroy');
3232
},
3333

3434
onChange(...args) {

src/sentry/static/sentry/app/mixins/tooltip.jsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import ReactDOM from "react-dom";
12
import $ from "jquery";
23
import "bootstrap/js/tooltip";
34

@@ -10,18 +11,18 @@ export default function (options) {
1011

1112
componentWillUnmount() {
1213
this.removeTooltips();
13-
$(this.getDOMNode()).unbind();
14+
$(ReactDOM.findDOMNode(this)).unbind();
1415
},
1516

1617
attachTooltips() {
17-
$(this.getDOMNode()).tooltip(
18+
$(ReactDOM.findDOMNode(this)).tooltip(
1819
Object.prototype.toString.call(options) === '[object Function]' ?
1920
options.call(this) : options
2021
);
2122
},
2223

2324
removeTooltips() {
24-
$(this.getDOMNode())
25+
$(ReactDOM.findDOMNode(this))
2526
.tooltip("destroy") // destroy tooltips on parent ...
2627
.find(options.selector)
2728
.tooltip("destroy"); // ... and descendents

src/sentry/static/sentry/app/views/ruleEditor/index.jsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import React from "react";
2+
import ReactDOM from "react-dom";
23
import $ from "jquery";
34
import api from "../../api";
45
import IndicatorStore from '../../stores/indicatorStore';
@@ -31,13 +32,13 @@ var RuleEditor = React.createClass({
3132

3233
componentDidUpdate() {
3334
if (this.state.error) {
34-
$(document.body).scrollTop($(React.findDOMNode(this.refs.form)).offset().top);
35+
$(document.body).scrollTop($(ReactDOM.findDOMNode(this.refs.form)).offset().top);
3536
}
3637
},
3738

3839
onSubmit(e) {
3940
e.preventDefault();
40-
var form = $(React.findDOMNode(this.refs.form));
41+
var form = $(ReactDOM.findDOMNode(this.refs.form));
4142
var conditions = [];
4243
form.find('.rule-condition-list .rule-form').each((_, el) => {
4344
conditions.push(this.serializeNode(el));
@@ -46,8 +47,8 @@ var RuleEditor = React.createClass({
4647
form.find('.rule-action-list .rule-form').each((_, el) => {
4748
actions.push(this.serializeNode(el));
4849
});
49-
var actionMatch = $(React.findDOMNode(this.refs.actionMatch)).val();
50-
var name = $(React.findDOMNode(this.refs.name)).val();
50+
var actionMatch = $(ReactDOM.findDOMNode(this.refs.actionMatch)).val();
51+
var name = $(ReactDOM.findDOMNode(this.refs.name)).val();
5152
var data = {
5253
actionMatch: actionMatch,
5354
actions: actions,

0 commit comments

Comments
 (0)