feat(logs): Swap logs to query params context for aggregate sort by r… (#97698)

…eadonly

Switch the read parts for the aggregate sort bys to query params.

Author: Zylphrex

static/app/views/explore/contexts/logs/logsPageParams.tsx

@@ -393,11 +393,6 @@ export function usePersistedLogsPageParams() {
   });
 }
 
-export function useLogsAggregateSortBys() {
-  const {aggregateSortBys} = useLogsPageParams();
-  return aggregateSortBys;
-}
-
 export function useLogsAggregateCursor() {
   const {aggregateCursor} = useLogsPageParams();
   return aggregateCursor;

static/app/views/explore/logs/logsTab.tsx

@@ -30,7 +30,6 @@ import {defaultLogFields} from 'sentry/views/explore/contexts/logs/fields';
 import {useLogsAutoRefreshEnabled} from 'sentry/views/explore/contexts/logs/logsAutoRefreshContext';
 import {useLogsPageDataQueryResult} from 'sentry/views/explore/contexts/logs/logsPageData';
 import {
-  useLogsAggregateSortBys,
   useLogsFields,
   useLogsSearch,
   useSetLogsFields,
@@ -79,6 +78,7 @@ import {useSaveAsItems} from 'sentry/views/explore/logs/useSaveAsItems';
 import {useStreamingTimeseriesResult} from 'sentry/views/explore/logs/useStreamingTimeseriesResult';
 import {calculateAverageLogsPerSecond} from 'sentry/views/explore/logs/utils';
 import {
+  useQueryParamsAggregateSortBys,
   useQueryParamsGroupBys,
   useQueryParamsMode,
   useQueryParamsTopEventsLimit,
@@ -105,7 +105,7 @@ export function LogsTabContent({
   const mode = useQueryParamsMode();
   const topEventsLimit = useQueryParamsTopEventsLimit();
   const queryClient = useQueryClient();
-  const sortBys = useLogsAggregateSortBys();
+  const sortBys = useQueryParamsAggregateSortBys();
   const setMode = useSetQueryParamsMode();
   const setFields = useSetLogsFields();
   const tableData = useLogsPageDataQueryResult();

static/app/views/explore/logs/tables/logsAggregateTable.tsx

@@ -11,7 +11,6 @@ import {useLocation} from 'sentry/utils/useLocation';
 import useOrganization from 'sentry/utils/useOrganization';
 import {
   LOGS_AGGREGATE_CURSOR_KEY,
-  useLogsAggregateSortBys,
   useSetLogsPageParams,
 } from 'sentry/views/explore/contexts/logs/logsPageParams';
 import {LOGS_AGGREGATE_SORT_BYS_KEY} from 'sentry/views/explore/contexts/logs/sortBys';
@@ -21,6 +20,7 @@ import {getLogColors} from 'sentry/views/explore/logs/styles';
 import {useLogsAggregatesQuery} from 'sentry/views/explore/logs/useLogsQuery';
 import {SeverityLevel} from 'sentry/views/explore/logs/utils';
 import {
+  useQueryParamsAggregateSortBys,
   useQueryParamsGroupBys,
   useQueryParamsVisualizes,
 } from 'sentry/views/explore/queryParams/context';
@@ -33,7 +33,7 @@ export function LogsAggregateTable() {
   const setLogsPageParams = useSetLogsPageParams();
   const groupBys = useQueryParamsGroupBys();
   const visualizes = useQueryParamsVisualizes();
-  const aggregateSortBys = useLogsAggregateSortBys();
+  const aggregateSortBys = useQueryParamsAggregateSortBys();
   const location = useLocation();
   const theme = useTheme();
   const organization = useOrganization();

static/app/views/explore/logs/useLogsQuery.tsx

@@ -23,7 +23,6 @@ import usePageFilters from 'sentry/utils/usePageFilters';
 import {useLogsAutoRefreshEnabled} from 'sentry/views/explore/contexts/logs/logsAutoRefreshContext';
 import {
   useLogsAggregateCursor,
-  useLogsAggregateSortBys,
   useLogsBaseSearch,
   useLogsCursor,
   useLogsFields,
@@ -53,6 +52,7 @@ import {
 } from 'sentry/views/explore/logs/useVirtualStreaming';
 import {getTimeBasedSortBy} from 'sentry/views/explore/logs/utils';
 import {
+  useQueryParamsAggregateSortBys,
   useQueryParamsGroupBys,
   useQueryParamsVisualizes,
 } from 'sentry/views/explore/queryParams/context';
@@ -119,7 +119,7 @@ function useLogsAggregatesQueryKey({
   const projectIds = useLogsProjectIds();
   const groupBys = useQueryParamsGroupBys();
   const visualizes = useQueryParamsVisualizes();
-  const aggregateSortBys = useLogsAggregateSortBys();
+  const aggregateSortBys = useQueryParamsAggregateSortBys();
   const aggregateCursor = useLogsAggregateCursor();
   const fields: string[] = [];
   fields.push(...groupBys.filter(Boolean));
@@ -135,7 +135,7 @@ function useLogsAggregatesQueryKey({
   const eventView = getEventView(
     search,
     fields,
-    aggregateSortBys,
+    aggregateSortBys.slice(),
     pageFilters,
     dataset,
     projectIds

static/app/views/explore/logs/useSaveAsItems.tsx

@@ -37,7 +37,7 @@ interface UseSaveAsItemsOptions {
   interval: string;
   mode: Mode;
   search: MutableSearch;
-  sortBys: Sort[];
+  sortBys: readonly Sort[];
   visualizes: readonly Visualize[];
 }
 

static/app/views/explore/queryParams/context.tsx

@@ -1,6 +1,7 @@
 import type {ReactNode} from 'react';
 import {useCallback, useMemo} from 'react';
 
+import type {Sort} from 'sentry/utils/discover/fields';
 import {createDefinedContext} from 'sentry/utils/performance/contexts/utils';
 import {TOP_EVENTS_LIMIT} from 'sentry/views/explore/hooks/useTopEvents';
 import type {Mode} from 'sentry/views/explore/queryParams/mode';
@@ -82,3 +83,8 @@ export function useQueryParamsTopEventsLimit(): number | undefined {
   const groupBys = useQueryParamsGroupBys();
   return groupBys.every(groupBy => groupBy === '') ? undefined : TOP_EVENTS_LIMIT;
 }
+
+export function useQueryParamsAggregateSortBys(): readonly Sort[] {
+  const queryParams = useQueryParams();
+  return queryParams.aggregateSortBys;
+}