Skip to content

Commit 3a31bd7

Browse files
authored
chore(features) Remove requires_snuba tuple (#75173)
This list came from a time when snuba was optional for local development. We are long past the point of being able to run sentry without snuba and this list is incomplete and unmaintained.
1 parent 8d9ff6a commit 3a31bd7

File tree

2 files changed

+0
-37
lines changed

2 files changed

+0
-37
lines changed

src/sentry/features/__init__.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -48,26 +48,12 @@
4848
#
4949
# NOTE: The actor kwarg should be passed when it's expected that the handler
5050
# needs context of the user.
51-
#
52-
# NOTE: Features that require Snuba to function, add to the
53-
# `requires_snuba` tuple.
5451

5552
default_manager = FeatureManager() # NOQA
5653

5754
register_permanent_features(default_manager)
5855
register_temporary_features(default_manager)
5956

60-
# This is a gross hardcoded list, but there's no
61-
# other sensible way to manage this right now without augmenting
62-
# features themselves in the manager with detections like this.
63-
requires_snuba = (
64-
"organizations:discover",
65-
"organizations:global-views",
66-
"organizations:incidents",
67-
"organizations:minute-resolution-sessions",
68-
"organizations:performance-view",
69-
)
70-
7157
# expose public api
7258
add = default_manager.add
7359
entity_features = default_manager.entity_features

src/sentry/runner/initializer.py

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -656,29 +656,6 @@ def validate_snuba() -> None:
656656
if has_all_snuba_required_backends and eventstream_is_snuba:
657657
return
658658

659-
from sentry.features import requires_snuba as snuba_features
660-
661-
snuba_enabled_features = set()
662-
663-
for feature in snuba_features:
664-
if settings.SENTRY_FEATURES.get(feature, False):
665-
snuba_enabled_features.add(feature)
666-
667-
if snuba_enabled_features and not eventstream_is_snuba:
668-
show_big_error(
669-
"""
670-
You have features enabled which require Snuba,
671-
but you don't have any Snuba compatible configuration.
672-
673-
Features you have enabled:
674-
%s
675-
676-
See: https://github.com/getsentry/snuba#sentry--snuba
677-
"""
678-
% "\n".join(snuba_enabled_features)
679-
)
680-
raise ConfigurationError("Cannot continue without Snuba configured.")
681-
682659
if not eventstream_is_snuba:
683660
show_big_error(
684661
"""

0 commit comments

Comments
 (0)