chore(ACI): Add render_label method for sentry apps (#109123)

Follow up to #108419 and
#108795 to add a `render_label`
method for sentry app actions to be used by the backwards compatible
issue alert serializer.

Author: ceorourke

src/sentry/notifications/notification_action/issue_alert_registry/handlers/sentry_app_issue_alert_handler.py

@@ -1,9 +1,12 @@
 from dataclasses import asdict
 from typing import Any
 
+from rest_framework import serializers
+
 from sentry.notifications.notification_action.registry import issue_alert_handler_registry
 from sentry.notifications.notification_action.types import BaseIssueAlertHandler
 from sentry.sentry_apps.services.app import app_service
+from sentry.sentry_apps.utils.errors import SentryAppError
 from sentry.workflow_engine.models import Action
 from sentry.workflow_engine.typings.notification_action import (
     ActionFieldMapping,
@@ -12,6 +15,8 @@
     SentryAppFormConfigDataBlob,
 )
 
+ValidationError = serializers.ValidationError
+
 
 @issue_alert_handler_registry.register(Action.Type.SENTRY_APP)
 class SentryAppIssueAlertHandler(BaseIssueAlertHandler):
@@ -74,3 +79,36 @@ def get_additional_fields(cls, action: Action, mapping: ActionFieldMapping) -> d
             settings = cls.process_settings(blob.settings)
             return {"settings": settings}
         return {}
+
+    @classmethod
+    def render_label(cls, organization_id: int, blob: dict[str, Any]) -> str:
+        """
+        blob: {
+            'id': 'sentry.rules.actions.notify_event_sentry_app.NotifyEventSentryAppAction',
+            'sentryAppInstallationUuid': 'str,
+        }
+        """
+        sentry_app_installation_uuid = blob.get("sentryAppInstallationUuid")
+
+        installations = app_service.get_many(
+            filter=dict(uuids=[sentry_app_installation_uuid], organization_id=organization_id)
+        )
+        if not installations:
+            raise SentryAppError(
+                f"Sentry App installation with UUID {sentry_app_installation_uuid} not found."
+            )
+
+        sentry_app = installations[0].sentry_app
+        alert_rule_component = None
+        for component in app_service.find_app_components(app_id=sentry_app.id):
+            if component.type == "alert-rule-action":
+                alert_rule_component = component
+                break
+
+        if not alert_rule_component:
+            raise ValidationError(
+                f"Alert Actions are not enabled for the {sentry_app.name} integration."
+            )
+
+        schema_title = alert_rule_component.app_schema.get("title")
+        return schema_title if schema_title is not None else sentry_app.name

tests/sentry/api/serializers/test_rule.py

@@ -1,6 +1,8 @@
+import pytest
 from django.db import DEFAULT_DB_ALIAS, connections
 from django.test.utils import CaptureQueriesContext
 from django.utils import timezone
+from rest_framework import serializers
 
 from sentry.api.serializers import serialize
 from sentry.api.serializers.models.rule import RuleSerializer, WorkflowEngineRuleSerializer
@@ -29,6 +31,8 @@
 from sentry.workflow_engine.models import WorkflowDataConditionGroup, WorkflowFireHistory
 from sentry.workflow_engine.models.data_condition import Condition
 
+ValidationError = serializers.ValidationError
+
 
 @freeze_time()
 class RuleSerializerTest(TestCase):
@@ -628,3 +632,83 @@ def test_azure_devops_action(self) -> None:
             include_workflow_id=False,
         )
         self.assert_equal_serializers(rule)
+
+    def test_sentry_app_render_label(self) -> None:
+        schema = {"elements": [self.create_alert_rule_action_schema()]}
+        sentry_app = self.create_sentry_app(
+            organization=self.organization,
+            name="Test Application",
+            is_alertable=True,
+            schema=schema,
+        )
+        installation = self.create_sentry_app_installation(
+            slug=sentry_app.slug, organization=self.organization
+        )
+
+        action_data = {
+            "id": "sentry.rules.actions.notify_event_sentry_app.NotifyEventSentryAppAction",
+            "sentryAppInstallationUuid": installation.uuid,
+        }
+        rule = self.create_project_rule(
+            project=self.project,
+            action_data=[action_data],
+            condition_data=self.conditions,
+            include_legacy_rule_id=False,
+            include_workflow_id=False,
+        )
+        self.assert_equal_serializers(rule)
+
+    def test_sentry_app_render_label_no_alert_rule_action_schema(self) -> None:
+        schema = {"elements": [self.create_issue_link_schema()]}
+        sentry_app = self.create_sentry_app(
+            organization=self.organization,
+            name="Test Application",
+            is_alertable=True,
+            schema=schema,
+        )
+        installation = self.create_sentry_app_installation(
+            slug=sentry_app.slug, organization=self.organization
+        )
+
+        action_data = {
+            "id": "sentry.rules.actions.notify_event_sentry_app.NotifyEventSentryAppAction",
+            "sentryAppInstallationUuid": installation.uuid,
+        }
+        rule = self.create_project_rule(
+            project=self.project,
+            action_data=[action_data],
+            condition_data=self.conditions,
+            include_legacy_rule_id=False,
+            include_workflow_id=False,
+        )
+        with pytest.raises(ValidationError):
+            self.assert_equal_serializers(rule)
+
+    def test_sentry_app_render_label_no_installation(self) -> None:
+        schema = {"elements": [self.create_alert_rule_action_schema()]}
+        sentry_app = self.create_sentry_app(
+            organization=self.organization,
+            name="Test Application",
+            is_alertable=True,
+            schema=schema,
+        )
+        installation = self.create_sentry_app_installation(
+            slug=sentry_app.slug, organization=self.organization
+        )
+
+        action_data = {
+            "id": "sentry.rules.actions.notify_event_sentry_app.NotifyEventSentryAppAction",
+            "sentryAppInstallationUuid": installation.uuid,
+        }
+        with assume_test_silo_mode(SiloMode.CONTROL):
+            installation.delete()
+
+        rule = self.create_project_rule(
+            project=self.project,
+            action_data=[action_data],
+            condition_data=self.conditions,
+            include_legacy_rule_id=False,
+            include_workflow_id=False,
+        )
+        # actions part of response are both []
+        self.assert_equal_serializers(rule)